Re: [PATCH v8 4/4] Input: synaptics-rmi4 - add SMBus support

2016-06-27 Thread Benjamin Tissoires
On Jun 24 2016 or thereabouts, Dmitry Torokhov wrote: > On Fri, Jun 24, 2016 at 09:19:32AM +0200, Benjamin Tissoires wrote: > > On Jun 23 2016 or thereabouts, Dmitry Torokhov wrote: > > > On Thu, Jun 09, 2016 at 04:53:50PM +0200, Benjamin Tissoires wrote: > > > > + > > > > +static struct

Re: [PATCH v8 4/4] Input: synaptics-rmi4 - add SMBus support

2016-06-27 Thread Benjamin Tissoires
On Jun 24 2016 or thereabouts, Dmitry Torokhov wrote: > On Fri, Jun 24, 2016 at 09:19:32AM +0200, Benjamin Tissoires wrote: > > On Jun 23 2016 or thereabouts, Dmitry Torokhov wrote: > > > On Thu, Jun 09, 2016 at 04:53:50PM +0200, Benjamin Tissoires wrote: > > > > + > > > > +static struct

Re: [PATCH v8 4/4] Input: synaptics-rmi4 - add SMBus support

2016-06-24 Thread Dmitry Torokhov
On Fri, Jun 24, 2016 at 09:19:32AM +0200, Benjamin Tissoires wrote: > On Jun 23 2016 or thereabouts, Dmitry Torokhov wrote: > > On Thu, Jun 09, 2016 at 04:53:50PM +0200, Benjamin Tissoires wrote: > > > + > > > +static struct i2c_driver rmi_smb_driver = { > > > + .driver = { > > > + .owner

Re: [PATCH v8 4/4] Input: synaptics-rmi4 - add SMBus support

2016-06-24 Thread Dmitry Torokhov
On Fri, Jun 24, 2016 at 09:19:32AM +0200, Benjamin Tissoires wrote: > On Jun 23 2016 or thereabouts, Dmitry Torokhov wrote: > > On Thu, Jun 09, 2016 at 04:53:50PM +0200, Benjamin Tissoires wrote: > > > + > > > +static struct i2c_driver rmi_smb_driver = { > > > + .driver = { > > > + .owner

Re: [PATCH v8 4/4] Input: synaptics-rmi4 - add SMBus support

2016-06-24 Thread Benjamin Tissoires
On Jun 23 2016 or thereabouts, Dmitry Torokhov wrote: > Hi Benjamin, > > On Thu, Jun 09, 2016 at 04:53:50PM +0200, Benjamin Tissoires wrote: > > + > > +struct mapping_table_entry { > > + u16 rmiaddr; > > Should be __le16 rmiaddr, otherwise: > > CHECK drivers/input/rmi4/rmi_smbus.c >

Re: [PATCH v8 4/4] Input: synaptics-rmi4 - add SMBus support

2016-06-24 Thread Benjamin Tissoires
On Jun 23 2016 or thereabouts, Dmitry Torokhov wrote: > Hi Benjamin, > > On Thu, Jun 09, 2016 at 04:53:50PM +0200, Benjamin Tissoires wrote: > > + > > +struct mapping_table_entry { > > + u16 rmiaddr; > > Should be __le16 rmiaddr, otherwise: > > CHECK drivers/input/rmi4/rmi_smbus.c >

Re: [PATCH v8 4/4] Input: synaptics-rmi4 - add SMBus support

2016-06-23 Thread Dmitry Torokhov
Hi Benjamin, On Thu, Jun 09, 2016 at 04:53:50PM +0200, Benjamin Tissoires wrote: > + > +struct mapping_table_entry { > + u16 rmiaddr; Should be __le16 rmiaddr, otherwise: CHECK drivers/input/rmi4/rmi_smbus.c drivers/input/rmi4/rmi_smbus.c:116:33: warning: incorrect type in assignment

Re: [PATCH v8 4/4] Input: synaptics-rmi4 - add SMBus support

2016-06-23 Thread Dmitry Torokhov
Hi Benjamin, On Thu, Jun 09, 2016 at 04:53:50PM +0200, Benjamin Tissoires wrote: > + > +struct mapping_table_entry { > + u16 rmiaddr; Should be __le16 rmiaddr, otherwise: CHECK drivers/input/rmi4/rmi_smbus.c drivers/input/rmi4/rmi_smbus.c:116:33: warning: incorrect type in assignment

[PATCH v8 4/4] Input: synaptics-rmi4 - add SMBus support

2016-06-09 Thread Benjamin Tissoires
Code obtained from https://raw.githubusercontent.com/mightybigcar/synaptics-rmi4/jf/drivers/input/rmi4/rmi_smbus.c and updated to match upstream. And fixed to make it work. Signed-off-by: Benjamin Tissoires Signed-off-by: Andrew Duggan ---

[PATCH v8 4/4] Input: synaptics-rmi4 - add SMBus support

2016-06-09 Thread Benjamin Tissoires
Code obtained from https://raw.githubusercontent.com/mightybigcar/synaptics-rmi4/jf/drivers/input/rmi4/rmi_smbus.c and updated to match upstream. And fixed to make it work. Signed-off-by: Benjamin Tissoires Signed-off-by: Andrew Duggan --- new in v5 no changes in v6 changes in v7: - fixed