Re: [PATCH v8 4/5] i2c: aspeed: added driver for Aspeed I2C

2017-06-02 Thread Benjamin Herrenschmidt
On Fri, 2017-06-02 at 02:29 -0700, Brendan Higgins wrote: > > That way you avoid the above lock which is racy, slave activity could > > get in there and trigger an error interrupt clobbering cmd_err for > > example no ? Or am I missing something... > > The slave handler does not touch these

Re: [PATCH v8 4/5] i2c: aspeed: added driver for Aspeed I2C

2017-06-02 Thread Benjamin Herrenschmidt
On Fri, 2017-06-02 at 02:29 -0700, Brendan Higgins wrote: > > That way you avoid the above lock which is racy, slave activity could > > get in there and trigger an error interrupt clobbering cmd_err for > > example no ? Or am I missing something... > > The slave handler does not touch these

Re: [PATCH v8 4/5] i2c: aspeed: added driver for Aspeed I2C

2017-06-02 Thread Brendan Higgins
I addressed all of your comments in my next revision except the one below. >> + time_left = wait_for_completion_timeout(>cmd_complete, >> + bus->adap.timeout); >> + >> + spin_lock_irqsave(>lock, flags); >> + bus->msgs = NULL; >> + if

Re: [PATCH v8 4/5] i2c: aspeed: added driver for Aspeed I2C

2017-06-02 Thread Brendan Higgins
I addressed all of your comments in my next revision except the one below. >> + time_left = wait_for_completion_timeout(>cmd_complete, >> + bus->adap.timeout); >> + >> + spin_lock_irqsave(>lock, flags); >> + bus->msgs = NULL; >> + if

Re: [PATCH v8 4/5] i2c: aspeed: added driver for Aspeed I2C

2017-05-30 Thread Benjamin Herrenschmidt
On Wed, 2017-05-24 at 23:49 -0700, Brendan Higgins wrote: > Added initial master support for Aspeed I2C controller. Supports > fourteen busses present in AST24XX and AST25XX BMC SoCs by Aspeed. Hi Brendan ! It's getting there :-) I have a few comments mostly about some corner cases below.

Re: [PATCH v8 4/5] i2c: aspeed: added driver for Aspeed I2C

2017-05-30 Thread Benjamin Herrenschmidt
On Wed, 2017-05-24 at 23:49 -0700, Brendan Higgins wrote: > Added initial master support for Aspeed I2C controller. Supports > fourteen busses present in AST24XX and AST25XX BMC SoCs by Aspeed. Hi Brendan ! It's getting there :-) I have a few comments mostly about some corner cases below.

[PATCH v8 4/5] i2c: aspeed: added driver for Aspeed I2C

2017-05-25 Thread Brendan Higgins
Added initial master support for Aspeed I2C controller. Supports fourteen busses present in AST24XX and AST25XX BMC SoCs by Aspeed. Signed-off-by: Brendan Higgins --- Changes for v2: - Added single module_init (multiple was breaking some builds). Changes for v3: -

[PATCH v8 4/5] i2c: aspeed: added driver for Aspeed I2C

2017-05-25 Thread Brendan Higgins
Added initial master support for Aspeed I2C controller. Supports fourteen busses present in AST24XX and AST25XX BMC SoCs by Aspeed. Signed-off-by: Brendan Higgins --- Changes for v2: - Added single module_init (multiple was breaking some builds). Changes for v3: - Removed "bus" device tree