RE: [PATCH v9 09/12] KVM: x86: Introduce a function to initialize the PT configuration

2018-06-11 Thread Kang, Luwei
> >>> + /* Initialize and clear the no dependency bits */ > >>> + vmx->pt_desc.ctl_bitmask = ~0ULL; > >> This looks redundant, doesn't it? > > This is a bit mask for RTIT_CTL MSR and it will make & with the value of > > RTIT_CLT from guest. > > The reserved bits will be 1 in this bit mask and the

Re: [PATCH v9 09/12] KVM: x86: Introduce a function to initialize the PT configuration

2018-06-11 Thread Paolo Bonzini
On 08/06/2018 16:56, Kang, Luwei wrote: >>> + /* Initialize and clear the no dependency bits */ >>> + vmx->pt_desc.ctl_bitmask = ~0ULL; >> This looks redundant, doesn't it? > This is a bit mask for RTIT_CTL MSR and it will make & with the value of > RTIT_CLT from guest. > The reserved bits wil

RE: [PATCH v9 09/12] KVM: x86: Introduce a function to initialize the PT configuration

2018-06-08 Thread Kang, Luwei
> On Tue, May 22, 2018 at 12:52:12PM +0800, Luwei Kang wrote: > > Initialize the Intel PT configuration when cpuid update. > > Is it the CPUID configuration? Is it the MSR configuration? Is it both? > Kind of looks like both. Not sure what is the cpuid update, though. > > > Include cpuid inforamt

Re: [PATCH v9 09/12] KVM: x86: Introduce a function to initialize the PT configuration

2018-06-07 Thread Alexander Shishkin
On Tue, May 22, 2018 at 12:52:12PM +0800, Luwei Kang wrote: > Initialize the Intel PT configuration when cpuid update. Is it the CPUID configuration? Is it the MSR configuration? Is it both? Kind of looks like both. Not sure what is the cpuid update, though. > Include cpuid inforamtion, rtit_ctl

[PATCH v9 09/12] KVM: x86: Introduce a function to initialize the PT configuration

2018-05-21 Thread Luwei Kang
Initialize the Intel PT configuration when cpuid update. Include cpuid inforamtion, rtit_ctl bit mask and the number of address ranges. Signed-off-by: Luwei Kang --- arch/x86/kvm/vmx.c | 70 ++ 1 file changed, 70 insertions(+) diff --git a/arc