Re: [PATCH v9 11/15] vb2: add in-fence support to QBUF

2018-05-09 Thread Brian Starkey
On Wed, May 09, 2018 at 01:03:15PM -0300, Ezequiel Garcia wrote: On Wed, 2018-05-09 at 11:36 +0100, Brian Starkey wrote: [..] > @@ -203,9 +215,14 @@ static void __fill_v4l2_buffer(struct vb2_buffer *vb, void *pb) >b->timestamp = ns_to_timeval(vb->timestamp); >b->timecode =

Re: [PATCH v9 11/15] vb2: add in-fence support to QBUF

2018-05-09 Thread Brian Starkey
On Wed, May 09, 2018 at 01:03:15PM -0300, Ezequiel Garcia wrote: On Wed, 2018-05-09 at 11:36 +0100, Brian Starkey wrote: [..] > @@ -203,9 +215,14 @@ static void __fill_v4l2_buffer(struct vb2_buffer *vb, void *pb) >b->timestamp = ns_to_timeval(vb->timestamp); >b->timecode =

Re: [PATCH v9 11/15] vb2: add in-fence support to QBUF

2018-05-09 Thread Ezequiel Garcia
On Wed, 2018-05-09 at 11:36 +0100, Brian Starkey wrote: [..] > > @@ -203,9 +215,14 @@ static void __fill_v4l2_buffer(struct vb2_buffer *vb, > > void *pb) > > b->timestamp = ns_to_timeval(vb->timestamp); > > b->timecode = vbuf->timecode; > > b->sequence = vbuf->sequence; > > -

Re: [PATCH v9 11/15] vb2: add in-fence support to QBUF

2018-05-09 Thread Ezequiel Garcia
On Wed, 2018-05-09 at 11:36 +0100, Brian Starkey wrote: [..] > > @@ -203,9 +215,14 @@ static void __fill_v4l2_buffer(struct vb2_buffer *vb, > > void *pb) > > b->timestamp = ns_to_timeval(vb->timestamp); > > b->timecode = vbuf->timecode; > > b->sequence = vbuf->sequence; > > -

Re: [PATCH v9 11/15] vb2: add in-fence support to QBUF

2018-05-09 Thread Hans Verkuil
On 05/09/18 12:36, Brian Starkey wrote: > Hi Ezequiel, > > On Fri, May 04, 2018 at 05:06:08PM -0300, Ezequiel Garcia wrote: >> From: Gustavo Padovan >> >> Receive in-fence from userspace and add support for waiting on them >> before queueing the buffer to the

Re: [PATCH v9 11/15] vb2: add in-fence support to QBUF

2018-05-09 Thread Hans Verkuil
On 05/09/18 12:36, Brian Starkey wrote: > Hi Ezequiel, > > On Fri, May 04, 2018 at 05:06:08PM -0300, Ezequiel Garcia wrote: >> From: Gustavo Padovan >> >> Receive in-fence from userspace and add support for waiting on them >> before queueing the buffer to the driver. Buffers can't be queued to

Re: [PATCH v9 11/15] vb2: add in-fence support to QBUF

2018-05-09 Thread Brian Starkey
Hi Ezequiel, On Fri, May 04, 2018 at 05:06:08PM -0300, Ezequiel Garcia wrote: From: Gustavo Padovan Receive in-fence from userspace and add support for waiting on them before queueing the buffer to the driver. Buffers can't be queued to the driver before its

Re: [PATCH v9 11/15] vb2: add in-fence support to QBUF

2018-05-09 Thread Brian Starkey
Hi Ezequiel, On Fri, May 04, 2018 at 05:06:08PM -0300, Ezequiel Garcia wrote: From: Gustavo Padovan Receive in-fence from userspace and add support for waiting on them before queueing the buffer to the driver. Buffers can't be queued to the driver before its fences signal. And a buffer can't

Re: [PATCH v9 11/15] vb2: add in-fence support to QBUF

2018-05-09 Thread Brian Starkey
Hi, On Tue, May 08, 2018 at 08:18:06PM -0300, Gustavo Padovan wrote: Hi Hans, On Mon, 2018-05-07 at 14:07 +0200, Hans Verkuil wrote: On 04/05/18 22:06, Ezequiel Garcia wrote: > From: Gustavo Padovan [snip] > diff --git a/include/media/videobuf2-core.h >

Re: [PATCH v9 11/15] vb2: add in-fence support to QBUF

2018-05-09 Thread Brian Starkey
Hi, On Tue, May 08, 2018 at 08:18:06PM -0300, Gustavo Padovan wrote: Hi Hans, On Mon, 2018-05-07 at 14:07 +0200, Hans Verkuil wrote: On 04/05/18 22:06, Ezequiel Garcia wrote: > From: Gustavo Padovan [snip] > diff --git a/include/media/videobuf2-core.h > b/include/media/videobuf2-core.h

Re: [PATCH v9 11/15] vb2: add in-fence support to QBUF

2018-05-09 Thread Hans Verkuil
On 05/08/2018 09:16 PM, Ezequiel Garcia wrote: > On Mon, 2018-05-07 at 14:07 +0200, Hans Verkuil wrote: >> On 04/05/18 22:06, Ezequiel Garcia wrote: >>> @@ -1421,15 +1505,40 @@ int vb2_core_qbuf(struct vb2_queue *q, unsigned int >>> index, void *pb) >>> trace_vb2_qbuf(q, vb); >>> >>> /*

Re: [PATCH v9 11/15] vb2: add in-fence support to QBUF

2018-05-09 Thread Hans Verkuil
On 05/08/2018 09:16 PM, Ezequiel Garcia wrote: > On Mon, 2018-05-07 at 14:07 +0200, Hans Verkuil wrote: >> On 04/05/18 22:06, Ezequiel Garcia wrote: >>> @@ -1421,15 +1505,40 @@ int vb2_core_qbuf(struct vb2_queue *q, unsigned int >>> index, void *pb) >>> trace_vb2_qbuf(q, vb); >>> >>> /*

Re: [PATCH v9 11/15] vb2: add in-fence support to QBUF

2018-05-08 Thread Gustavo Padovan
Hi Hans, On Mon, 2018-05-07 at 14:07 +0200, Hans Verkuil wrote: > On 04/05/18 22:06, Ezequiel Garcia wrote: > > From: Gustavo Padovan > > > > Receive in-fence from userspace and add support for waiting on them > > before queueing the buffer to the driver. Buffers

Re: [PATCH v9 11/15] vb2: add in-fence support to QBUF

2018-05-08 Thread Gustavo Padovan
Hi Hans, On Mon, 2018-05-07 at 14:07 +0200, Hans Verkuil wrote: > On 04/05/18 22:06, Ezequiel Garcia wrote: > > From: Gustavo Padovan > > > > Receive in-fence from userspace and add support for waiting on them > > before queueing the buffer to the driver. Buffers can't be queued > > to the > >

Re: [PATCH v9 11/15] vb2: add in-fence support to QBUF

2018-05-08 Thread Ezequiel Garcia
On Mon, 2018-05-07 at 14:07 +0200, Hans Verkuil wrote: > On 04/05/18 22:06, Ezequiel Garcia wrote: > > From: Gustavo Padovan > > > > Receive in-fence from userspace and add support for waiting on them > > before queueing the buffer to the driver. Buffers can't be

Re: [PATCH v9 11/15] vb2: add in-fence support to QBUF

2018-05-08 Thread Ezequiel Garcia
On Mon, 2018-05-07 at 14:07 +0200, Hans Verkuil wrote: > On 04/05/18 22:06, Ezequiel Garcia wrote: > > From: Gustavo Padovan > > > > Receive in-fence from userspace and add support for waiting on them > > before queueing the buffer to the driver. Buffers can't be queued to the > > driver before

Re: [PATCH v9 11/15] vb2: add in-fence support to QBUF

2018-05-07 Thread Hans Verkuil
On 04/05/18 22:06, Ezequiel Garcia wrote: > From: Gustavo Padovan > > Receive in-fence from userspace and add support for waiting on them > before queueing the buffer to the driver. Buffers can't be queued to the > driver before its fences signal. And a buffer

Re: [PATCH v9 11/15] vb2: add in-fence support to QBUF

2018-05-07 Thread Hans Verkuil
On 04/05/18 22:06, Ezequiel Garcia wrote: > From: Gustavo Padovan > > Receive in-fence from userspace and add support for waiting on them > before queueing the buffer to the driver. Buffers can't be queued to the > driver before its fences signal. And a buffer can't be queued to the driver > out

[PATCH v9 11/15] vb2: add in-fence support to QBUF

2018-05-04 Thread Ezequiel Garcia
From: Gustavo Padovan Receive in-fence from userspace and add support for waiting on them before queueing the buffer to the driver. Buffers can't be queued to the driver before its fences signal. And a buffer can't be queued to the driver out of the order they were

[PATCH v9 11/15] vb2: add in-fence support to QBUF

2018-05-04 Thread Ezequiel Garcia
From: Gustavo Padovan Receive in-fence from userspace and add support for waiting on them before queueing the buffer to the driver. Buffers can't be queued to the driver before its fences signal. And a buffer can't be queued to the driver out of the order they were queued from userspace. That