Re: [PATCH v9 2/3] x86: add support for Huawei WMI hotkeys.

2018-12-07 Thread ayman . bagabas
On Fri, 2018-12-07 at 00:52 -0500, ayman.baga...@gmail.com wrote: On Mon, 2018-12-03 at 21:17 +0200, Andy Shevchenko wrote: > On Mon, Dec 3, 2018 at 9:04 PM Takashi Iwai wrote: > > On Mon, 03 Dec 2018 19:53:39 +0100, > > Ayman Bagabas wrote: > > > + if (code == 0x80) { > > > +

Re: [PATCH v9 2/3] x86: add support for Huawei WMI hotkeys.

2018-12-07 Thread ayman . bagabas
On Fri, 2018-12-07 at 00:52 -0500, ayman.baga...@gmail.com wrote: On Mon, 2018-12-03 at 21:17 +0200, Andy Shevchenko wrote: > On Mon, Dec 3, 2018 at 9:04 PM Takashi Iwai wrote: > > On Mon, 03 Dec 2018 19:53:39 +0100, > > Ayman Bagabas wrote: > > > + if (code == 0x80) { > > > +

Re: [PATCH v9 2/3] x86: add support for Huawei WMI hotkeys.

2018-12-04 Thread ayman . bagabas
On Mon, 2018-12-03 at 21:17 +0200, Andy Shevchenko wrote: > On Mon, Dec 3, 2018 at 9:04 PM Takashi Iwai wrote: > > On Mon, 03 Dec 2018 19:53:39 +0100, > > Ayman Bagabas wrote: > > > + if (code == 0x80) { > > > + acpi_status status; > > > + acpi_handle handle; > > > +

Re: [PATCH v9 2/3] x86: add support for Huawei WMI hotkeys.

2018-12-04 Thread ayman . bagabas
On Mon, 2018-12-03 at 21:17 +0200, Andy Shevchenko wrote: > On Mon, Dec 3, 2018 at 9:04 PM Takashi Iwai wrote: > > On Mon, 03 Dec 2018 19:53:39 +0100, > > Ayman Bagabas wrote: > > > + if (code == 0x80) { > > > + acpi_status status; > > > + acpi_handle handle; > > > +

Re: [PATCH v9 2/3] x86: add support for Huawei WMI hotkeys.

2018-12-04 Thread ayman . bagabas
On Mon, 2018-12-03 at 11:41 -0800, Randy Dunlap wrote: > On 12/3/18 10:53 AM, Ayman Bagabas wrote: > > This driver adds support for missing hotkeys on some Huawei > > laptops. > > Laptops such as the Matebook X have non functioning hotkeys. > > Whereas > > newer laptops such as the Matebook X Pro

Re: [PATCH v9 2/3] x86: add support for Huawei WMI hotkeys.

2018-12-04 Thread ayman . bagabas
On Mon, 2018-12-03 at 11:41 -0800, Randy Dunlap wrote: > On 12/3/18 10:53 AM, Ayman Bagabas wrote: > > This driver adds support for missing hotkeys on some Huawei > > laptops. > > Laptops such as the Matebook X have non functioning hotkeys. > > Whereas > > newer laptops such as the Matebook X Pro

Re: [PATCH v9 2/3] x86: add support for Huawei WMI hotkeys.

2018-12-03 Thread Randy Dunlap
On 12/3/18 10:53 AM, Ayman Bagabas wrote: > This driver adds support for missing hotkeys on some Huawei laptops. > Laptops such as the Matebook X have non functioning hotkeys. Whereas > newer laptops such as the Matebook X Pro come with working hotkeys out > of the box. > > Old laptops, such as

Re: [PATCH v9 2/3] x86: add support for Huawei WMI hotkeys.

2018-12-03 Thread Randy Dunlap
On 12/3/18 10:53 AM, Ayman Bagabas wrote: > This driver adds support for missing hotkeys on some Huawei laptops. > Laptops such as the Matebook X have non functioning hotkeys. Whereas > newer laptops such as the Matebook X Pro come with working hotkeys out > of the box. > > Old laptops, such as

Re: [PATCH v9 2/3] x86: add support for Huawei WMI hotkeys.

2018-12-03 Thread Andy Shevchenko
On Mon, Dec 3, 2018 at 9:04 PM Takashi Iwai wrote: > > On Mon, 03 Dec 2018 19:53:39 +0100, > Ayman Bagabas wrote: > > + if (code == 0x80) { > > + acpi_status status; > > + acpi_handle handle; > > + unsigned long long result; > > + union

Re: [PATCH v9 2/3] x86: add support for Huawei WMI hotkeys.

2018-12-03 Thread Andy Shevchenko
On Mon, Dec 3, 2018 at 9:04 PM Takashi Iwai wrote: > > On Mon, 03 Dec 2018 19:53:39 +0100, > Ayman Bagabas wrote: > > + if (code == 0x80) { > > + acpi_status status; > > + acpi_handle handle; > > + unsigned long long result; > > + union

Re: [PATCH v9 2/3] x86: add support for Huawei WMI hotkeys.

2018-12-03 Thread Takashi Iwai
On Mon, 03 Dec 2018 19:53:39 +0100, Ayman Bagabas wrote: > + if (code == 0x80) { > + acpi_status status; > + acpi_handle handle; > + unsigned long long result; > + union acpi_object args[1]; > + struct acpi_object_list arg_list = { >

Re: [PATCH v9 2/3] x86: add support for Huawei WMI hotkeys.

2018-12-03 Thread Takashi Iwai
On Mon, 03 Dec 2018 19:53:39 +0100, Ayman Bagabas wrote: > + if (code == 0x80) { > + acpi_status status; > + acpi_handle handle; > + unsigned long long result; > + union acpi_object args[1]; > + struct acpi_object_list arg_list = { >

[PATCH v9 2/3] x86: add support for Huawei WMI hotkeys.

2018-12-03 Thread Ayman Bagabas
This driver adds support for missing hotkeys on some Huawei laptops. Laptops such as the Matebook X have non functioning hotkeys. Whereas newer laptops such as the Matebook X Pro come with working hotkeys out of the box. Old laptops, such as the Matebook X, report hotkey events through ACPI

[PATCH v9 2/3] x86: add support for Huawei WMI hotkeys.

2018-12-03 Thread Ayman Bagabas
This driver adds support for missing hotkeys on some Huawei laptops. Laptops such as the Matebook X have non functioning hotkeys. Whereas newer laptops such as the Matebook X Pro come with working hotkeys out of the box. Old laptops, such as the Matebook X, report hotkey events through ACPI