Re: [PATCH v9 4/5] qrwlock: Use smp_store_release() in write_unlock()

2014-01-21 Thread Waiman Long
On 01/20/2014 10:18 AM, Peter Zijlstra wrote: On Tue, Jan 14, 2014 at 11:44:06PM -0500, Waiman Long wrote: This patch modifies the queue_write_unlock() function to use the new smp_store_release() function (currently in tip). It also removes the temporary implementation of smp_load_acquire() and

Re: [PATCH v9 4/5] qrwlock: Use smp_store_release() in write_unlock()

2014-01-21 Thread Peter Zijlstra
On Tue, Jan 21, 2014 at 10:45:42AM -0500, Waiman Long wrote: > I can change the logic to use only cmpxchg for readers, but I don't see a > compelling reason to do so. The fact that you can then use smp_store_release() is fairly compelling methinks. -- To unsubscribe from this list: send the line

Re: [PATCH v9 4/5] qrwlock: Use smp_store_release() in write_unlock()

2014-01-21 Thread Peter Zijlstra
On Tue, Jan 21, 2014 at 10:45:42AM -0500, Waiman Long wrote: I can change the logic to use only cmpxchg for readers, but I don't see a compelling reason to do so. The fact that you can then use smp_store_release() is fairly compelling methinks. -- To unsubscribe from this list: send the line

Re: [PATCH v9 4/5] qrwlock: Use smp_store_release() in write_unlock()

2014-01-21 Thread Waiman Long
On 01/20/2014 10:18 AM, Peter Zijlstra wrote: On Tue, Jan 14, 2014 at 11:44:06PM -0500, Waiman Long wrote: This patch modifies the queue_write_unlock() function to use the new smp_store_release() function (currently in tip). It also removes the temporary implementation of smp_load_acquire() and

Re: [PATCH v9 4/5] qrwlock: Use smp_store_release() in write_unlock()

2014-01-20 Thread Peter Zijlstra
On Tue, Jan 14, 2014 at 11:44:06PM -0500, Waiman Long wrote: > This patch modifies the queue_write_unlock() function to use the new > smp_store_release() function (currently in tip). It also removes the > temporary implementation of smp_load_acquire() and smp_store_release() > function in

Re: [PATCH v9 4/5] qrwlock: Use smp_store_release() in write_unlock()

2014-01-20 Thread Peter Zijlstra
On Tue, Jan 14, 2014 at 11:44:06PM -0500, Waiman Long wrote: This patch modifies the queue_write_unlock() function to use the new smp_store_release() function (currently in tip). It also removes the temporary implementation of smp_load_acquire() and smp_store_release() function in qrwlock.c.

Re: [PATCH v9 4/5] qrwlock: Use smp_store_release() in write_unlock()

2014-01-19 Thread Paul E. McKenney
On Tue, Jan 14, 2014 at 11:44:06PM -0500, Waiman Long wrote: > This patch modifies the queue_write_unlock() function to use the new > smp_store_release() function (currently in tip). It also removes the > temporary implementation of smp_load_acquire() and smp_store_release() > function in

Re: [PATCH v9 4/5] qrwlock: Use smp_store_release() in write_unlock()

2014-01-19 Thread Paul E. McKenney
On Tue, Jan 14, 2014 at 11:44:06PM -0500, Waiman Long wrote: This patch modifies the queue_write_unlock() function to use the new smp_store_release() function (currently in tip). It also removes the temporary implementation of smp_load_acquire() and smp_store_release() function in qrwlock.c.

[PATCH v9 4/5] qrwlock: Use smp_store_release() in write_unlock()

2014-01-14 Thread Waiman Long
This patch modifies the queue_write_unlock() function to use the new smp_store_release() function (currently in tip). It also removes the temporary implementation of smp_load_acquire() and smp_store_release() function in qrwlock.c. This patch will use atomic subtraction instead if the writer

[PATCH v9 4/5] qrwlock: Use smp_store_release() in write_unlock()

2014-01-14 Thread Waiman Long
This patch modifies the queue_write_unlock() function to use the new smp_store_release() function (currently in tip). It also removes the temporary implementation of smp_load_acquire() and smp_store_release() function in qrwlock.c. This patch will use atomic subtraction instead if the writer