Re: [PATCH vhost v4 02/15] vdpa: Add VHOST_BACKEND_F_CHANGEABLE_VQ_ADDR_IN_SUSPEND flag

2023-12-25 Thread Dragos Tatulea
On Fri, 2023-12-22 at 11:51 +0100, Dragos Tatulea wrote: > On Fri, 2023-12-22 at 03:29 -0500, Michael S. Tsirkin wrote: > > On Thu, Dec 21, 2023 at 03:07:22PM +, Dragos Tatulea wrote: > > > > > > In that case you're right, we don't need feature flags. But I think > > > > > > it > > > > > >

Re: [PATCH vhost v4 02/15] vdpa: Add VHOST_BACKEND_F_CHANGEABLE_VQ_ADDR_IN_SUSPEND flag

2023-12-22 Thread Dragos Tatulea
On Fri, 2023-12-22 at 03:29 -0500, Michael S. Tsirkin wrote: > On Thu, Dec 21, 2023 at 03:07:22PM +, Dragos Tatulea wrote: > > > > > In that case you're right, we don't need feature flags. But I think it > > > > > would be great to also move the error return in case userspace tries > > > > >

Re: [PATCH vhost v4 02/15] vdpa: Add VHOST_BACKEND_F_CHANGEABLE_VQ_ADDR_IN_SUSPEND flag

2023-12-22 Thread Michael S. Tsirkin
On Thu, Dec 21, 2023 at 03:07:22PM +, Dragos Tatulea wrote: > > > > In that case you're right, we don't need feature flags. But I think it > > > > would be great to also move the error return in case userspace tries > > > > to modify vq parameters out of suspend state. > > > > > > > On the

Re: [PATCH vhost v4 02/15] vdpa: Add VHOST_BACKEND_F_CHANGEABLE_VQ_ADDR_IN_SUSPEND flag

2023-12-21 Thread Eugenio Perez Martin
On Thu, Dec 21, 2023 at 4:07 PM Dragos Tatulea wrote: > > On Thu, 2023-12-21 at 15:55 +0100, Eugenio Perez Martin wrote: > > On Thu, Dec 21, 2023 at 3:38 PM Dragos Tatulea wrote: > > > > > > On Thu, 2023-12-21 at 13:08 +0100, Eugenio Perez Martin wrote: > > > > On Thu, Dec 21, 2023 at 12:52 PM

Re: [PATCH vhost v4 02/15] vdpa: Add VHOST_BACKEND_F_CHANGEABLE_VQ_ADDR_IN_SUSPEND flag

2023-12-21 Thread Jason Wang
On Thu, Dec 21, 2023 at 3:47 PM Eugenio Perez Martin wrote: > > On Thu, Dec 21, 2023 at 3:03 AM Jason Wang wrote: > > > > On Wed, Dec 20, 2023 at 9:32 PM Eugenio Perez Martin > > wrote: > > > > > > On Wed, Dec 20, 2023 at 5:06 AM Jason Wang wrote: > > > > > > > > On Wed, Dec 20, 2023 at 11:46 

Re: [PATCH vhost v4 02/15] vdpa: Add VHOST_BACKEND_F_CHANGEABLE_VQ_ADDR_IN_SUSPEND flag

2023-12-21 Thread Dragos Tatulea
On Thu, 2023-12-21 at 15:55 +0100, Eugenio Perez Martin wrote: > On Thu, Dec 21, 2023 at 3:38 PM Dragos Tatulea wrote: > > > > On Thu, 2023-12-21 at 13:08 +0100, Eugenio Perez Martin wrote: > > > On Thu, Dec 21, 2023 at 12:52 PM Dragos Tatulea > > > wrote: > > > > > > > > On Thu, 2023-12-21

Re: [PATCH vhost v4 02/15] vdpa: Add VHOST_BACKEND_F_CHANGEABLE_VQ_ADDR_IN_SUSPEND flag

2023-12-21 Thread Eugenio Perez Martin
On Thu, Dec 21, 2023 at 3:38 PM Dragos Tatulea wrote: > > On Thu, 2023-12-21 at 13:08 +0100, Eugenio Perez Martin wrote: > > On Thu, Dec 21, 2023 at 12:52 PM Dragos Tatulea wrote: > > > > > > On Thu, 2023-12-21 at 08:46 +0100, Eugenio Perez Martin wrote: > > > > On Thu, Dec 21, 2023 at 3:03 AM

Re: [PATCH vhost v4 02/15] vdpa: Add VHOST_BACKEND_F_CHANGEABLE_VQ_ADDR_IN_SUSPEND flag

2023-12-21 Thread Dragos Tatulea
On Thu, 2023-12-21 at 13:08 +0100, Eugenio Perez Martin wrote: > On Thu, Dec 21, 2023 at 12:52 PM Dragos Tatulea wrote: > > > > On Thu, 2023-12-21 at 08:46 +0100, Eugenio Perez Martin wrote: > > > On Thu, Dec 21, 2023 at 3:03 AM Jason Wang wrote: > > > > > > > > On Wed, Dec 20, 2023 at 9:32 PM

Re: [PATCH vhost v4 02/15] vdpa: Add VHOST_BACKEND_F_CHANGEABLE_VQ_ADDR_IN_SUSPEND flag

2023-12-21 Thread Eugenio Perez Martin
On Thu, Dec 21, 2023 at 12:52 PM Dragos Tatulea wrote: > > On Thu, 2023-12-21 at 08:46 +0100, Eugenio Perez Martin wrote: > > On Thu, Dec 21, 2023 at 3:03 AM Jason Wang wrote: > > > > > > On Wed, Dec 20, 2023 at 9:32 PM Eugenio Perez Martin > > > wrote: > > > > > > > > On Wed, Dec 20, 2023 at

Re: [PATCH vhost v4 02/15] vdpa: Add VHOST_BACKEND_F_CHANGEABLE_VQ_ADDR_IN_SUSPEND flag

2023-12-21 Thread Dragos Tatulea
On Thu, 2023-12-21 at 08:46 +0100, Eugenio Perez Martin wrote: > On Thu, Dec 21, 2023 at 3:03 AM Jason Wang wrote: > > > > On Wed, Dec 20, 2023 at 9:32 PM Eugenio Perez Martin > > wrote: > > > > > > On Wed, Dec 20, 2023 at 5:06 AM Jason Wang wrote: > > > > > > > > On Wed, Dec 20, 2023 at

Re: [PATCH vhost v4 02/15] vdpa: Add VHOST_BACKEND_F_CHANGEABLE_VQ_ADDR_IN_SUSPEND flag

2023-12-20 Thread Eugenio Perez Martin
On Thu, Dec 21, 2023 at 3:03 AM Jason Wang wrote: > > On Wed, Dec 20, 2023 at 9:32 PM Eugenio Perez Martin > wrote: > > > > On Wed, Dec 20, 2023 at 5:06 AM Jason Wang wrote: > > > > > > On Wed, Dec 20, 2023 at 11:46 AM Jason Wang wrote: > > > > > > > > On Wed, Dec 20, 2023 at 2:09 AM Dragos

Re: [PATCH vhost v4 02/15] vdpa: Add VHOST_BACKEND_F_CHANGEABLE_VQ_ADDR_IN_SUSPEND flag

2023-12-20 Thread Jason Wang
On Wed, Dec 20, 2023 at 9:32 PM Eugenio Perez Martin wrote: > > On Wed, Dec 20, 2023 at 5:06 AM Jason Wang wrote: > > > > On Wed, Dec 20, 2023 at 11:46 AM Jason Wang wrote: > > > > > > On Wed, Dec 20, 2023 at 2:09 AM Dragos Tatulea > > > wrote: > > > > > > > > The virtio spec doesn't allow

Re: [PATCH vhost v4 02/15] vdpa: Add VHOST_BACKEND_F_CHANGEABLE_VQ_ADDR_IN_SUSPEND flag

2023-12-20 Thread Eugenio Perez Martin
On Tue, Dec 19, 2023 at 7:09 PM Dragos Tatulea wrote: > > The virtio spec doesn't allow changing virtqueue addresses after > DRIVER_OK. Some devices do support this operation when the device is > suspended. The VHOST_BACKEND_F_CHANGEABLE_VQ_ADDR_IN_SUSPEND flag > advertises this support as a

Re: [PATCH vhost v4 02/15] vdpa: Add VHOST_BACKEND_F_CHANGEABLE_VQ_ADDR_IN_SUSPEND flag

2023-12-20 Thread Eugenio Perez Martin
On Wed, Dec 20, 2023 at 5:06 AM Jason Wang wrote: > > On Wed, Dec 20, 2023 at 11:46 AM Jason Wang wrote: > > > > On Wed, Dec 20, 2023 at 2:09 AM Dragos Tatulea wrote: > > > > > > The virtio spec doesn't allow changing virtqueue addresses after > > > DRIVER_OK. Some devices do support this

Re: [PATCH vhost v4 02/15] vdpa: Add VHOST_BACKEND_F_CHANGEABLE_VQ_ADDR_IN_SUSPEND flag

2023-12-20 Thread Dragos Tatulea
On Wed, 2023-12-20 at 12:05 +0800, Jason Wang wrote: > On Wed, Dec 20, 2023 at 11:46 AM Jason Wang wrote: > > > > On Wed, Dec 20, 2023 at 2:09 AM Dragos Tatulea wrote: > > > > > > The virtio spec doesn't allow changing virtqueue addresses after > > > DRIVER_OK. Some devices do support this

Re: [PATCH vhost v4 02/15] vdpa: Add VHOST_BACKEND_F_CHANGEABLE_VQ_ADDR_IN_SUSPEND flag

2023-12-19 Thread Jason Wang
On Wed, Dec 20, 2023 at 11:46 AM Jason Wang wrote: > > On Wed, Dec 20, 2023 at 2:09 AM Dragos Tatulea wrote: > > > > The virtio spec doesn't allow changing virtqueue addresses after > > DRIVER_OK. Some devices do support this operation when the device is > > suspended. The

Re: [PATCH vhost v4 02/15] vdpa: Add VHOST_BACKEND_F_CHANGEABLE_VQ_ADDR_IN_SUSPEND flag

2023-12-19 Thread Jason Wang
On Wed, Dec 20, 2023 at 2:09 AM Dragos Tatulea wrote: > > The virtio spec doesn't allow changing virtqueue addresses after > DRIVER_OK. Some devices do support this operation when the device is > suspended. The VHOST_BACKEND_F_CHANGEABLE_VQ_ADDR_IN_SUSPEND flag > advertises this support as a

[PATCH vhost v4 02/15] vdpa: Add VHOST_BACKEND_F_CHANGEABLE_VQ_ADDR_IN_SUSPEND flag

2023-12-19 Thread Dragos Tatulea
The virtio spec doesn't allow changing virtqueue addresses after DRIVER_OK. Some devices do support this operation when the device is suspended. The VHOST_BACKEND_F_CHANGEABLE_VQ_ADDR_IN_SUSPEND flag advertises this support as a backend features. Signed-off-by: Dragos Tatulea Suggested-by: