Re: [PATCHES] tty ioctls cleanups, compat and not only

2018-09-14 Thread Arnd Bergmann
On Fri, Sep 14, 2018 at 5:10 PM Al Viro wrote: > > On Fri, Sep 14, 2018 at 10:21:53AM +0200, Arnd Bergmann wrote: > > > This does sound very appealing, but there is a small downside: > > The difference between ".compat_ioctl = NULL" and > > ".compat_ioctl=native_ioctl" is now very subtle, and I

Re: [PATCHES] tty ioctls cleanups, compat and not only

2018-09-14 Thread Arnd Bergmann
On Fri, Sep 14, 2018 at 5:10 PM Al Viro wrote: > > On Fri, Sep 14, 2018 at 10:21:53AM +0200, Arnd Bergmann wrote: > > > This does sound very appealing, but there is a small downside: > > The difference between ".compat_ioctl = NULL" and > > ".compat_ioctl=native_ioctl" is now very subtle, and I

Re: [PATCHES] tty ioctls cleanups, compat and not only

2018-09-14 Thread Al Viro
On Fri, Sep 14, 2018 at 10:21:53AM +0200, Arnd Bergmann wrote: > This does sound very appealing, but there is a small downside: > The difference between ".compat_ioctl = NULL" and > ".compat_ioctl=native_ioctl" is now very subtle, and I wouldn't > necessarily expect casual readers to understand

Re: [PATCHES] tty ioctls cleanups, compat and not only

2018-09-14 Thread Al Viro
On Fri, Sep 14, 2018 at 10:21:53AM +0200, Arnd Bergmann wrote: > This does sound very appealing, but there is a small downside: > The difference between ".compat_ioctl = NULL" and > ".compat_ioctl=native_ioctl" is now very subtle, and I wouldn't > necessarily expect casual readers to understand

Re: [PATCHES] tty ioctls cleanups, compat and not only

2018-09-14 Thread Arnd Bergmann
On Fri, Sep 14, 2018 at 4:27 AM Al Viro wrote: > On Thu, Sep 13, 2018 at 10:56:48PM +0200, Arnd Bergmann wrote: > commit de36af5ca465156863b5fb7548e3660ea7d3bbcf > Author: Al Viro > Date: Thu Sep 13 22:12:15 2018 -0400 > > change semantics of ldisc ->compat_ioctl() > > First of all,

Re: [PATCHES] tty ioctls cleanups, compat and not only

2018-09-14 Thread Arnd Bergmann
On Fri, Sep 14, 2018 at 4:27 AM Al Viro wrote: > On Thu, Sep 13, 2018 at 10:56:48PM +0200, Arnd Bergmann wrote: > commit de36af5ca465156863b5fb7548e3660ea7d3bbcf > Author: Al Viro > Date: Thu Sep 13 22:12:15 2018 -0400 > > change semantics of ldisc ->compat_ioctl() > > First of all,

Re: [PATCHES] tty ioctls cleanups, compat and not only

2018-09-13 Thread Al Viro
On Thu, Sep 13, 2018 at 10:56:48PM +0200, Arnd Bergmann wrote: > Yes, I saw that too, but couldn't figure out exactly what ipwireless > does. I suppose it is some serial port driver that comes with a > hardcoded ppp implementation instead of a switchable ldisc? NFI... > > > * SIOCGIFNAME,

Re: [PATCHES] tty ioctls cleanups, compat and not only

2018-09-13 Thread Al Viro
On Thu, Sep 13, 2018 at 10:56:48PM +0200, Arnd Bergmann wrote: > Yes, I saw that too, but couldn't figure out exactly what ipwireless > does. I suppose it is some serial port driver that comes with a > hardcoded ppp implementation instead of a switchable ldisc? NFI... > > > * SIOCGIFNAME,

Re: [PATCHES] tty ioctls cleanups, compat and not only

2018-09-13 Thread Arnd Bergmann
On Thu, Sep 13, 2018 at 10:31 PM Al Viro wrote: > > On Thu, Sep 13, 2018 at 01:19:42PM +0200, Arnd Bergmann wrote: > > On Thu, Sep 13, 2018 at 4:31 AM Al Viro wrote: > > * TIOCSERGWILD/TIOCSERSWILD are obsolete and never do > >anything useful, but the return code is inconsistent: ENOTTY > >

Re: [PATCHES] tty ioctls cleanups, compat and not only

2018-09-13 Thread Arnd Bergmann
On Thu, Sep 13, 2018 at 10:31 PM Al Viro wrote: > > On Thu, Sep 13, 2018 at 01:19:42PM +0200, Arnd Bergmann wrote: > > On Thu, Sep 13, 2018 at 4:31 AM Al Viro wrote: > > * TIOCSERGWILD/TIOCSERSWILD are obsolete and never do > >anything useful, but the return code is inconsistent: ENOTTY > >

Re: [PATCHES] tty ioctls cleanups, compat and not only

2018-09-13 Thread Al Viro
On Thu, Sep 13, 2018 at 01:19:42PM +0200, Arnd Bergmann wrote: > On Thu, Sep 13, 2018 at 4:31 AM Al Viro wrote: > > > > See vfs.git#work.tty-ioctl. Completely untested, should seriously > > clean the things up wrt compat. Remaining problems (aside of the bugs > > introduced in it, of

Re: [PATCHES] tty ioctls cleanups, compat and not only

2018-09-13 Thread Al Viro
On Thu, Sep 13, 2018 at 01:19:42PM +0200, Arnd Bergmann wrote: > On Thu, Sep 13, 2018 at 4:31 AM Al Viro wrote: > > > > See vfs.git#work.tty-ioctl. Completely untested, should seriously > > clean the things up wrt compat. Remaining problems (aside of the bugs > > introduced in it, of

Re: [PATCHES] tty ioctls cleanups, compat and not only

2018-09-13 Thread Greg Kroah-Hartman
On Thu, Sep 13, 2018 at 03:31:19AM +0100, Al Viro wrote: > See vfs.git#work.tty-ioctl. Completely untested, should seriously > clean the things up wrt compat. Remaining problems (aside of the bugs > introduced in it, of course): > * TIOCSERGSTRUCT must die; it's present only in

Re: [PATCHES] tty ioctls cleanups, compat and not only

2018-09-13 Thread Greg Kroah-Hartman
On Thu, Sep 13, 2018 at 03:31:19AM +0100, Al Viro wrote: > See vfs.git#work.tty-ioctl. Completely untested, should seriously > clean the things up wrt compat. Remaining problems (aside of the bugs > introduced in it, of course): > * TIOCSERGSTRUCT must die; it's present only in

Re: [PATCHES] tty ioctls cleanups, compat and not only

2018-09-13 Thread Arnd Bergmann
On Thu, Sep 13, 2018 at 4:31 AM Al Viro wrote: > > See vfs.git#work.tty-ioctl. Completely untested, should seriously > clean the things up wrt compat. Remaining problems (aside of the bugs > introduced in it, of course): > * TIOCSERGSTRUCT must die; it's present only in

Re: [PATCHES] tty ioctls cleanups, compat and not only

2018-09-13 Thread Arnd Bergmann
On Thu, Sep 13, 2018 at 4:31 AM Al Viro wrote: > > See vfs.git#work.tty-ioctl. Completely untested, should seriously > clean the things up wrt compat. Remaining problems (aside of the bugs > introduced in it, of course): > * TIOCSERGSTRUCT must die; it's present only in

[PATCHES] tty ioctls cleanups, compat and not only

2018-09-12 Thread Al Viro
See vfs.git#work.tty-ioctl. Completely untested, should seriously clean the things up wrt compat. Remaining problems (aside of the bugs introduced in it, of course): * TIOCSERGSTRUCT must die; it's present only in amiserial and it's _vile_; look at what it copies out and weep.

[PATCHES] tty ioctls cleanups, compat and not only

2018-09-12 Thread Al Viro
See vfs.git#work.tty-ioctl. Completely untested, should seriously clean the things up wrt compat. Remaining problems (aside of the bugs introduced in it, of course): * TIOCSERGSTRUCT must die; it's present only in amiserial and it's _vile_; look at what it copies out and weep.