Re: [PATCHSET 0/2] perf hists browser: Cleanup callchain routines (v2)
* Jiri Olsa wrote: > On Thu, Aug 21, 2014 at 10:15:44AM +0900, Namhyung Kim wrote: > > Hello, > > > > This patch fixes and cleans up TUI callchain routines. I tried to > > consolidate similar functions but not to break the current output with > > this change. Hope that it makes code more readable and maintainable. > > 76 insertions(+), 134 deletions(-) ... nice! ;-) > > Acked-by: Jiri Olsa Indeed, very nice! Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCHSET 0/2] perf hists browser: Cleanup callchain routines (v2)
* Jiri Olsa jo...@redhat.com wrote: On Thu, Aug 21, 2014 at 10:15:44AM +0900, Namhyung Kim wrote: Hello, This patch fixes and cleans up TUI callchain routines. I tried to consolidate similar functions but not to break the current output with this change. Hope that it makes code more readable and maintainable. 76 insertions(+), 134 deletions(-) ... nice! ;-) Acked-by: Jiri Olsa jo...@kernel.org Indeed, very nice! Ingo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCHSET 0/2] perf hists browser: Cleanup callchain routines (v2)
Em Thu, Aug 21, 2014 at 10:11:17AM +0200, Jiri Olsa escreveu: > On Thu, Aug 21, 2014 at 10:15:44AM +0900, Namhyung Kim wrote: > > Hello, > > > > This patch fixes and cleans up TUI callchain routines. I tried to > > consolidate similar functions but not to break the current output with > > this change. Hope that it makes code more readable and maintainable. > > 76 insertions(+), 134 deletions(-) ... nice! ;-) > > Acked-by: Jiri Olsa indeed :-) - Arnaldo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCHSET 0/2] perf hists browser: Cleanup callchain routines (v2)
On Thu, Aug 21, 2014 at 10:15:44AM +0900, Namhyung Kim wrote: > Hello, > > This patch fixes and cleans up TUI callchain routines. I tried to > consolidate similar functions but not to break the current output with > this change. Hope that it makes code more readable and maintainable. 76 insertions(+), 134 deletions(-) ... nice! ;-) Acked-by: Jiri Olsa jirka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCHSET 0/2] perf hists browser: Cleanup callchain routines (v2)
On Thu, Aug 21, 2014 at 10:15:44AM +0900, Namhyung Kim wrote: Hello, This patch fixes and cleans up TUI callchain routines. I tried to consolidate similar functions but not to break the current output with this change. Hope that it makes code more readable and maintainable. 76 insertions(+), 134 deletions(-) ... nice! ;-) Acked-by: Jiri Olsa jo...@kernel.org jirka -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCHSET 0/2] perf hists browser: Cleanup callchain routines (v2)
Em Thu, Aug 21, 2014 at 10:11:17AM +0200, Jiri Olsa escreveu: On Thu, Aug 21, 2014 at 10:15:44AM +0900, Namhyung Kim wrote: Hello, This patch fixes and cleans up TUI callchain routines. I tried to consolidate similar functions but not to break the current output with this change. Hope that it makes code more readable and maintainable. 76 insertions(+), 134 deletions(-) ... nice! ;-) Acked-by: Jiri Olsa jo...@kernel.org indeed :-) - Arnaldo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCHSET 0/2] perf hists browser: Cleanup callchain routines (v2)
Hello, This patch fixes and cleans up TUI callchain routines. I tried to consolidate similar functions but not to break the current output with this change. Hope that it makes code more readable and maintainable. It should not change any behavior and outputs. I verified it with expanding by 'E' key + dumping by 'P' key on TUI and then running "diff -u" results before and after the patchset. Actually I have more changes that would change (or improve) some behavior and output. I'll post them after this patchset is merged. * changes in v2) - drop patch 1-3 in v1 since it's already merged - update description (Arnaldo) - remove stylish changes (Arnaldo) - remove unnecessary 'has_single_node' check You can get this from 'perf/callchain-fix-v2' branch on my tree: git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git Any comments are welcome, thanks Namhyung Namhyung Kim (2): perf hists browser: Cleanup callchain print functions perf hists browser: Consolidate callchain print functions in TUI tools/perf/ui/browsers/hists.c | 302 + 1 file changed, 95 insertions(+), 207 deletions(-) -- 2.0.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCHSET 0/2] perf hists browser: Cleanup callchain routines (v2)
Hello, This patch fixes and cleans up TUI callchain routines. I tried to consolidate similar functions but not to break the current output with this change. Hope that it makes code more readable and maintainable. It should not change any behavior and outputs. I verified it with expanding by 'E' key + dumping by 'P' key on TUI and then running diff -u results before and after the patchset. Actually I have more changes that would change (or improve) some behavior and output. I'll post them after this patchset is merged. * changes in v2) - drop patch 1-3 in v1 since it's already merged - update description (Arnaldo) - remove stylish changes (Arnaldo) - remove unnecessary 'has_single_node' check You can get this from 'perf/callchain-fix-v2' branch on my tree: git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git Any comments are welcome, thanks Namhyung Namhyung Kim (2): perf hists browser: Cleanup callchain print functions perf hists browser: Consolidate callchain print functions in TUI tools/perf/ui/browsers/hists.c | 302 + 1 file changed, 95 insertions(+), 207 deletions(-) -- 2.0.0 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
