Re: [PATCHSET for-4.13] cgroup: implement cgroup2 thread mode, v2

2017-07-12 Thread Waiman Long
On 07/12/2017 03:45 AM, Peter Zijlstra wrote: > On Tue, Jul 11, 2017 at 05:12:39PM -0400, Waiman Long wrote: >> On 07/11/2017 12:52 PM, Peter Zijlstra wrote: >>> On Tue, Jul 11, 2017 at 10:14:42AM -0400, Waiman Long wrote: >>> The "join" was a special op for the children of cgroup root to

Re: [PATCHSET for-4.13] cgroup: implement cgroup2 thread mode, v2

2017-07-12 Thread Waiman Long
On 07/12/2017 03:45 AM, Peter Zijlstra wrote: > On Tue, Jul 11, 2017 at 05:12:39PM -0400, Waiman Long wrote: >> On 07/11/2017 12:52 PM, Peter Zijlstra wrote: >>> On Tue, Jul 11, 2017 at 10:14:42AM -0400, Waiman Long wrote: >>> The "join" was a special op for the children of cgroup root to

Re: [PATCHSET for-4.13] cgroup: implement cgroup2 thread mode, v2

2017-07-12 Thread Peter Zijlstra
On Tue, Jul 11, 2017 at 05:12:39PM -0400, Waiman Long wrote: > On 07/11/2017 12:52 PM, Peter Zijlstra wrote: > > On Tue, Jul 11, 2017 at 10:14:42AM -0400, Waiman Long wrote: > > > >> The "join" was a special op for the children of cgroup root to join the > >> root as part of a threaded subtree.

Re: [PATCHSET for-4.13] cgroup: implement cgroup2 thread mode, v2

2017-07-12 Thread Peter Zijlstra
On Tue, Jul 11, 2017 at 05:12:39PM -0400, Waiman Long wrote: > On 07/11/2017 12:52 PM, Peter Zijlstra wrote: > > On Tue, Jul 11, 2017 at 10:14:42AM -0400, Waiman Long wrote: > > > >> The "join" was a special op for the children of cgroup root to join the > >> root as part of a threaded subtree.

Re: [PATCHSET for-4.13] cgroup: implement cgroup2 thread mode, v2

2017-07-11 Thread Waiman Long
On 07/11/2017 12:52 PM, Peter Zijlstra wrote: > On Tue, Jul 11, 2017 at 10:14:42AM -0400, Waiman Long wrote: > >> The "join" was a special op for the children of cgroup root to join the >> root as part of a threaded subtree. The children can instead use the >> "enable" option to become a thread

Re: [PATCHSET for-4.13] cgroup: implement cgroup2 thread mode, v2

2017-07-11 Thread Waiman Long
On 07/11/2017 12:52 PM, Peter Zijlstra wrote: > On Tue, Jul 11, 2017 at 10:14:42AM -0400, Waiman Long wrote: > >> The "join" was a special op for the children of cgroup root to join the >> root as part of a threaded subtree. The children can instead use the >> "enable" option to become a thread

Re: [PATCHSET for-4.13] cgroup: implement cgroup2 thread mode, v2

2017-07-11 Thread Peter Zijlstra
On Tue, Jul 11, 2017 at 10:14:42AM -0400, Waiman Long wrote: > The "join" was a special op for the children of cgroup root to join the > root as part of a threaded subtree. The children can instead use the > "enable" option to become a thread root which was the configuration > shown above. This

Re: [PATCHSET for-4.13] cgroup: implement cgroup2 thread mode, v2

2017-07-11 Thread Peter Zijlstra
On Tue, Jul 11, 2017 at 10:14:42AM -0400, Waiman Long wrote: > The "join" was a special op for the children of cgroup root to join the > root as part of a threaded subtree. The children can instead use the > "enable" option to become a thread root which was the configuration > shown above. This

Re: [PATCHSET for-4.13] cgroup: implement cgroup2 thread mode, v2

2017-07-11 Thread Waiman Long
On 07/11/2017 08:15 AM, Peter Zijlstra wrote: > On Mon, Jul 10, 2017 at 05:01:19PM -0400, Waiman Long wrote: >> On 07/10/2017 04:32 AM, Peter Zijlstra wrote: >>> On Fri, Jun 30, 2017 at 09:23:24AM -0400, Tejun Heo wrote: On Tue, Jun 27, 2017 at 09:01:43AM +0200, Peter Zijlstra wrote: > On

Re: [PATCHSET for-4.13] cgroup: implement cgroup2 thread mode, v2

2017-07-11 Thread Waiman Long
On 07/11/2017 08:15 AM, Peter Zijlstra wrote: > On Mon, Jul 10, 2017 at 05:01:19PM -0400, Waiman Long wrote: >> On 07/10/2017 04:32 AM, Peter Zijlstra wrote: >>> On Fri, Jun 30, 2017 at 09:23:24AM -0400, Tejun Heo wrote: On Tue, Jun 27, 2017 at 09:01:43AM +0200, Peter Zijlstra wrote: > On

Re: [PATCHSET for-4.13] cgroup: implement cgroup2 thread mode, v2

2017-07-11 Thread Peter Zijlstra
On Mon, Jul 10, 2017 at 05:01:19PM -0400, Waiman Long wrote: > On 07/10/2017 04:32 AM, Peter Zijlstra wrote: > > On Fri, Jun 30, 2017 at 09:23:24AM -0400, Tejun Heo wrote: > >> On Tue, Jun 27, 2017 at 09:01:43AM +0200, Peter Zijlstra wrote: > >>> On Mon, Jun 12, 2017 at 05:27:53PM -0400, Tejun Heo

Re: [PATCHSET for-4.13] cgroup: implement cgroup2 thread mode, v2

2017-07-11 Thread Peter Zijlstra
On Mon, Jul 10, 2017 at 05:01:19PM -0400, Waiman Long wrote: > On 07/10/2017 04:32 AM, Peter Zijlstra wrote: > > On Fri, Jun 30, 2017 at 09:23:24AM -0400, Tejun Heo wrote: > >> On Tue, Jun 27, 2017 at 09:01:43AM +0200, Peter Zijlstra wrote: > >>> On Mon, Jun 12, 2017 at 05:27:53PM -0400, Tejun Heo

Re: [PATCHSET for-4.13] cgroup: implement cgroup2 thread mode, v2

2017-07-10 Thread Waiman Long
On 07/10/2017 04:32 AM, Peter Zijlstra wrote: > On Fri, Jun 30, 2017 at 09:23:24AM -0400, Tejun Heo wrote: >> On Tue, Jun 27, 2017 at 09:01:43AM +0200, Peter Zijlstra wrote: >>> On Mon, Jun 12, 2017 at 05:27:53PM -0400, Tejun Heo wrote: >>> IIRC the problem with the 'threaded' marker is that it

Re: [PATCHSET for-4.13] cgroup: implement cgroup2 thread mode, v2

2017-07-10 Thread Waiman Long
On 07/10/2017 04:32 AM, Peter Zijlstra wrote: > On Fri, Jun 30, 2017 at 09:23:24AM -0400, Tejun Heo wrote: >> On Tue, Jun 27, 2017 at 09:01:43AM +0200, Peter Zijlstra wrote: >>> On Mon, Jun 12, 2017 at 05:27:53PM -0400, Tejun Heo wrote: >>> IIRC the problem with the 'threaded' marker is that it

Re: [PATCHSET for-4.13] cgroup: implement cgroup2 thread mode, v2

2017-07-10 Thread Peter Zijlstra
On Fri, Jun 30, 2017 at 09:23:24AM -0400, Tejun Heo wrote: > On Tue, Jun 27, 2017 at 09:01:43AM +0200, Peter Zijlstra wrote: > > On Mon, Jun 12, 2017 at 05:27:53PM -0400, Tejun Heo wrote: > > IIRC the problem with the 'threaded' marker is that it doesn't clearly > > capture what a resource domain

Re: [PATCHSET for-4.13] cgroup: implement cgroup2 thread mode, v2

2017-07-10 Thread Peter Zijlstra
On Fri, Jun 30, 2017 at 09:23:24AM -0400, Tejun Heo wrote: > On Tue, Jun 27, 2017 at 09:01:43AM +0200, Peter Zijlstra wrote: > > On Mon, Jun 12, 2017 at 05:27:53PM -0400, Tejun Heo wrote: > > IIRC the problem with the 'threaded' marker is that it doesn't clearly > > capture what a resource domain

Re: [PATCHSET for-4.13] cgroup: implement cgroup2 thread mode, v2

2017-06-30 Thread Tejun Heo
Hello, Peter. On Tue, Jun 27, 2017 at 09:01:43AM +0200, Peter Zijlstra wrote: > > I'm slowly getting back to things... Welcome back. > On Mon, Jun 12, 2017 at 05:27:53PM -0400, Tejun Heo wrote: > > That's where the "join" thing comes from because we wanna be able to > > tell apart whether a

Re: [PATCHSET for-4.13] cgroup: implement cgroup2 thread mode, v2

2017-06-30 Thread Tejun Heo
Hello, Peter. On Tue, Jun 27, 2017 at 09:01:43AM +0200, Peter Zijlstra wrote: > > I'm slowly getting back to things... Welcome back. > On Mon, Jun 12, 2017 at 05:27:53PM -0400, Tejun Heo wrote: > > That's where the "join" thing comes from because we wanna be able to > > tell apart whether a

Re: [PATCHSET for-4.13] cgroup: implement cgroup2 thread mode, v2

2017-06-27 Thread Peter Zijlstra
I'm slowly getting back to things... On Mon, Jun 12, 2017 at 05:27:53PM -0400, Tejun Heo wrote: > > > * Root cgroup can enable thread mode anytime and a first level child > > > can opt-in to that thread subtree anchored at root by writing "join" > > > to "cgroup.threads" files, start its

Re: [PATCHSET for-4.13] cgroup: implement cgroup2 thread mode, v2

2017-06-27 Thread Peter Zijlstra
I'm slowly getting back to things... On Mon, Jun 12, 2017 at 05:27:53PM -0400, Tejun Heo wrote: > > > * Root cgroup can enable thread mode anytime and a first level child > > > can opt-in to that thread subtree anchored at root by writing "join" > > > to "cgroup.threads" files, start its

Re: [PATCHSET for-4.13] cgroup: implement cgroup2 thread mode, v2

2017-06-15 Thread Tejun Heo
Hello, On Mon, Jun 12, 2017 at 05:27:53PM -0400, Tejun Heo wrote: > The previous iteration actually was that way, so the only thread mode > operation was setting whether to enable thread or not as before and if > the parent is already thread mode, it'd always join the existing > threaded subtree.

Re: [PATCHSET for-4.13] cgroup: implement cgroup2 thread mode, v2

2017-06-15 Thread Tejun Heo
Hello, On Mon, Jun 12, 2017 at 05:27:53PM -0400, Tejun Heo wrote: > The previous iteration actually was that way, so the only thread mode > operation was setting whether to enable thread or not as before and if > the parent is already thread mode, it'd always join the existing > threaded subtree.

Re: [PATCHSET for-4.13] cgroup: implement cgroup2 thread mode, v2

2017-06-12 Thread Tejun Heo
Hello, Peter. On Mon, Jun 12, 2017 at 02:31:50PM +0200, Peter Zijlstra wrote: > Please don't rush this; also, I might not be around much the coming > weeks due to taking some leave 'soon' (kid #3 is imminent). Congrats. As for this going forward, how can we possibly be slower? > And I really

Re: [PATCHSET for-4.13] cgroup: implement cgroup2 thread mode, v2

2017-06-12 Thread Tejun Heo
Hello, Peter. On Mon, Jun 12, 2017 at 02:31:50PM +0200, Peter Zijlstra wrote: > Please don't rush this; also, I might not be around much the coming > weeks due to taking some leave 'soon' (kid #3 is imminent). Congrats. As for this going forward, how can we possibly be slower? > And I really

Re: [PATCHSET for-4.13] cgroup: implement cgroup2 thread mode, v2

2017-06-12 Thread Peter Zijlstra
Please don't rush this; also, I might not be around much the coming weeks due to taking some leave 'soon' (kid #3 is imminent). And I really need more time to look at this (and re-read the old discussions, because I've forgot most everything again). On Sat, Jun 10, 2017 at 10:03:41AM -0400,

Re: [PATCHSET for-4.13] cgroup: implement cgroup2 thread mode, v2

2017-06-12 Thread Peter Zijlstra
Please don't rush this; also, I might not be around much the coming weeks due to taking some leave 'soon' (kid #3 is imminent). And I really need more time to look at this (and re-read the old discussions, because I've forgot most everything again). On Sat, Jun 10, 2017 at 10:03:41AM -0400,

[PATCHSET for-4.13] cgroup: implement cgroup2 thread mode, v2

2017-06-10 Thread Tejun Heo
Hello, This is v2 of cgroup2 thread mode patchset. The changes from the last take[L] are * Support for mixed thread mode for the root cgroup added. This allows the root cgroup to serve as both a thread root and a parent to domain cgroups. This allows users to use thread mode without any

[PATCHSET for-4.13] cgroup: implement cgroup2 thread mode, v2

2017-06-10 Thread Tejun Heo
Hello, This is v2 of cgroup2 thread mode patchset. The changes from the last take[L] are * Support for mixed thread mode for the root cgroup added. This allows the root cgroup to serve as both a thread root and a parent to domain cgroups. This allows users to use thread mode without any