Re: [PATCHv1 1/3] arm64: dts: meson: odroid-c2: Add missing regulator linked to P5V0 regulator
Hi Anand, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [cannot apply to v5.3-rc7 next-20190902] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Anand-Moon/arm64-dts-meson-odroid-c2-Add-missing-regulator-linked-to-P5V0-regulator/20190901-025920 config: arm64-defconfig (attached as .config) compiler: aarch64-linux-gcc (GCC) 7.4.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=7.4.0 make.cross ARCH=arm64 If you fix the issue, kindly add following tag Reported-by: kbuild test robot All errors (new ones prefixed by >>): >> ERROR: Input tree has errors, aborting (use -f to force output) --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCHv1 1/3] arm64: dts: meson: odroid-c2: Add missing regulator linked to P5V0 regulator
Hi Martin, On Mon, 2 Sep 2019 at 03:23, Martin Blumenstingl wrote: > > Hi Anand, > > On Sun, Sep 1, 2019 at 3:58 PM Anand Moon wrote: > > > > Hi Martin, > > > > Thanks for your review comments. > > > > Their have been some revision changes in S905 Odroid Schematics. > > [0] https://dn.odroid.com/S905/Schematic/ > > > > Well I have make my changes based on old odroid-c2_rev0.2_20151218.pdf > > [...] > > > > > > according to the schematics there's both: > > > - VDDIO_AO3V3 > > > - VCC3V3 (which is turned on by VDDIO_AO3V3, see [0]) > > > > > > > From the schematics it seams same. > > > > VDDIO_AO3V3---DMG340LSQN4 (Q4)---VCC3V3 > yes, they are the same signal. the only difference is that VCC3V3 is > turned on later in the power-up sequence > > > But this name change was done to link TFLASH_VDD_EN to TFLASH_VDD for eMMC > > > > VDDIO_AO3V3-TFLASH_VDD using TFLASH_VDD_EN gpio pin. > > > > Well I have tested this changes on eMMC module. > I cannot see any of the TFLASH_* regulators being linked to eMMC (they > are only linked to the SD card slot, I also checked > odroid-c2_rev0.2_20151218.pdf and odroid-c2_rev0.2_20171114.pdf). > which page of the odroid-c2_rev0.2_20151218.pdf schematics shows how > TFLASH_VDD is linked to eMMC? > > please note that I don't have an Odroid-C2 board myself (so I cannot > test any of this). > > > Martin Thanks I will double check again and re-post then with correction again. Best Regards -Anand
Re: [PATCHv1 1/3] arm64: dts: meson: odroid-c2: Add missing regulator linked to P5V0 regulator
Hi Anand, On Sun, Sep 1, 2019 at 3:58 PM Anand Moon wrote: > > Hi Martin, > > Thanks for your review comments. > > Their have been some revision changes in S905 Odroid Schematics. > [0] https://dn.odroid.com/S905/Schematic/ > > Well I have make my changes based on old odroid-c2_rev0.2_20151218.pdf [...] > > > > according to the schematics there's both: > > - VDDIO_AO3V3 > > - VCC3V3 (which is turned on by VDDIO_AO3V3, see [0]) > > > > From the schematics it seams same. > > VDDIO_AO3V3---DMG340LSQN4 (Q4)---VCC3V3 yes, they are the same signal. the only difference is that VCC3V3 is turned on later in the power-up sequence > But this name change was done to link TFLASH_VDD_EN to TFLASH_VDD for eMMC > > VDDIO_AO3V3-TFLASH_VDD using TFLASH_VDD_EN gpio pin. > > Well I have tested this changes on eMMC module. I cannot see any of the TFLASH_* regulators being linked to eMMC (they are only linked to the SD card slot, I also checked odroid-c2_rev0.2_20151218.pdf and odroid-c2_rev0.2_20171114.pdf). which page of the odroid-c2_rev0.2_20151218.pdf schematics shows how TFLASH_VDD is linked to eMMC? please note that I don't have an Odroid-C2 board myself (so I cannot test any of this). Martin
Re: [PATCHv1 1/3] arm64: dts: meson: odroid-c2: Add missing regulator linked to P5V0 regulator
Hi Martin,
Thanks for your review comments.
Their have been some revision changes in S905 Odroid Schematics.
[0] https://dn.odroid.com/S905/Schematic/
Well I have make my changes based on old odroid-c2_rev0.2_20151218.pdf
On Sun, 1 Sep 2019 at 17:07, Martin Blumenstingl
wrote:
>
> On Wed, Aug 28, 2019 at 10:27 PM Anand Moon wrote:
> >
> > As per shematics VDDIO_AO18, VDDIO_AO3V3/VDD3V3 DDR3_1V5/DDR_VDDC:
> typo: "schematics"
>
OK. next time will run spell check before I send these changes.
> > fixed regulator output which is supplied by P5V0.
> >
> > Rename vcc3v3 regulator node to vddio_ao3v3 as per shematics.
> typo: "schematics"
Ok.
>
> according to the schematics there's both:
> - VDDIO_AO3V3
> - VCC3V3 (which is turned on by VDDIO_AO3V3, see [0])
>
>From the schematics it seams same.
VDDIO_AO3V3---DMG340LSQN4 (Q4)---VCC3V3
But this name change was done to link TFLASH_VDD_EN to TFLASH_VDD for eMMC
VDDIO_AO3V3-TFLASH_VDD using TFLASH_VDD_EN gpio pin.
Well I have tested this changes on eMMC module.
> > Cc: Martin Blumenstingl
> > Cc: Jerome Brunet
> > Cc: Neil Armstrong
> > Signed-off-by: Anand Moon
> > ---
> > .../boot/dts/amlogic/meson-gxbb-odroidc2.dts | 29 +--
> > 1 file changed, 26 insertions(+), 3 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
> > b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
> > index 792698a60a12..98e742bf44c1 100644
> > --- a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
> > +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
> > @@ -104,11 +104,34 @@
> > regulator-max-microvolt = <180>;
> > };
> >
> > - vcc3v3: regulator-vcc3v3 {
> > + vddio_ao1v8: regulator-vddio-ao1v8 {
> > compatible = "regulator-fixed";
> > - regulator-name = "VCC3V3";
> > + regulator-name = "VDDIO_AO1V8";
> > + regulator-min-microvolt = <180>;
> > + regulator-max-microvolt = <180>;
> > + regulator-always-on;
> > + /* U17 RT9179GB */
> > + vin-supply = <>;
> > + };
> > +
> > + vddio_ao3v3: regulator-vddio-ao3v3 {
> > + compatible = "regulator-fixed";
> > + regulator-name = "VDDIO_AO3V3";
> > regulator-min-microvolt = <330>;
> > regulator-max-microvolt = <330>;
> > + regulator-always-on;
> > + /* U11 MP2161GJ-C499 */
> > + vin-supply = <>;
> > + };
> > +
> > + vddc_ddr: regulator-vddc-ddr {
> > + compatible = "regulator-fixed";
> > + regulator-name = "DDR_VDDC";
> personally I would call this (along with the node name and alias) DDR3_1V5
> odroid-c2_rev0.1_20150930.pdf shows that DDR3_1V5 and DDR_VDDC are
> both the same. however, the DDR_VDDC signal name is not used by any
> component in the datasheet
Ok Thanks I will change this to DDR3_1V5 as per the datasheet.
>
> > + regulator-min-microvolt = <150>;
> > + regulator-max-microvolt = <150>;
> > + regulator-always-on;
> > + /* U15 MP2161GJ-C499 */
> > + vin-supply = <>;
> > };
> >
> > emmc_pwrseq: emmc-pwrseq {
> > @@ -301,7 +324,7 @@
> > mmc-hs200-1_8v;
> >
> > mmc-pwrseq = <_pwrseq>;
> > - vmmc-supply = <>;
> > + vmmc-supply = <_ao3v3>;
> odroid-c2_rev0.1_20150930.pdf uses VCC3V3 as supply
>
>
> Martin
Best Regards
-Anand
Re: [PATCHv1 1/3] arm64: dts: meson: odroid-c2: Add missing regulator linked to P5V0 regulator
On Wed, Aug 28, 2019 at 10:27 PM Anand Moon wrote:
>
> As per shematics VDDIO_AO18, VDDIO_AO3V3/VDD3V3 DDR3_1V5/DDR_VDDC:
typo: "schematics"
> fixed regulator output which is supplied by P5V0.
>
> Rename vcc3v3 regulator node to vddio_ao3v3 as per shematics.
typo: "schematics"
according to the schematics there's both:
- VDDIO_AO3V3
- VCC3V3 (which is turned on by VDDIO_AO3V3, see [0])
> Cc: Martin Blumenstingl
> Cc: Jerome Brunet
> Cc: Neil Armstrong
> Signed-off-by: Anand Moon
> ---
> .../boot/dts/amlogic/meson-gxbb-odroidc2.dts | 29 +--
> 1 file changed, 26 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
> b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
> index 792698a60a12..98e742bf44c1 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
> @@ -104,11 +104,34 @@
> regulator-max-microvolt = <180>;
> };
>
> - vcc3v3: regulator-vcc3v3 {
> + vddio_ao1v8: regulator-vddio-ao1v8 {
> compatible = "regulator-fixed";
> - regulator-name = "VCC3V3";
> + regulator-name = "VDDIO_AO1V8";
> + regulator-min-microvolt = <180>;
> + regulator-max-microvolt = <180>;
> + regulator-always-on;
> + /* U17 RT9179GB */
> + vin-supply = <>;
> + };
> +
> + vddio_ao3v3: regulator-vddio-ao3v3 {
> + compatible = "regulator-fixed";
> + regulator-name = "VDDIO_AO3V3";
> regulator-min-microvolt = <330>;
> regulator-max-microvolt = <330>;
> + regulator-always-on;
> + /* U11 MP2161GJ-C499 */
> + vin-supply = <>;
> + };
> +
> + vddc_ddr: regulator-vddc-ddr {
> + compatible = "regulator-fixed";
> + regulator-name = "DDR_VDDC";
personally I would call this (along with the node name and alias) DDR3_1V5
odroid-c2_rev0.1_20150930.pdf shows that DDR3_1V5 and DDR_VDDC are
both the same. however, the DDR_VDDC signal name is not used by any
component in the datasheet
> + regulator-min-microvolt = <150>;
> + regulator-max-microvolt = <150>;
> + regulator-always-on;
> + /* U15 MP2161GJ-C499 */
> + vin-supply = <>;
> };
>
> emmc_pwrseq: emmc-pwrseq {
> @@ -301,7 +324,7 @@
> mmc-hs200-1_8v;
>
> mmc-pwrseq = <_pwrseq>;
> - vmmc-supply = <>;
> + vmmc-supply = <_ao3v3>;
odroid-c2_rev0.1_20150930.pdf uses VCC3V3 as supply
Martin
[PATCHv1 1/3] arm64: dts: meson: odroid-c2: Add missing regulator linked to P5V0 regulator
As per shematics VDDIO_AO18, VDDIO_AO3V3/VDD3V3 DDR3_1V5/DDR_VDDC:
fixed regulator output which is supplied by P5V0.
Rename vcc3v3 regulator node to vddio_ao3v3 as per shematics.
Cc: Martin Blumenstingl
Cc: Jerome Brunet
Cc: Neil Armstrong
Signed-off-by: Anand Moon
---
.../boot/dts/amlogic/meson-gxbb-odroidc2.dts | 29 +--
1 file changed, 26 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
index 792698a60a12..98e742bf44c1 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
@@ -104,11 +104,34 @@
regulator-max-microvolt = <180>;
};
- vcc3v3: regulator-vcc3v3 {
+ vddio_ao1v8: regulator-vddio-ao1v8 {
compatible = "regulator-fixed";
- regulator-name = "VCC3V3";
+ regulator-name = "VDDIO_AO1V8";
+ regulator-min-microvolt = <180>;
+ regulator-max-microvolt = <180>;
+ regulator-always-on;
+ /* U17 RT9179GB */
+ vin-supply = <>;
+ };
+
+ vddio_ao3v3: regulator-vddio-ao3v3 {
+ compatible = "regulator-fixed";
+ regulator-name = "VDDIO_AO3V3";
regulator-min-microvolt = <330>;
regulator-max-microvolt = <330>;
+ regulator-always-on;
+ /* U11 MP2161GJ-C499 */
+ vin-supply = <>;
+ };
+
+ vddc_ddr: regulator-vddc-ddr {
+ compatible = "regulator-fixed";
+ regulator-name = "DDR_VDDC";
+ regulator-min-microvolt = <150>;
+ regulator-max-microvolt = <150>;
+ regulator-always-on;
+ /* U15 MP2161GJ-C499 */
+ vin-supply = <>;
};
emmc_pwrseq: emmc-pwrseq {
@@ -301,7 +324,7 @@
mmc-hs200-1_8v;
mmc-pwrseq = <_pwrseq>;
- vmmc-supply = <>;
+ vmmc-supply = <_ao3v3>;
vqmmc-supply = <>;
};
--
2.23.0
