Re: [PATCHv2] ide: Use NULL to compare with pointer-typed value rather than 0

2018-08-18 Thread Joe Perches
On Sat, 2018-08-18 at 19:21 +0300, Sergei Shtylyov wrote: > On 08/18/2018 07:15 PM, Joe Perches wrote: > > > > We should use NULL to compare with pointer-typed value rather than > > > > 0. The issue is detected with the help of Coccinelle. > > > > > >Your description stopped to match the

Re: [PATCHv2] ide: Use NULL to compare with pointer-typed value rather than 0

2018-08-18 Thread Sergei Shtylyov
On 08/18/2018 06:53 PM, Sergei Shtylyov wrote: >> We should use NULL to compare with pointer-typed value rather than >> 0. The issue is detected with the help of Coccinelle. > >Your description stopped to match the patch in v2. And your subject as well... >Actually, this X == NULL

Re: [PATCHv2] ide: Use NULL to compare with pointer-typed value rather than 0

2018-08-18 Thread Sergei Shtylyov
On 08/18/2018 07:15 PM, Joe Perches wrote: >>> We should use NULL to compare with pointer-typed value rather than >>> 0. The issue is detected with the help of Coccinelle. >> >>Your description stopped to match the patch in v2. >>Actually, this X == NULL to !x preference is largely

Re: [PATCHv2] ide: Use NULL to compare with pointer-typed value rather than 0

2018-08-18 Thread Joe Perches
On Sat, 2018-08-18 at 18:53 +0300, Sergei Shtylyov wrote: > On 08/18/2018 09:16 AM, zhong jiang wrote: > > > We should use NULL to compare with pointer-typed value rather than > > 0. The issue is detected with the help of Coccinelle. > >Your description stopped to match the patch in v2. >

Re: [PATCHv2] ide: Use NULL to compare with pointer-typed value rather than 0

2018-08-18 Thread Sergei Shtylyov
On 08/18/2018 09:16 AM, zhong jiang wrote: > We should use NULL to compare with pointer-typed value rather than > 0. The issue is detected with the help of Coccinelle. Your description stopped to match the patch in v2. Actually, this X == NULL to !x preference is largely spocific to

[PATCHv2] ide: Use NULL to compare with pointer-typed value rather than 0

2018-08-18 Thread zhong jiang
We should use NULL to compare with pointer-typed value rather than 0. The issue is detected with the help of Coccinelle. Signed-off-by: zhong jiang --- drivers/ide/pmac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ide/pmac.c b/drivers/ide/pmac.c index