On Mon, 2014-08-04 at 13:40 +0300, Dan Carpenter wrote:
> On Mon, Aug 04, 2014 at 12:17:14PM +0200, Martin Kepplinger wrote:
[]
> > + if (dev) {
> > + dev_dbg(>bus_adap.usb_dev->dev,
> > + "tuner parameters: freq: %d bw: 0x%02x gi: 0x%02x\n",
> > +
On thinking about it some more the proper way to redo this would have
been to remove the bogus check. Also a couple trivial things below.
On Mon, Aug 04, 2014 at 12:17:14PM +0200, Martin Kepplinger wrote:
> @@ -82,10 +83,17 @@ static int as102_fe_get_tune_settings(struct dvb_frontend
> *fe,
>
remove dprintk() and replace it with dev_dbg() in order to
use the common kernel coding style.
Signed-off-by: Martin Kepplinger
---
Thanks Dan. And since it continues to succeed if (dev == NULL),
differntiate if (dev) or not.
drivers/staging/media/as102/as102_drv.c | 15 +++---
remove dprintk() and replace it with dev_dbg() in order to
use the common kernel coding style.
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
Thanks Dan. And since it continues to succeed if (dev == NULL),
differntiate if (dev) or not.
drivers/staging/media/as102/as102_drv.c | 15
On thinking about it some more the proper way to redo this would have
been to remove the bogus check. Also a couple trivial things below.
On Mon, Aug 04, 2014 at 12:17:14PM +0200, Martin Kepplinger wrote:
@@ -82,10 +83,17 @@ static int as102_fe_get_tune_settings(struct dvb_frontend
*fe,
On Mon, 2014-08-04 at 13:40 +0300, Dan Carpenter wrote:
On Mon, Aug 04, 2014 at 12:17:14PM +0200, Martin Kepplinger wrote:
[]
+ if (dev) {
+ dev_dbg(dev-bus_adap.usb_dev-dev,
+ tuner parameters: freq: %d bw: 0x%02x gi: 0x%02x\n,
+
On Sat, May 17, 2014 at 08:21:03PM +0300, Antti Palosaari wrote:
> On 05/17/2014 07:05 PM, Martin Kepplinger wrote:
> >don't reinvent dev_dbg(). remove dprintk() in as102_drv.c.
> >use the common kernel coding style.
> >
> >Signed-off-by: Martin Kepplinger
>
> Reviewed-by: Antti Palosaari
>
>
Il 17/05/2014 19:52, Martin Kepplinger ha scritto:
> Am 2014-05-17 19:21, schrieb Antti Palosaari:
>> On 05/17/2014 07:05 PM, Martin Kepplinger wrote:
>>> don't reinvent dev_dbg(). remove dprintk() in as102_drv.c.
>>> use the common kernel coding style.
>>>
>>> Signed-off-by: Martin Kepplinger
>>
Am 2014-05-17 19:21, schrieb Antti Palosaari:
> On 05/17/2014 07:05 PM, Martin Kepplinger wrote:
>> don't reinvent dev_dbg(). remove dprintk() in as102_drv.c.
>> use the common kernel coding style.
>>
>> Signed-off-by: Martin Kepplinger
>
> Reviewed-by: Antti Palosaari
>
>> ---
>> this applies
On 05/17/2014 07:05 PM, Martin Kepplinger wrote:
don't reinvent dev_dbg(). remove dprintk() in as102_drv.c.
use the common kernel coding style.
Signed-off-by: Martin Kepplinger
Reviewed-by: Antti Palosaari
---
this applies to next-20140516. any more suggestions?
more cleanup can be done
don't reinvent dev_dbg(). remove dprintk() in as102_drv.c.
use the common kernel coding style.
Signed-off-by: Martin Kepplinger
---
this applies to next-20140516. any more suggestions?
more cleanup can be done when dprintk() is completely gone.
drivers/staging/media/as102/as102_drv.c | 15
don't reinvent dev_dbg(). remove dprintk() in as102_drv.c.
use the common kernel coding style.
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
this applies to next-20140516. any more suggestions?
more cleanup can be done when dprintk() is completely gone.
On 05/17/2014 07:05 PM, Martin Kepplinger wrote:
don't reinvent dev_dbg(). remove dprintk() in as102_drv.c.
use the common kernel coding style.
Signed-off-by: Martin Kepplinger mart...@posteo.de
Reviewed-by: Antti Palosaari cr...@iki.fi
---
this applies to next-20140516. any more
Am 2014-05-17 19:21, schrieb Antti Palosaari:
On 05/17/2014 07:05 PM, Martin Kepplinger wrote:
don't reinvent dev_dbg(). remove dprintk() in as102_drv.c.
use the common kernel coding style.
Signed-off-by: Martin Kepplinger mart...@posteo.de
Reviewed-by: Antti Palosaari cr...@iki.fi
---
Il 17/05/2014 19:52, Martin Kepplinger ha scritto:
Am 2014-05-17 19:21, schrieb Antti Palosaari:
On 05/17/2014 07:05 PM, Martin Kepplinger wrote:
don't reinvent dev_dbg(). remove dprintk() in as102_drv.c.
use the common kernel coding style.
Signed-off-by: Martin Kepplinger mart...@posteo.de
On Sat, May 17, 2014 at 08:21:03PM +0300, Antti Palosaari wrote:
On 05/17/2014 07:05 PM, Martin Kepplinger wrote:
don't reinvent dev_dbg(). remove dprintk() in as102_drv.c.
use the common kernel coding style.
Signed-off-by: Martin Kepplinger mart...@posteo.de
Reviewed-by: Antti Palosaari
16 matches
Mail list logo
