Re: [PATCHv2-next 1/3] arm64: dts: meson: odroid-c2: Add missing regulator linked to P5V0 regulator

[Martin Blumenstingl]

Hi Anand,

On Mon, Sep 2, 2019 at 10:58 AM Anand Moon  wrote:
>
> As per schematics VDDIO_AO18, VDDIO_AO3V3/VDD3V3 DDR3_1V5/DDR_VDDC:
> fixed regulator output which is supplied by P5V0.
>
> Cc: Martin Blumenstingl 
> Cc: Jerome Brunet 
> Cc: Neil Armstrong 
> Signed-off-by: Anand Moon 
one comment below, but overall this looks good:
Reviewed-by: Martin Blumenstingl 

[...]
> +   vddc_ddr: regulator-vddc-ddr {
> +   compatible = "regulator-fixed";
> +   regulator-name = "DDR3_1V5";
I prefer if the node name matches the regulator name, so in this case
I would write above:
  ddr3_1v5: regulator-ddr-1v5 {


Martin

[PATCHv2-next 1/3] arm64: dts: meson: odroid-c2: Add missing regulator linked to P5V0 regulator

[Anand Moon]

As per schematics VDDIO_AO18, VDDIO_AO3V3/VDD3V3 DDR3_1V5/DDR_VDDC:
fixed regulator output which is supplied by P5V0.

Cc: Martin Blumenstingl 
Cc: Jerome Brunet 
Cc: Neil Armstrong 
Signed-off-by: Anand Moon 
---
Changes from previous.
- drop the rename and linking vcc3v3 regulator node.
- fix the typo spelling.
---
 .../boot/dts/amlogic/meson-gxbb-odroidc2.dts  | 30 +++
 1 file changed, 30 insertions(+)

diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts 
b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
index 3e51f0835c8d..b763b76820ba 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
@@ -111,6 +111,36 @@
regulator-max-microvolt = <330>;
};
 
+   vddio_ao1v8: regulator-vddio-ao1v8 {
+   compatible = "regulator-fixed";
+   regulator-name = "VDDIO_AO1V8";
+   regulator-min-microvolt = <180>;
+   regulator-max-microvolt = <180>;
+   regulator-always-on;
+   /* U17 RT9179GB */
+   vin-supply = <>;
+   };
+
+   vddio_ao3v3: regulator-vddio-ao3v3 {
+   compatible = "regulator-fixed";
+   regulator-name = "VDDIO_AO3V3";
+   regulator-min-microvolt = <330>;
+   regulator-max-microvolt = <330>;
+   regulator-always-on;
+   /* U11 MP2161GJ-C499 */
+   vin-supply = <>;
+   };
+
+   vddc_ddr: regulator-vddc-ddr {
+   compatible = "regulator-fixed";
+   regulator-name = "DDR3_1V5";
+   regulator-min-microvolt = <150>;
+   regulator-max-microvolt = <150>;
+   regulator-always-on;
+   /* U15 MP2161GJ-C499 */
+   vin-supply = <>;
+   };
+
emmc_pwrseq: emmc-pwrseq {
compatible = "mmc-pwrseq-emmc";
reset-gpios = < BOOT_9 GPIO_ACTIVE_LOW>;
-- 
2.23.0