Re: [PATCHv2 0/4] perf/core: Add support to exclude kernel mode PMU tracing

2021-03-10 Thread Sai Prakash Ranjan
Hi Andi, On 2021-03-09 20:14, Andi Kleen wrote: The disk encryption is just one example and there might be others which we might not be aware of yet and we are not suspecting there is something wrong with the crypto code that needs to be fixed. Then you don't have any leaks relating to

Re: [PATCHv2 0/4] perf/core: Add support to exclude kernel mode PMU tracing

2021-03-09 Thread Andi Kleen
> The disk encryption is just one example and there might be others which > we might not be aware of yet and we are not suspecting there is something > wrong with the crypto code that needs to be fixed. Then you don't have any leaks relating to branch tracing. > restrict an external(in the sense

Re: [PATCHv2 0/4] perf/core: Add support to exclude kernel mode PMU tracing

2021-03-08 Thread Sai Prakash Ranjan
Hi Andi, On 2021-03-05 01:47, Andi Kleen wrote: > Andi Kleen writes: >> >> Normally disk encryption is in specialized work queues. It's total >> overkill to restrict all of the kernel if you just want to restrict >> those work queues. >> >> I would suggest some more analysis where secrets are

Re: [PATCHv2 0/4] perf/core: Add support to exclude kernel mode PMU tracing

2021-03-04 Thread Andi Kleen
Andi Kleen writes: > > Normally disk encryption is in specialized work queues. It's total > overkill to restrict all of the kernel if you just want to restrict > those work queues. > > I would suggest some more analysis where secrets are actually stored > and handled first. Also thinking about

Re: [PATCHv2 0/4] perf/core: Add support to exclude kernel mode PMU tracing

2021-03-04 Thread Andi Kleen
Sai Prakash Ranjan writes: > > "Consider a system where disk contents are encrypted and the encryption > key is set up by the user when mounting the file system. From that point > on the encryption key resides in the kernel. It seems reasonable to > expect that the disk encryption key be

[PATCHv2 0/4] perf/core: Add support to exclude kernel mode PMU tracing

2021-03-01 Thread Sai Prakash Ranjan
Hardware assisted tracing families such as ARM Coresight, Intel PT provides rich tracing capabilities including instruction level tracing and accurate timestamps which are very useful for profiling and also pose a significant security risk. One such example of security risk is when kernel mode