Re: [PATCHv2 1/1] SCSI: update hosts module to use idr index management

2015-10-07 Thread James Bottomley
On Wed, 2015-10-07 at 22:23 +0200, Hannes Reinecke wrote: > On 10/06/2015 07:17 PM, James Bottomley wrote: > > On Tue, 2015-10-06 at 10:14 -0700, Lee Duncan wrote: > >> On 10/06/2015 02:40 AM, Christoph Hellwig wrote: > struct Scsi_Host *scsi_host_lookup(unsigned short hostnum) > { >

Re: [PATCHv2 1/1] SCSI: update hosts module to use idr index management

2015-10-07 Thread Hannes Reinecke
On 10/06/2015 07:17 PM, James Bottomley wrote: On Tue, 2015-10-06 at 10:14 -0700, Lee Duncan wrote: On 10/06/2015 02:40 AM, Christoph Hellwig wrote: struct Scsi_Host *scsi_host_lookup(unsigned short hostnum) { - struct device *cdev; - struct Scsi_Host *shost = NULL; - -

Re: [PATCHv2 1/1] SCSI: update hosts module to use idr index management

2015-10-07 Thread James Bottomley
On Wed, 2015-10-07 at 22:23 +0200, Hannes Reinecke wrote: > On 10/06/2015 07:17 PM, James Bottomley wrote: > > On Tue, 2015-10-06 at 10:14 -0700, Lee Duncan wrote: > >> On 10/06/2015 02:40 AM, Christoph Hellwig wrote: > struct Scsi_Host *scsi_host_lookup(unsigned short hostnum) > { >

Re: [PATCHv2 1/1] SCSI: update hosts module to use idr index management

2015-10-07 Thread Hannes Reinecke
On 10/06/2015 07:17 PM, James Bottomley wrote: On Tue, 2015-10-06 at 10:14 -0700, Lee Duncan wrote: On 10/06/2015 02:40 AM, Christoph Hellwig wrote: struct Scsi_Host *scsi_host_lookup(unsigned short hostnum) { - struct device *cdev; - struct Scsi_Host *shost = NULL; - -

Re: [PATCHv2 1/1] SCSI: update hosts module to use idr index management

2015-10-06 Thread James Bottomley
On Tue, 2015-10-06 at 10:14 -0700, Lee Duncan wrote: > On 10/06/2015 02:40 AM, Christoph Hellwig wrote: > >> struct Scsi_Host *scsi_host_lookup(unsigned short hostnum) > >> { > >> - struct device *cdev; > >> - struct Scsi_Host *shost = NULL; > >> - > >> - cdev = class_find_device(_class,

Re: [PATCHv2 1/1] SCSI: update hosts module to use idr index management

2015-10-06 Thread Lee Duncan
On 10/06/2015 02:40 AM, Christoph Hellwig wrote: >> struct Scsi_Host *scsi_host_lookup(unsigned short hostnum) >> { >> -struct device *cdev; >> -struct Scsi_Host *shost = NULL; >> - >> -cdev = class_find_device(_class, NULL, , >> - __scsi_host_match); >> -

Re: [PATCHv2 1/1] SCSI: update hosts module to use idr index management

2015-10-06 Thread Hannes Reinecke
On 10/06/2015 01:01 AM, Lee Duncan wrote: Update the SCSI hosts module to use idr to manage its host_no index instead of an ATOMIC integer. This also allows using idr_find() to look up the SCSI host structure given the host number. This means that the SCSI host number will now be reclaimable.

Re: [PATCHv2 1/1] SCSI: update hosts module to use idr index management

2015-10-06 Thread Christoph Hellwig
> struct Scsi_Host *scsi_host_lookup(unsigned short hostnum) > { > - struct device *cdev; > - struct Scsi_Host *shost = NULL; > - > - cdev = class_find_device(_class, NULL, , > - __scsi_host_match); > - if (cdev) { > - shost =

Re: [PATCHv2 1/1] SCSI: update hosts module to use idr index management

2015-10-06 Thread Christoph Hellwig
> struct Scsi_Host *scsi_host_lookup(unsigned short hostnum) > { > - struct device *cdev; > - struct Scsi_Host *shost = NULL; > - > - cdev = class_find_device(_class, NULL, , > - __scsi_host_match); > - if (cdev) { > - shost =

Re: [PATCHv2 1/1] SCSI: update hosts module to use idr index management

2015-10-06 Thread Hannes Reinecke
On 10/06/2015 01:01 AM, Lee Duncan wrote: Update the SCSI hosts module to use idr to manage its host_no index instead of an ATOMIC integer. This also allows using idr_find() to look up the SCSI host structure given the host number. This means that the SCSI host number will now be reclaimable.

Re: [PATCHv2 1/1] SCSI: update hosts module to use idr index management

2015-10-06 Thread James Bottomley
On Tue, 2015-10-06 at 10:14 -0700, Lee Duncan wrote: > On 10/06/2015 02:40 AM, Christoph Hellwig wrote: > >> struct Scsi_Host *scsi_host_lookup(unsigned short hostnum) > >> { > >> - struct device *cdev; > >> - struct Scsi_Host *shost = NULL; > >> - > >> - cdev = class_find_device(_class,

Re: [PATCHv2 1/1] SCSI: update hosts module to use idr index management

2015-10-06 Thread Lee Duncan
On 10/06/2015 02:40 AM, Christoph Hellwig wrote: >> struct Scsi_Host *scsi_host_lookup(unsigned short hostnum) >> { >> -struct device *cdev; >> -struct Scsi_Host *shost = NULL; >> - >> -cdev = class_find_device(_class, NULL, , >> - __scsi_host_match); >> -

[PATCHv2 1/1] SCSI: update hosts module to use idr index management

2015-10-05 Thread Lee Duncan
Update the SCSI hosts module to use idr to manage its host_no index instead of an ATOMIC integer. This also allows using idr_find() to look up the SCSI host structure given the host number. This means that the SCSI host number will now be reclaimable. Signed-off-by: Lee Duncan ---

[PATCHv2 1/1] SCSI: update hosts module to use idr index management

2015-10-05 Thread Lee Duncan
Update the SCSI hosts module to use idr to manage its host_no index instead of an ATOMIC integer. This also allows using idr_find() to look up the SCSI host structure given the host number. This means that the SCSI host number will now be reclaimable. Signed-off-by: Lee Duncan