Re: [PATCHv2 1/2] pci: spear: Use platform_driver_probe instead of platform_driver_register

2015-02-16 Thread Viresh Kumar
On 15 February 2015 at 21:16, Matwey V. Kornilov wrote: > Or maybe it doesn't work at all. It wouldn't have as that wasn't required earlier. But when we are fixing it, we fix it proper. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: [PATCHv2 1/2] pci: spear: Use platform_driver_probe instead of platform_driver_register

2015-02-16 Thread Viresh Kumar
On 15 February 2015 at 21:16, Matwey V. Kornilov mat...@sai.msu.ru wrote: Or maybe it doesn't work at all. It wouldn't have as that wasn't required earlier. But when we are fixing it, we fix it proper. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a

Re: [PATCHv2 1/2] pci: spear: Use platform_driver_probe instead of platform_driver_register

2015-02-15 Thread Matwey V. Kornilov
2015-02-13 5:08 GMT+03:00 Stanimir Varbanov : > Hi, > > On 02/12/2015 11:07 AM, Matwey V. Kornilov wrote: >> 2015-02-11 12:19 GMT+03:00 Stanimir Varbanov : >>> please don't top posting. >>> >>> On 02/11/2015 10:38 AM, Matwey V. Kornilov wrote:HI >>> It sounds reasonable, but does current

Re: [PATCHv2 1/2] pci: spear: Use platform_driver_probe instead of platform_driver_register

2015-02-15 Thread Matwey V. Kornilov
2015-02-13 5:08 GMT+03:00 Stanimir Varbanov svarba...@mm-sol.com: Hi, On 02/12/2015 11:07 AM, Matwey V. Kornilov wrote: 2015-02-11 12:19 GMT+03:00 Stanimir Varbanov svarba...@mm-sol.com: please don't top posting. On 02/11/2015 10:38 AM, Matwey V. Kornilov wrote:HI It sounds reasonable,

Re: [PATCHv2 1/2] pci: spear: Use platform_driver_probe instead of platform_driver_register

2015-02-12 Thread Stanimir Varbanov
Hi, On 02/12/2015 11:07 AM, Matwey V. Kornilov wrote: > 2015-02-11 12:19 GMT+03:00 Stanimir Varbanov : >> please don't top posting. >> >> On 02/11/2015 10:38 AM, Matwey V. Kornilov wrote:HI >> >>> It sounds reasonable, but does current implementation support deferring? >> >>thor >> yes, it uses

Re: [PATCHv2 1/2] pci: spear: Use platform_driver_probe instead of platform_driver_register

2015-02-12 Thread Matwey V. Kornilov
2015-02-11 12:19 GMT+03:00 Stanimir Varbanov : > please don't top posting. > > On 02/11/2015 10:38 AM, Matwey V. Kornilov wrote: >> >> It sounds reasonable, but does current implementation support deferring? > > > yes, it uses deferred probe see devm_phy_get() and devm_clk_get() calls in > .probe

Re: [PATCHv2 1/2] pci: spear: Use platform_driver_probe instead of platform_driver_register

2015-02-12 Thread Stanimir Varbanov
Hi, On 02/12/2015 11:07 AM, Matwey V. Kornilov wrote: 2015-02-11 12:19 GMT+03:00 Stanimir Varbanov svarba...@mm-sol.com: please don't top posting. On 02/11/2015 10:38 AM, Matwey V. Kornilov wrote:HI It sounds reasonable, but does current implementation support deferring? thor yes, it uses

Re: [PATCHv2 1/2] pci: spear: Use platform_driver_probe instead of platform_driver_register

2015-02-12 Thread Matwey V. Kornilov
2015-02-11 12:19 GMT+03:00 Stanimir Varbanov svarba...@mm-sol.com: please don't top posting. On 02/11/2015 10:38 AM, Matwey V. Kornilov wrote: It sounds reasonable, but does current implementation support deferring? yes, it uses deferred probe see devm_phy_get() and devm_clk_get() calls in

Re: [PATCHv2 1/2] pci: spear: Use platform_driver_probe instead of platform_driver_register

2015-02-11 Thread Stanimir Varbanov
please don't top posting. On 02/11/2015 10:38 AM, Matwey V. Kornilov wrote: It sounds reasonable, but does current implementation support deferring? yes, it uses deferred probe see devm_phy_get() and devm_clk_get() calls in .probe and how the returned values are checked. Struct

Re: [PATCHv2 1/2] pci: spear: Use platform_driver_probe instead of platform_driver_register

2015-02-11 Thread Stanimir Varbanov
please don't top posting. On 02/11/2015 10:38 AM, Matwey V. Kornilov wrote: It sounds reasonable, but does current implementation support deferring? yes, it uses deferred probe see devm_phy_get() and devm_clk_get() calls in .probe and how the returned values are checked. Struct

Re: [PATCHv2 1/2] pci: spear: Use platform_driver_probe instead of platform_driver_register

2015-02-10 Thread Stanimir Varbanov
Hi, On 02/11/2015 05:35 AM, Viresh Kumar wrote: On 11 February 2015 at 00:31, Matwey V. Kornilov wrote: Use platform_driver_probe instead of platform_driver_register because the former allows us to use probe function placed into __init section and the driver itself is not support hotplugging

Re: [PATCHv2 1/2] pci: spear: Use platform_driver_probe instead of platform_driver_register

2015-02-10 Thread Viresh Kumar
On 11 February 2015 at 00:31, Matwey V. Kornilov wrote: > Use platform_driver_probe instead of platform_driver_register > because the former allows us to use probe function placed into __init section > and the driver itself is not support hotplugging (yet?). > > Signed-off-by: Matwey V. Kornilov

[PATCHv2 1/2] pci: spear: Use platform_driver_probe instead of platform_driver_register

2015-02-10 Thread Matwey V. Kornilov
Use platform_driver_probe instead of platform_driver_register because the former allows us to use probe function placed into __init section and the driver itself is not support hotplugging (yet?). Signed-off-by: Matwey V. Kornilov --- Changes from v1: - Use platform_driver_probe instead of

Re: [PATCHv2 1/2] pci: spear: Use platform_driver_probe instead of platform_driver_register

2015-02-10 Thread Viresh Kumar
On 11 February 2015 at 00:31, Matwey V. Kornilov mat...@sai.msu.ru wrote: Use platform_driver_probe instead of platform_driver_register because the former allows us to use probe function placed into __init section and the driver itself is not support hotplugging (yet?). Signed-off-by: Matwey

[PATCHv2 1/2] pci: spear: Use platform_driver_probe instead of platform_driver_register

2015-02-10 Thread Matwey V. Kornilov
Use platform_driver_probe instead of platform_driver_register because the former allows us to use probe function placed into __init section and the driver itself is not support hotplugging (yet?). Signed-off-by: Matwey V. Kornilov mat...@sai.msu.ru --- Changes from v1: - Use

Re: [PATCHv2 1/2] pci: spear: Use platform_driver_probe instead of platform_driver_register

2015-02-10 Thread Stanimir Varbanov
Hi, On 02/11/2015 05:35 AM, Viresh Kumar wrote: On 11 February 2015 at 00:31, Matwey V. Kornilov mat...@sai.msu.ru wrote: Use platform_driver_probe instead of platform_driver_register because the former allows us to use probe function placed into __init section and the driver itself is not