On 11/13/2013 07:52 AM, Alan Stern wrote:
On Tue, 12 Nov 2013, Paul Zimmerman wrote:
@@ -824,7 +832,7 @@ static ssize_t ffs_epfile_io(struct file *file,
req->context =
req->complete = ffs_epfile_io_complete;
req->buf = data;
-
On Tue, 12 Nov 2013, Paul Zimmerman wrote:
> > > >>> @@ -824,7 +832,7 @@ static ssize_t ffs_epfile_io(struct file *file,
> > > >>> req->context =
> > > >>> req->complete = ffs_epfile_io_complete;
> > > >>> req->buf = data;
> > > >>> -
On Tue, 12 Nov 2013, Paul Zimmerman wrote:
@@ -824,7 +832,7 @@ static ssize_t ffs_epfile_io(struct file *file,
req-context = done;
req-complete = ffs_epfile_io_complete;
req-buf = data;
- req-length = len;
+
On 11/13/2013 07:52 AM, Alan Stern wrote:
On Tue, 12 Nov 2013, Paul Zimmerman wrote:
@@ -824,7 +832,7 @@ static ssize_t ffs_epfile_io(struct file *file,
req-context = done;
req-complete = ffs_epfile_io_complete;
req-buf = data;
-
> From: David Cohen [mailto:david.a.co...@linux.intel.com]
> Sent: Tuesday, November 12, 2013 3:44 PM
>
> On 11/12/2013 03:09 PM, Paul Zimmerman wrote:
>
> >> From: linux-usb-ow...@vger.kernel.org
> >> [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Alan Stern
> >> Sent: Tuesday, November
Hi Paul,
On 11/12/2013 03:09 PM, Paul Zimmerman wrote:
From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb-ow...@vger.kernel.org]
On Behalf Of Alan Stern
Sent: Tuesday, November 12, 2013 7:51 AM
On Mon, 11 Nov 2013, David Cohen wrote:
Hi Alan, Michal,
On 11/11/2013 01:09 PM, Michal
> From: linux-usb-ow...@vger.kernel.org
> [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Alan Stern
> Sent: Tuesday, November 12, 2013 7:51 AM
>
> On Mon, 11 Nov 2013, David Cohen wrote:
>
> > Hi Alan, Michal,
> >
> > On 11/11/2013 01:09 PM, Michal Nazarewicz wrote:
> > > On Mon, Nov 11
IIUC, req->length should still be set to len, not to data_len.
>>
>> I misunderstood the first time I read it:
>> In order to avoid DWC3 to stall, we need to update req->length (this is
>> the most important fix). kmalloc() is updated too to prevent USB
>> controller to overflow buffer
On Mon, 11 Nov 2013, David Cohen wrote:
> Hi Alan, Michal,
>
> On 11/11/2013 01:09 PM, Michal Nazarewicz wrote:
> > On Mon, Nov 11 2013, Alan Stern wrote:
> >> On Mon, 11 Nov 2013, Michal Nazarewicz wrote:
> >>
> >>> Check gadget.quirk_ep_out_aligned_size to decide if buffer size requires
> >>>
On Mon, 11 Nov 2013, David Cohen wrote:
Hi Alan, Michal,
On 11/11/2013 01:09 PM, Michal Nazarewicz wrote:
On Mon, Nov 11 2013, Alan Stern wrote:
On Mon, 11 Nov 2013, Michal Nazarewicz wrote:
Check gadget.quirk_ep_out_aligned_size to decide if buffer size requires
to be aligned to
IIUC, req-length should still be set to len, not to data_len.
I misunderstood the first time I read it:
In order to avoid DWC3 to stall, we need to update req-length (this is
the most important fix). kmalloc() is updated too to prevent USB
controller to overflow buffer boundaries.
Here I
From: linux-usb-ow...@vger.kernel.org
[mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Alan Stern
Sent: Tuesday, November 12, 2013 7:51 AM
On Mon, 11 Nov 2013, David Cohen wrote:
Hi Alan, Michal,
On 11/11/2013 01:09 PM, Michal Nazarewicz wrote:
On Mon, Nov 11 2013, Alan
Hi Paul,
On 11/12/2013 03:09 PM, Paul Zimmerman wrote:
From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb-ow...@vger.kernel.org]
On Behalf Of Alan Stern
Sent: Tuesday, November 12, 2013 7:51 AM
On Mon, 11 Nov 2013, David Cohen wrote:
Hi Alan, Michal,
On 11/11/2013 01:09 PM, Michal
From: David Cohen [mailto:david.a.co...@linux.intel.com]
Sent: Tuesday, November 12, 2013 3:44 PM
On 11/12/2013 03:09 PM, Paul Zimmerman wrote:
From: linux-usb-ow...@vger.kernel.org
[mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Alan Stern
Sent: Tuesday, November 12, 2013 7:51
On 11/11/2013 03:21 AM, Michal Nazarewicz wrote:
Check gadget.quirk_ep_out_aligned_size to decide if buffer size requires
to be aligned to maxpacketsize of an out endpoint. ffs_epfile_io() needs
to pad epout buffer to match above condition if quirk is found.
Signed-off-by: Michal Nazarewicz
Hi Alan, Michal,
On 11/11/2013 01:09 PM, Michal Nazarewicz wrote:
On Mon, Nov 11 2013, Alan Stern wrote:
On Mon, 11 Nov 2013, Michal Nazarewicz wrote:
Check gadget.quirk_ep_out_aligned_size to decide if buffer size requires
to be aligned to maxpacketsize of an out endpoint. ffs_epfile_io()
On Mon, Nov 11 2013, David Cohen wrote:
> But the whole series became messy with too many amends. If you don't
> mind, I'll send a v5 of my patch set including my v4.1 patches + your 2
> ones following the correct sequence.
Please do, but as Alan pointed out my second patch needs some fixes,
On Mon, Nov 11 2013, Alan Stern wrote:
> On Mon, 11 Nov 2013, Michal Nazarewicz wrote:
>
>> Check gadget.quirk_ep_out_aligned_size to decide if buffer size requires
>> to be aligned to maxpacketsize of an out endpoint. ffs_epfile_io() needs
>> to pad epout buffer to match above condition if quirk
On Mon, 11 Nov 2013, Michal Nazarewicz wrote:
> Check gadget.quirk_ep_out_aligned_size to decide if buffer size requires
> to be aligned to maxpacketsize of an out endpoint. ffs_epfile_io() needs
> to pad epout buffer to match above condition if quirk is found.
>
> Signed-off-by: Michal
On 11/11/2013 03:21 AM, Michal Nazarewicz wrote:
Check gadget.quirk_ep_out_aligned_size to decide if buffer size requires
to be aligned to maxpacketsize of an out endpoint. ffs_epfile_io() needs
to pad epout buffer to match above condition if quirk is found.
Signed-off-by: Michal Nazarewicz
Check gadget.quirk_ep_out_aligned_size to decide if buffer size requires
to be aligned to maxpacketsize of an out endpoint. ffs_epfile_io() needs
to pad epout buffer to match above condition if quirk is found.
Signed-off-by: Michal Nazarewicz
---
drivers/usb/gadget/f_fs.c | 23
Check gadget.quirk_ep_out_aligned_size to decide if buffer size requires
to be aligned to maxpacketsize of an out endpoint. ffs_epfile_io() needs
to pad epout buffer to match above condition if quirk is found.
Signed-off-by: Michal Nazarewicz min...@mina86.com
---
drivers/usb/gadget/f_fs.c | 23
On 11/11/2013 03:21 AM, Michal Nazarewicz wrote:
Check gadget.quirk_ep_out_aligned_size to decide if buffer size requires
to be aligned to maxpacketsize of an out endpoint. ffs_epfile_io() needs
to pad epout buffer to match above condition if quirk is found.
Signed-off-by: Michal Nazarewicz
On Mon, 11 Nov 2013, Michal Nazarewicz wrote:
Check gadget.quirk_ep_out_aligned_size to decide if buffer size requires
to be aligned to maxpacketsize of an out endpoint. ffs_epfile_io() needs
to pad epout buffer to match above condition if quirk is found.
Signed-off-by: Michal Nazarewicz
On Mon, Nov 11 2013, Alan Stern wrote:
On Mon, 11 Nov 2013, Michal Nazarewicz wrote:
Check gadget.quirk_ep_out_aligned_size to decide if buffer size requires
to be aligned to maxpacketsize of an out endpoint. ffs_epfile_io() needs
to pad epout buffer to match above condition if quirk is
On Mon, Nov 11 2013, David Cohen wrote:
But the whole series became messy with too many amends. If you don't
mind, I'll send a v5 of my patch set including my v4.1 patches + your 2
ones following the correct sequence.
Please do, but as Alan pointed out my second patch needs some fixes,
namely
Hi Alan, Michal,
On 11/11/2013 01:09 PM, Michal Nazarewicz wrote:
On Mon, Nov 11 2013, Alan Stern wrote:
On Mon, 11 Nov 2013, Michal Nazarewicz wrote:
Check gadget.quirk_ep_out_aligned_size to decide if buffer size requires
to be aligned to maxpacketsize of an out endpoint. ffs_epfile_io()
On 11/11/2013 03:21 AM, Michal Nazarewicz wrote:
Check gadget.quirk_ep_out_aligned_size to decide if buffer size requires
to be aligned to maxpacketsize of an out endpoint. ffs_epfile_io() needs
to pad epout buffer to match above condition if quirk is found.
Signed-off-by: Michal Nazarewicz
28 matches
Mail list logo
