Re: [PATCHv3 0/3] perf tool: Add new event group management

2012-07-18 Thread Jiri Olsa
On Wed, Jul 18, 2012 at 08:34:10AM -0400, Ulrich Drepper wrote: > On Wed, Jul 18, 2012 at 6:21 AM, Jiri Olsa wrote: > > Well, I personally like the '{}' syntax more than '--group-events or > > --group-reads > > option in front', it feels more user friendly.. anyway, we can easily have > > both

Re: [PATCHv3 0/3] perf tool: Add new event group management

2012-07-18 Thread Ulrich Drepper
On Wed, Jul 18, 2012 at 6:21 AM, Jiri Olsa wrote: > Well, I personally like the '{}' syntax more than '--group-events or > --group-reads > option in front', it feels more user friendly.. anyway, we can easily have > both ways. I like the actual visual grouping better, too. Also, it doesn't

Re: [PATCHv3 0/3] perf tool: Add new event group management

2012-07-18 Thread Jiri Olsa
On Tue, Jul 17, 2012 at 09:15:23AM +0200, Stephane Eranian wrote: > On Mon, Jul 9, 2012 at 1:05 PM, Jiri Olsa wrote: > > > > On Fri, Jul 06, 2012 at 03:42:54AM +0200, Stephane Eranian wrote: > > > On Fri, Jul 6, 2012 at 3:32 AM, Ulrich Drepper wrote: > > > > On Thu, Jul 5, 2012 at 12:15 PM,

Re: [PATCHv3 0/3] perf tool: Add new event group management

2012-07-18 Thread Jiri Olsa
On Tue, Jul 17, 2012 at 09:15:23AM +0200, Stephane Eranian wrote: On Mon, Jul 9, 2012 at 1:05 PM, Jiri Olsa jo...@redhat.com wrote: On Fri, Jul 06, 2012 at 03:42:54AM +0200, Stephane Eranian wrote: On Fri, Jul 6, 2012 at 3:32 AM, Ulrich Drepper drep...@gmail.com wrote: On Thu, Jul 5,

Re: [PATCHv3 0/3] perf tool: Add new event group management

2012-07-18 Thread Ulrich Drepper
On Wed, Jul 18, 2012 at 6:21 AM, Jiri Olsa jo...@redhat.com wrote: Well, I personally like the '{}' syntax more than '--group-events or --group-reads option in front', it feels more user friendly.. anyway, we can easily have both ways. I like the actual visual grouping better, too. Also,

Re: [PATCHv3 0/3] perf tool: Add new event group management

2012-07-18 Thread Jiri Olsa
On Wed, Jul 18, 2012 at 08:34:10AM -0400, Ulrich Drepper wrote: On Wed, Jul 18, 2012 at 6:21 AM, Jiri Olsa jo...@redhat.com wrote: Well, I personally like the '{}' syntax more than '--group-events or --group-reads option in front', it feels more user friendly.. anyway, we can easily have

Re: [PATCHv3 0/3] perf tool: Add new event group management

2012-07-17 Thread Andi Kleen
> To me ,this looks a bit of an over-engineered design and it is not based on > any actual user requests. Don't get me wrong, grouping is useful and required > but nobody has ever asked for that level of flexibility. The syntax you have > now is already very rich for my taste. The user input I

Re: [PATCHv3 0/3] perf tool: Add new event group management

2012-07-17 Thread Stephane Eranian
On Mon, Jul 9, 2012 at 1:05 PM, Jiri Olsa wrote: > > On Fri, Jul 06, 2012 at 03:42:54AM +0200, Stephane Eranian wrote: > > On Fri, Jul 6, 2012 at 3:32 AM, Ulrich Drepper wrote: > > > On Thu, Jul 5, 2012 at 12:15 PM, Stephane Eranian > > > wrote: > > >> I don't understand why you actually need

Re: [PATCHv3 0/3] perf tool: Add new event group management

2012-07-17 Thread Stephane Eranian
On Mon, Jul 9, 2012 at 1:05 PM, Jiri Olsa jo...@redhat.com wrote: On Fri, Jul 06, 2012 at 03:42:54AM +0200, Stephane Eranian wrote: On Fri, Jul 6, 2012 at 3:32 AM, Ulrich Drepper drep...@gmail.com wrote: On Thu, Jul 5, 2012 at 12:15 PM, Stephane Eranian eran...@google.com wrote: I

Re: [PATCHv3 0/3] perf tool: Add new event group management

2012-07-17 Thread Andi Kleen
To me ,this looks a bit of an over-engineered design and it is not based on any actual user requests. Don't get me wrong, grouping is useful and required but nobody has ever asked for that level of flexibility. The syntax you have now is already very rich for my taste. The user input I hear

Re: [PATCHv3 0/3] perf tool: Add new event group management

2012-07-09 Thread Peter Zijlstra
On Mon, 2012-07-09 at 13:05 +0200, Jiri Olsa wrote: > the {} thing allows: 1) multiple groups in a single -e The advantage would be when you're passing such things on via environment variables or somesuch. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of

Re: [PATCHv3 0/3] perf tool: Add new event group management

2012-07-09 Thread Jiri Olsa
On Fri, Jul 06, 2012 at 03:42:54AM +0200, Stephane Eranian wrote: > On Fri, Jul 6, 2012 at 3:32 AM, Ulrich Drepper wrote: > > On Thu, Jul 5, 2012 at 12:15 PM, Stephane Eranian > > wrote: > >> I don't understand why you actually need the :2 suffix. There can > >> only be one leader. So assume it

Re: [PATCHv3 0/3] perf tool: Add new event group management

2012-07-09 Thread Jiri Olsa
On Fri, Jul 06, 2012 at 03:42:54AM +0200, Stephane Eranian wrote: On Fri, Jul 6, 2012 at 3:32 AM, Ulrich Drepper drep...@gmail.com wrote: On Thu, Jul 5, 2012 at 12:15 PM, Stephane Eranian eran...@google.com wrote: I don't understand why you actually need the :2 suffix. There can only be

Re: [PATCHv3 0/3] perf tool: Add new event group management

2012-07-09 Thread Peter Zijlstra
On Mon, 2012-07-09 at 13:05 +0200, Jiri Olsa wrote: peterz the {} thing allows: 1) multiple groups in a single -e The advantage would be when you're passing such things on via environment variables or somesuch. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body