Re: [PATCHv3 02/17] mm/khugepaged: Do not collapse pages in encrypted VMAs

2018-06-13 Thread Kirill A. Shutemov
On Wed, Jun 13, 2018 at 08:20:28PM +, Dave Hansen wrote: > On 06/13/2018 01:18 PM, Kirill A. Shutemov wrote: > >> Are we really asking the x86 maintainers to merge this feature with this > >> restriction in place? > > I gave it more thought after your comment and I think I see a way to get > >

Re: [PATCHv3 02/17] mm/khugepaged: Do not collapse pages in encrypted VMAs

2018-06-13 Thread Kirill A. Shutemov
On Wed, Jun 13, 2018 at 08:20:28PM +, Dave Hansen wrote: > On 06/13/2018 01:18 PM, Kirill A. Shutemov wrote: > >> Are we really asking the x86 maintainers to merge this feature with this > >> restriction in place? > > I gave it more thought after your comment and I think I see a way to get > >

Re: [PATCHv3 02/17] mm/khugepaged: Do not collapse pages in encrypted VMAs

2018-06-13 Thread Dave Hansen
On 06/13/2018 01:18 PM, Kirill A. Shutemov wrote: >> Are we really asking the x86 maintainers to merge this feature with this >> restriction in place? > I gave it more thought after your comment and I think I see a way to get > khugepaged work with memory encryption. So should folks be reviewing

Re: [PATCHv3 02/17] mm/khugepaged: Do not collapse pages in encrypted VMAs

2018-06-13 Thread Dave Hansen
On 06/13/2018 01:18 PM, Kirill A. Shutemov wrote: >> Are we really asking the x86 maintainers to merge this feature with this >> restriction in place? > I gave it more thought after your comment and I think I see a way to get > khugepaged work with memory encryption. So should folks be reviewing

Re: [PATCHv3 02/17] mm/khugepaged: Do not collapse pages in encrypted VMAs

2018-06-13 Thread Kirill A. Shutemov
On Wed, Jun 13, 2018 at 05:50:24PM +, Dave Hansen wrote: > On 06/12/2018 07:39 AM, Kirill A. Shutemov wrote: > > Pages for encrypted VMAs have to be allocated in a special way: > > we would need to propagate down not only desired NUMA node but also > > whether the page is encrypted. > > > >

Re: [PATCHv3 02/17] mm/khugepaged: Do not collapse pages in encrypted VMAs

2018-06-13 Thread Kirill A. Shutemov
On Wed, Jun 13, 2018 at 05:50:24PM +, Dave Hansen wrote: > On 06/12/2018 07:39 AM, Kirill A. Shutemov wrote: > > Pages for encrypted VMAs have to be allocated in a special way: > > we would need to propagate down not only desired NUMA node but also > > whether the page is encrypted. > > > >

Re: [PATCHv3 02/17] mm/khugepaged: Do not collapse pages in encrypted VMAs

2018-06-13 Thread Dave Hansen
On 06/12/2018 07:39 AM, Kirill A. Shutemov wrote: > Pages for encrypted VMAs have to be allocated in a special way: > we would need to propagate down not only desired NUMA node but also > whether the page is encrypted. > > It complicates not-so-trivial routine of huge page allocation in >

Re: [PATCHv3 02/17] mm/khugepaged: Do not collapse pages in encrypted VMAs

2018-06-13 Thread Dave Hansen
On 06/12/2018 07:39 AM, Kirill A. Shutemov wrote: > Pages for encrypted VMAs have to be allocated in a special way: > we would need to propagate down not only desired NUMA node but also > whether the page is encrypted. > > It complicates not-so-trivial routine of huge page allocation in >

[PATCHv3 02/17] mm/khugepaged: Do not collapse pages in encrypted VMAs

2018-06-12 Thread Kirill A. Shutemov
Pages for encrypted VMAs have to be allocated in a special way: we would need to propagate down not only desired NUMA node but also whether the page is encrypted. It complicates not-so-trivial routine of huge page allocation in khugepaged even more. It also puts more pressure on page allocator:

[PATCHv3 02/17] mm/khugepaged: Do not collapse pages in encrypted VMAs

2018-06-12 Thread Kirill A. Shutemov
Pages for encrypted VMAs have to be allocated in a special way: we would need to propagate down not only desired NUMA node but also whether the page is encrypted. It complicates not-so-trivial routine of huge page allocation in khugepaged even more. It also puts more pressure on page allocator: