Re: [PATCHv3 1/4] zram: introduce compressing backend abstraction

2014-02-12 Thread Sergey Senozhatsky
On (02/12/14 16:06), Minchan Kim wrote: [..] > > +{ > > + kfree(workmem); > > +} > > It's okay to name "workmem" for lzo because lzo needs only work buffer to work > but let's think about zlib. It needs z_streamp which has many feilds > to work as well as work memory. That's why I don't like "wo

Re: [PATCHv3 1/4] zram: introduce compressing backend abstraction

2014-02-12 Thread Sergey Senozhatsky
On (02/12/14 16:08), Minchan Kim wrote: [..] > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > + > > +#include "zram_comp.h" > > + > > +extern struct zram_comp_backend zcomp_lzo; > > + > > +static void workmem_free(struct zram_comp *comp, struct zcomp_wor

Re: [PATCHv3 1/4] zram: introduce compressing backend abstraction

2014-02-11 Thread Minchan Kim
Hello Sergey, On Wed, Feb 12, 2014 at 01:21:03AM +0300, Sergey Senozhatsky wrote: > ZRAM performs direct LZO compression algorithm calls, making it the one > and only option. Introduce abstract struct zram_comp in order to support > multiple compression algorithms. struct zram_comp defines the fol

Re: [PATCHv3 1/4] zram: introduce compressing backend abstraction

2014-02-11 Thread Minchan Kim
On Wed, Feb 12, 2014 at 01:21:03AM +0300, Sergey Senozhatsky wrote: > ZRAM performs direct LZO compression algorithm calls, making it the one > and only option. Introduce abstract struct zram_comp in order to support > multiple compression algorithms. struct zram_comp defines the following > set of

[PATCHv3 1/4] zram: introduce compressing backend abstraction

2014-02-11 Thread Sergey Senozhatsky
ZRAM performs direct LZO compression algorithm calls, making it the one and only option. Introduce abstract struct zram_comp in order to support multiple compression algorithms. struct zram_comp defines the following set of compressing backend operations: .create .destroy .c