Re: [PATCHv3 16/32] metag: copy_thread(): rename 'arg' argument to 'kthread_arg'

[James Hogan]

On 16/03/15 14:38, Alex Dowad wrote:
> The 'arg' argument to copy_thread() is only ever used when forking a new
> kernel thread. Hence, rename it to 'kthread_arg' for clarity.
> 
> Signed-off-by: Alex Dowad 
> ---
> 
> Fixed problem with whitespace, sending again. AD
> 
>  arch/metag/kernel/process.c | 8 ++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/metag/kernel/process.c b/arch/metag/kernel/process.c
> index 483dff9..dcb4609 100644
> --- a/arch/metag/kernel/process.c
> +++ b/arch/metag/kernel/process.c
> @@ -174,8 +174,11 @@ void show_regs(struct pt_regs *regs)
>   show_trace(NULL, (unsigned long *)regs->ctx.AX[0].U0, regs);
>  }
>  
> +/*
> + * Copy architecture-specific thread state
> + */
>  int copy_thread(unsigned long clone_flags, unsigned long usp,
> - unsigned long arg, struct task_struct *tsk)
> + unsigned long kthread_arg, struct task_struct *tsk)
>  {
>   struct pt_regs *childregs = task_pt_regs(tsk);
>   void *kernel_context = ((void *) childregs +
> @@ -204,10 +207,11 @@ int copy_thread(unsigned long clone_flags, unsigned 
> long usp,
>   childregs->ctx.AX[0].U0 = (unsigned long) kernel_context;
> - /* Set D1Ar1=arg and D1RtP=usp (fn) */
> + /* Set D1Ar1=kthread_arg and D1RtP=usp (fn) */

FYI this still has a space before the tab, and isn't indented to the
same level as the surrounding code, but I'll just fix that up when I
apply it.

Thanks
James

>   childregs->ctx.DX[4].U1 = usp;
> - childregs->ctx.DX[3].U1 = arg;
> + childregs->ctx.DX[3].U1 = kthread_arg;
>   tsk->thread.int_depth = 2;
>   return 0;
>   }
> +
>   /*
>* Get a pointer to where the new child's register block should have
>* been pushed.
> 



signature.asc
Description: OpenPGP digital signature

[PATCHv3 16/32] metag: copy_thread(): rename 'arg' argument to 'kthread_arg'

[Alex Dowad]

The 'arg' argument to copy_thread() is only ever used when forking a new
kernel thread. Hence, rename it to 'kthread_arg' for clarity.

Signed-off-by: Alex Dowad 
---

Fixed problem with whitespace, sending again. AD

 arch/metag/kernel/process.c | 8 ++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/arch/metag/kernel/process.c b/arch/metag/kernel/process.c
index 483dff9..dcb4609 100644
--- a/arch/metag/kernel/process.c
+++ b/arch/metag/kernel/process.c
@@ -174,8 +174,11 @@ void show_regs(struct pt_regs *regs)
show_trace(NULL, (unsigned long *)regs->ctx.AX[0].U0, regs);
 }
 
+/*
+ * Copy architecture-specific thread state
+ */
 int copy_thread(unsigned long clone_flags, unsigned long usp,
-   unsigned long arg, struct task_struct *tsk)
+   unsigned long kthread_arg, struct task_struct *tsk)
 {
struct pt_regs *childregs = task_pt_regs(tsk);
void *kernel_context = ((void *) childregs +
@@ -204,10 +207,11 @@ int copy_thread(unsigned long clone_flags, unsigned long 
usp,
childregs->ctx.AX[0].U0 = (unsigned long) kernel_context;
-   /* Set D1Ar1=arg and D1RtP=usp (fn) */
+   /* Set D1Ar1=kthread_arg and D1RtP=usp (fn) */
childregs->ctx.DX[4].U1 = usp;
-   childregs->ctx.DX[3].U1 = arg;
+   childregs->ctx.DX[3].U1 = kthread_arg;
tsk->thread.int_depth = 2;
return 0;
}
+
/*
 * Get a pointer to where the new child's register block should have
 * been pushed.
-- 
2.0.0.GIT

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCHv3 16/32] metag: copy_thread(): rename 'arg' argument to 'kthread_arg'

[Alex Dowad]

The 'arg' argument to copy_thread() is only ever used when forking a new
kernel thread. Hence, rename it to 'kthread_arg' for clarity.

Signed-off-by: Alex Dowad alexinbeij...@gmail.com
---

Fixed problem with whitespace, sending again. AD

 arch/metag/kernel/process.c | 8 ++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/arch/metag/kernel/process.c b/arch/metag/kernel/process.c
index 483dff9..dcb4609 100644
--- a/arch/metag/kernel/process.c
+++ b/arch/metag/kernel/process.c
@@ -174,8 +174,11 @@ void show_regs(struct pt_regs *regs)
show_trace(NULL, (unsigned long *)regs-ctx.AX[0].U0, regs);
 }
 
+/*
+ * Copy architecture-specific thread state
+ */
 int copy_thread(unsigned long clone_flags, unsigned long usp,
-   unsigned long arg, struct task_struct *tsk)
+   unsigned long kthread_arg, struct task_struct *tsk)
 {
struct pt_regs *childregs = task_pt_regs(tsk);
void *kernel_context = ((void *) childregs +
@@ -204,10 +207,11 @@ int copy_thread(unsigned long clone_flags, unsigned long 
usp,
childregs-ctx.AX[0].U0 = (unsigned long) kernel_context;
-   /* Set D1Ar1=arg and D1RtP=usp (fn) */
+   /* Set D1Ar1=kthread_arg and D1RtP=usp (fn) */
childregs-ctx.DX[4].U1 = usp;
-   childregs-ctx.DX[3].U1 = arg;
+   childregs-ctx.DX[3].U1 = kthread_arg;
tsk-thread.int_depth = 2;
return 0;
}
+
/*
 * Get a pointer to where the new child's register block should have
 * been pushed.
-- 
2.0.0.GIT

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCHv3 16/32] metag: copy_thread(): rename 'arg' argument to 'kthread_arg'

[James Hogan]

On 16/03/15 14:38, Alex Dowad wrote:
 The 'arg' argument to copy_thread() is only ever used when forking a new
 kernel thread. Hence, rename it to 'kthread_arg' for clarity.
 
 Signed-off-by: Alex Dowad alexinbeij...@gmail.com
 ---
 
 Fixed problem with whitespace, sending again. AD
 
  arch/metag/kernel/process.c | 8 ++--
  1 file changed, 6 insertions(+), 2 deletions(-)
 
 diff --git a/arch/metag/kernel/process.c b/arch/metag/kernel/process.c
 index 483dff9..dcb4609 100644
 --- a/arch/metag/kernel/process.c
 +++ b/arch/metag/kernel/process.c
 @@ -174,8 +174,11 @@ void show_regs(struct pt_regs *regs)
   show_trace(NULL, (unsigned long *)regs-ctx.AX[0].U0, regs);
  }
  
 +/*
 + * Copy architecture-specific thread state
 + */
  int copy_thread(unsigned long clone_flags, unsigned long usp,
 - unsigned long arg, struct task_struct *tsk)
 + unsigned long kthread_arg, struct task_struct *tsk)
  {
   struct pt_regs *childregs = task_pt_regs(tsk);
   void *kernel_context = ((void *) childregs +
 @@ -204,10 +207,11 @@ int copy_thread(unsigned long clone_flags, unsigned 
 long usp,
   childregs-ctx.AX[0].U0 = (unsigned long) kernel_context;
 - /* Set D1Ar1=arg and D1RtP=usp (fn) */
 + /* Set D1Ar1=kthread_arg and D1RtP=usp (fn) */

FYI this still has a space before the tab, and isn't indented to the
same level as the surrounding code, but I'll just fix that up when I
apply it.

Thanks
James

   childregs-ctx.DX[4].U1 = usp;
 - childregs-ctx.DX[3].U1 = arg;
 + childregs-ctx.DX[3].U1 = kthread_arg;
   tsk-thread.int_depth = 2;
   return 0;
   }
 +
   /*
* Get a pointer to where the new child's register block should have
* been pushed.
 



signature.asc
Description: OpenPGP digital signature