Re: [PATCHv3 2.6.25] i2c: adds support for i2c bus on Freescale CPM1/CPM2 controllers

2008-01-28 Thread Jochen Friedrich
Hi Bryan, >> + >> + /* register new adapter to i2c module... */ >> + >> + result = i2c_add_adapter(>adap); > > As I was pointed before, please use the new style i2c driver interface: >

Re: [PATCHv3 2.6.25] i2c: adds support for i2c bus on Freescale CPM1/CPM2 controllers

2008-01-28 Thread Bryan Wu
On Jan 26, 2008 1:11 AM, Jochen Friedrich <[EMAIL PROTECTED]> wrote: > Using the port of 2.4 code from Vitaly Bordug <[EMAIL PROTECTED]> > and the actual algorithm used by the i2c driver of the DBox code on > cvs.tuxboc.org from Tmbinc, Gillem ([EMAIL PROTECTED]). Renamed i2c-rpx.c and >

Re: [PATCHv3 2.6.25] i2c: adds support for i2c bus on Freescale CPM1/CPM2 controllers

2008-01-28 Thread Kumar Gala
On Jan 25, 2008, at 11:11 AM, Jochen Friedrich wrote: Using the port of 2.4 code from Vitaly Bordug <[EMAIL PROTECTED] > and the actual algorithm used by the i2c driver of the DBox code on cvs.tuxboc.org from Tmbinc, Gillem ([EMAIL PROTECTED]). Renamed i2c-rpx.c and i2c-algo-8xx.c to

Re: [PATCHv3 2.6.25] i2c: adds support for i2c bus on Freescale CPM1/CPM2 controllers

2008-01-28 Thread Scott Wood
On Fri, Jan 25, 2008 at 06:11:57PM +0100, Jochen Friedrich wrote: > diff --git a/arch/powerpc/boot/dts/mpc866ads.dts > b/arch/powerpc/boot/dts/mpc866ads.dts > index daf9433..80c08bf 100644 > --- a/arch/powerpc/boot/dts/mpc866ads.dts > +++ b/arch/powerpc/boot/dts/mpc866ads.dts > @@ -169,6 +169,16

Re: [PATCHv3 2.6.25] i2c: adds support for i2c bus on Freescale CPM1/CPM2 controllers

2008-01-28 Thread Kumar Gala
On Jan 25, 2008, at 11:11 AM, Jochen Friedrich wrote: Using the port of 2.4 code from Vitaly Bordug [EMAIL PROTECTED] and the actual algorithm used by the i2c driver of the DBox code on cvs.tuxboc.org from Tmbinc, Gillem ([EMAIL PROTECTED]). Renamed i2c-rpx.c and i2c-algo-8xx.c to

Re: [PATCHv3 2.6.25] i2c: adds support for i2c bus on Freescale CPM1/CPM2 controllers

2008-01-28 Thread Bryan Wu
On Jan 26, 2008 1:11 AM, Jochen Friedrich [EMAIL PROTECTED] wrote: Using the port of 2.4 code from Vitaly Bordug [EMAIL PROTECTED] and the actual algorithm used by the i2c driver of the DBox code on cvs.tuxboc.org from Tmbinc, Gillem ([EMAIL PROTECTED]). Renamed i2c-rpx.c and i2c-algo-8xx.c to

Re: [PATCHv3 2.6.25] i2c: adds support for i2c bus on Freescale CPM1/CPM2 controllers

2008-01-28 Thread Scott Wood
On Fri, Jan 25, 2008 at 06:11:57PM +0100, Jochen Friedrich wrote: diff --git a/arch/powerpc/boot/dts/mpc866ads.dts b/arch/powerpc/boot/dts/mpc866ads.dts index daf9433..80c08bf 100644 --- a/arch/powerpc/boot/dts/mpc866ads.dts +++ b/arch/powerpc/boot/dts/mpc866ads.dts @@ -169,6 +169,16 @@

Re: [PATCHv3 2.6.25] i2c: adds support for i2c bus on Freescale CPM1/CPM2 controllers

2008-01-28 Thread Jochen Friedrich
Hi Bryan, + + /* register new adapter to i2c module... */ + + result = i2c_add_adapter(cpm-adap); As I was pointed before, please use the new style i2c driver interface:

[PATCHv3 2.6.25] i2c: adds support for i2c bus on Freescale CPM1/CPM2 controllers

2008-01-25 Thread Jochen Friedrich
Using the port of 2.4 code from Vitaly Bordug <[EMAIL PROTECTED]> and the actual algorithm used by the i2c driver of the DBox code on cvs.tuxboc.org from Tmbinc, Gillem ([EMAIL PROTECTED]). Renamed i2c-rpx.c and i2c-algo-8xx.c to i2c-cpm.c and converted the driver to an of_platform_driver.

[PATCHv3 2.6.25] i2c: adds support for i2c bus on Freescale CPM1/CPM2 controllers

2008-01-25 Thread Jochen Friedrich
Using the port of 2.4 code from Vitaly Bordug [EMAIL PROTECTED] and the actual algorithm used by the i2c driver of the DBox code on cvs.tuxboc.org from Tmbinc, Gillem ([EMAIL PROTECTED]). Renamed i2c-rpx.c and i2c-algo-8xx.c to i2c-cpm.c and converted the driver to an of_platform_driver.