Re: [PATCHv4 09/10] mm: implement split page table lock for PMD level

2013-10-04 Thread Peter Zijlstra
On Thu, Oct 03, 2013 at 04:11:09PM -0700, Andrew Morton wrote: > On Fri, 27 Sep 2013 16:16:26 +0300 "Kirill A. Shutemov" > wrote: > > > The basic idea is the same as with PTE level: the lock is embedded into > > struct page of table's page. > > > > We can't use mm->pmd_huge_pte to store

Re: [PATCHv4 09/10] mm: implement split page table lock for PMD level

2013-10-04 Thread Peter Zijlstra
On Thu, Oct 03, 2013 at 04:11:09PM -0700, Andrew Morton wrote: On Fri, 27 Sep 2013 16:16:26 +0300 Kirill A. Shutemov kirill.shute...@linux.intel.com wrote: The basic idea is the same as with PTE level: the lock is embedded into struct page of table's page. We can't use

Re: [PATCHv4 09/10] mm: implement split page table lock for PMD level

2013-10-03 Thread Kirill A. Shutemov
Andrew Morton wrote: > On Fri, 27 Sep 2013 16:16:26 +0300 "Kirill A. Shutemov" > wrote: > > > The basic idea is the same as with PTE level: the lock is embedded into > > struct page of table's page. > > > > We can't use mm->pmd_huge_pte to store pgtables for THP, since we don't > > take

Re: [PATCHv4 09/10] mm: implement split page table lock for PMD level

2013-10-03 Thread Andrew Morton
On Fri, 27 Sep 2013 16:16:26 +0300 "Kirill A. Shutemov" wrote: > The basic idea is the same as with PTE level: the lock is embedded into > struct page of table's page. > > We can't use mm->pmd_huge_pte to store pgtables for THP, since we don't > take mm->page_table_lock anymore. Let's reuse

Re: [PATCHv4 09/10] mm: implement split page table lock for PMD level

2013-10-03 Thread Andrew Morton
On Fri, 27 Sep 2013 16:16:26 +0300 Kirill A. Shutemov kirill.shute...@linux.intel.com wrote: The basic idea is the same as with PTE level: the lock is embedded into struct page of table's page. We can't use mm-pmd_huge_pte to store pgtables for THP, since we don't take mm-page_table_lock

Re: [PATCHv4 09/10] mm: implement split page table lock for PMD level

2013-10-03 Thread Kirill A. Shutemov
Andrew Morton wrote: On Fri, 27 Sep 2013 16:16:26 +0300 Kirill A. Shutemov kirill.shute...@linux.intel.com wrote: The basic idea is the same as with PTE level: the lock is embedded into struct page of table's page. We can't use mm-pmd_huge_pte to store pgtables for THP, since we

[PATCHv4 09/10] mm: implement split page table lock for PMD level

2013-09-27 Thread Kirill A. Shutemov
The basic idea is the same as with PTE level: the lock is embedded into struct page of table's page. We can't use mm->pmd_huge_pte to store pgtables for THP, since we don't take mm->page_table_lock anymore. Let's reuse page->lru of table's page for that. pgtable_pmd_page_ctor() returns true, if

[PATCHv4 09/10] mm: implement split page table lock for PMD level

2013-09-27 Thread Kirill A. Shutemov
The basic idea is the same as with PTE level: the lock is embedded into struct page of table's page. We can't use mm-pmd_huge_pte to store pgtables for THP, since we don't take mm-page_table_lock anymore. Let's reuse page-lru of table's page for that. pgtable_pmd_page_ctor() returns true, if