Re: [PATCHv4 1/1] thermal: core: call thermal_zone_device_update() after mode update

2016-07-03 Thread Peter Feuerer
Hi, 23. Juni 2016 06:52 Uhr, "Darren Hart" schrieb: > On Wed, Jun 22, 2016 at 08:03:18AM -0700, Eduardo Valentin wrote: > >> Because several drivers do the following pattern: >> .set_mode() >> ... >> local_data->mode = new_mode; >> thermal_zone_device_update(tz); >> >>

Re: [PATCHv4 1/1] thermal: core: call thermal_zone_device_update() after mode update

2016-07-03 Thread Peter Feuerer
Hi, 23. Juni 2016 06:52 Uhr, "Darren Hart" schrieb: > On Wed, Jun 22, 2016 at 08:03:18AM -0700, Eduardo Valentin wrote: > >> Because several drivers do the following pattern: >> .set_mode() >> ... >> local_data->mode = new_mode; >> thermal_zone_device_update(tz); >> >> makes sense to simply do

Re: [PATCHv4 1/1] thermal: core: call thermal_zone_device_update() after mode update

2016-07-01 Thread Eduardo Valentin
On Wed, Jun 29, 2016 at 02:23:22PM +0800, Zhang Rui wrote: > Hi, Eduardo, > > as the locking patch set has not been in upstream yet, you should > either fold this fix into patch 02/15, or rebase your locking patch > series on top of this fix. I am folding into 02/15 and resending only the new

Re: [PATCHv4 1/1] thermal: core: call thermal_zone_device_update() after mode update

2016-07-01 Thread Eduardo Valentin
On Wed, Jun 29, 2016 at 02:23:22PM +0800, Zhang Rui wrote: > Hi, Eduardo, > > as the locking patch set has not been in upstream yet, you should > either fold this fix into patch 02/15, or rebase your locking patch > series on top of this fix. I am folding into 02/15 and resending only the new

Re: [PATCHv4 1/1] thermal: core: call thermal_zone_device_update() after mode update

2016-06-29 Thread Zhang Rui
Hi, Eduardo, as the locking patch set has not been in upstream yet, you should either fold this fix into patch 02/15, or rebase your locking patch series on top of this fix. thanks, rui On 三, 2016-06-22 at 08:03 -0700, Eduardo Valentin wrote: > Because several drivers do the following pattern:

Re: [PATCHv4 1/1] thermal: core: call thermal_zone_device_update() after mode update

2016-06-29 Thread Zhang Rui
Hi, Eduardo, as the locking patch set has not been in upstream yet, you should either fold this fix into patch 02/15, or rebase your locking patch series on top of this fix. thanks, rui On 三, 2016-06-22 at 08:03 -0700, Eduardo Valentin wrote: > Because several drivers do the following pattern:

Re: [PATCHv4 1/1] thermal: core: call thermal_zone_device_update() after mode update

2016-06-22 Thread Darren Hart
On Wed, Jun 22, 2016 at 08:03:18AM -0700, Eduardo Valentin wrote: > Because several drivers do the following pattern: > .set_mode() >... >local_data->mode = new_mode; >thermal_zone_device_update(tz); > > makes sense to simply do the thermal_zone_device_update() > in thermal core,

Re: [PATCHv4 1/1] thermal: core: call thermal_zone_device_update() after mode update

2016-06-22 Thread Darren Hart
On Wed, Jun 22, 2016 at 08:03:18AM -0700, Eduardo Valentin wrote: > Because several drivers do the following pattern: > .set_mode() >... >local_data->mode = new_mode; >thermal_zone_device_update(tz); > > makes sense to simply do the thermal_zone_device_update() > in thermal core,

Re: [PATCHv4 1/1] thermal: core: call thermal_zone_device_update() after mode update

2016-06-22 Thread Keerthy
On Wednesday 22 June 2016 08:33 PM, Eduardo Valentin wrote: Because several drivers do the following pattern: .set_mode() ... local_data->mode = new_mode; thermal_zone_device_update(tz); makes sense to simply do the thermal_zone_device_update() in thermal core, after setting the

Re: [PATCHv4 1/1] thermal: core: call thermal_zone_device_update() after mode update

2016-06-22 Thread Keerthy
On Wednesday 22 June 2016 08:33 PM, Eduardo Valentin wrote: Because several drivers do the following pattern: .set_mode() ... local_data->mode = new_mode; thermal_zone_device_update(tz); makes sense to simply do the thermal_zone_device_update() in thermal core, after setting the

[PATCHv4 1/1] thermal: core: call thermal_zone_device_update() after mode update

2016-06-22 Thread Eduardo Valentin
Because several drivers do the following pattern: .set_mode() ... local_data->mode = new_mode; thermal_zone_device_update(tz); makes sense to simply do the thermal_zone_device_update() in thermal core, after setting the new mode. Also, this patch also remove deadlocks on drivers that

[PATCHv4 1/1] thermal: core: call thermal_zone_device_update() after mode update

2016-06-22 Thread Eduardo Valentin
Because several drivers do the following pattern: .set_mode() ... local_data->mode = new_mode; thermal_zone_device_update(tz); makes sense to simply do the thermal_zone_device_update() in thermal core, after setting the new mode. Also, this patch also remove deadlocks on drivers that