Re: [PATCHv5] gpio: Remove VLA from gpiolib

2018-05-15 Thread Phil Reid
On 15/05/2018 15:10, Geert Uytterhoeven wrote: Hi Laura, On Tue, May 15, 2018 at 12:49 AM, Laura Abbott wrote: On 04/20/2018 02:02 AM, Geert Uytterhoeven wrote: On Fri, Apr 13, 2018 at 11:24 PM, Laura Abbott wrote: The new challenge is to remove VLAs from the kernel (see https://lkml.org/lk

Re: [PATCHv5] gpio: Remove VLA from gpiolib

2018-05-15 Thread Geert Uytterhoeven
Hi Laura, On Tue, May 15, 2018 at 12:49 AM, Laura Abbott wrote: > On 04/20/2018 02:02 AM, Geert Uytterhoeven wrote: >> On Fri, Apr 13, 2018 at 11:24 PM, Laura Abbott wrote: >>> The new challenge is to remove VLAs from the kernel >>> (see https://lkml.org/lkml/2018/3/7/621) to eventually >>> turn

Re: [PATCHv5] gpio: Remove VLA from gpiolib

2018-05-14 Thread Laura Abbott
On 04/20/2018 02:02 AM, Geert Uytterhoeven wrote: Hi Laura, Thanks for your patch! On Fri, Apr 13, 2018 at 11:24 PM, Laura Abbott wrote: The new challenge is to remove VLAs from the kernel (see https://lkml.org/lkml/2018/3/7/621) to eventually turn on -Wvla. Using a kmalloc array is the easy

Re: [PATCHv5] gpio: Remove VLA from gpiolib

2018-04-20 Thread Geert Uytterhoeven
Hi Laura, Thanks for your patch! On Fri, Apr 13, 2018 at 11:24 PM, Laura Abbott wrote: > The new challenge is to remove VLAs from the kernel > (see https://lkml.org/lkml/2018/3/7/621) to eventually > turn on -Wvla. > > Using a kmalloc array is the easy way to fix this but kmalloc is still > more

Re: [PATCHv5] gpio: Remove VLA from gpiolib

2018-04-15 Thread Phil Reid
On 16/04/2018 13:19, Phil Reid wrote: G'day Laura, One more comment. On 16/04/2018 12:41, Phil Reid wrote: G'day Laura, On 14/04/2018 05:24, Laura Abbott wrote: The new challenge is to remove VLAs from the kernel (see https://lkml.org/lkml/2018/3/7/621) to eventually turn on -Wvla. Using a k

Re: [PATCHv5] gpio: Remove VLA from gpiolib

2018-04-15 Thread Phil Reid
G'day Laura, One more comment. On 16/04/2018 12:41, Phil Reid wrote: G'day Laura, On 14/04/2018 05:24, Laura Abbott wrote: The new challenge is to remove VLAs from the kernel (see https://lkml.org/lkml/2018/3/7/621) to eventually turn on -Wvla. Using a kmalloc array is the easy way to fix thi

Re: [PATCHv5] gpio: Remove VLA from gpiolib

2018-04-15 Thread Phil Reid
G'day Laura, On 14/04/2018 05:24, Laura Abbott wrote: The new challenge is to remove VLAs from the kernel (see https://lkml.org/lkml/2018/3/7/621) to eventually turn on -Wvla. Using a kmalloc array is the easy way to fix this but kmalloc is still more expensive than stack allocation. Introduce

[PATCHv5] gpio: Remove VLA from gpiolib

2018-04-13 Thread Laura Abbott
The new challenge is to remove VLAs from the kernel (see https://lkml.org/lkml/2018/3/7/621) to eventually turn on -Wvla. Using a kmalloc array is the easy way to fix this but kmalloc is still more expensive than stack allocation. Introduce a fast path with a fixed size stack array to cover most