Re: [PATCHv5 4/4] thermal: exynos: Remove duplicate code when reading triminfo register of Exynos5440

2014-09-02 Thread Chanwoo Choi
Dear Eduardo, On 08/30/2014 04:28 AM, Eduardo Valentin wrote: > Chanwoo, > > On Fri, Aug 29, 2014 at 08:50:41AM +0900, Chanwoo Choi wrote: >> Dear Eduardo, >> >> On 08/28/2014 11:53 PM, Eduardo Valentin wrote: >>> On Thu, Aug 28, 2014 at 01:25:14PM +0900, Chanwoo Choi wrote: Dear Eduardo,

Re: [PATCHv5 4/4] thermal: exynos: Remove duplicate code when reading triminfo register of Exynos5440

2014-09-02 Thread Eduardo Valentin
Chanwoo, On Fri, Aug 29, 2014 at 08:50:41AM +0900, Chanwoo Choi wrote: > Dear Eduardo, > > On 08/28/2014 11:53 PM, Eduardo Valentin wrote: > > On Thu, Aug 28, 2014 at 01:25:14PM +0900, Chanwoo Choi wrote: > >> Dear Eduardo, > >> > >> This patch is wrong. It is my mistake. > >> > >> Please ignore

Re: [PATCHv5 4/4] thermal: exynos: Remove duplicate code when reading triminfo register of Exynos5440

2014-09-02 Thread Eduardo Valentin
Chanwoo, On Fri, Aug 29, 2014 at 08:50:41AM +0900, Chanwoo Choi wrote: Dear Eduardo, On 08/28/2014 11:53 PM, Eduardo Valentin wrote: On Thu, Aug 28, 2014 at 01:25:14PM +0900, Chanwoo Choi wrote: Dear Eduardo, This patch is wrong. It is my mistake. Please ignore only this patch

Re: [PATCHv5 4/4] thermal: exynos: Remove duplicate code when reading triminfo register of Exynos5440

2014-09-02 Thread Chanwoo Choi
Dear Eduardo, On 08/30/2014 04:28 AM, Eduardo Valentin wrote: Chanwoo, On Fri, Aug 29, 2014 at 08:50:41AM +0900, Chanwoo Choi wrote: Dear Eduardo, On 08/28/2014 11:53 PM, Eduardo Valentin wrote: On Thu, Aug 28, 2014 at 01:25:14PM +0900, Chanwoo Choi wrote: Dear Eduardo, This patch is

Re: [PATCHv5 4/4] thermal: exynos: Remove duplicate code when reading triminfo register of Exynos5440

2014-08-28 Thread Chanwoo Choi
Dear Eduardo, On 08/28/2014 11:53 PM, Eduardo Valentin wrote: > On Thu, Aug 28, 2014 at 01:25:14PM +0900, Chanwoo Choi wrote: >> Dear Eduardo, >> >> This patch is wrong. It is my mistake. >> >> Please ignore only this patch because >> the offset calculation of 'case 0' is different from 'case 2'.

Re: [PATCHv5 4/4] thermal: exynos: Remove duplicate code when reading triminfo register of Exynos5440

2014-08-28 Thread Eduardo Valentin
On Thu, Aug 28, 2014 at 01:25:14PM +0900, Chanwoo Choi wrote: > Dear Eduardo, > > This patch is wrong. It is my mistake. > > Please ignore only this patch because > the offset calculation of 'case 0' is different from 'case 2'. Do patches 1 - 3 are still correct? Patch 1, from Barlomiej, seams

Re: [PATCHv5 4/4] thermal: exynos: Remove duplicate code when reading triminfo register of Exynos5440

2014-08-28 Thread Eduardo Valentin
On Thu, Aug 28, 2014 at 01:25:14PM +0900, Chanwoo Choi wrote: Dear Eduardo, This patch is wrong. It is my mistake. Please ignore only this patch because the offset calculation of 'case 0' is different from 'case 2'. Do patches 1 - 3 are still correct? Patch 1, from Barlomiej, seams to be

Re: [PATCHv5 4/4] thermal: exynos: Remove duplicate code when reading triminfo register of Exynos5440

2014-08-28 Thread Chanwoo Choi
Dear Eduardo, On 08/28/2014 11:53 PM, Eduardo Valentin wrote: On Thu, Aug 28, 2014 at 01:25:14PM +0900, Chanwoo Choi wrote: Dear Eduardo, This patch is wrong. It is my mistake. Please ignore only this patch because the offset calculation of 'case 0' is different from 'case 2'. Do

Re: [PATCHv5 4/4] thermal: exynos: Remove duplicate code when reading triminfo register of Exynos5440

2014-08-27 Thread Chanwoo Choi
Dear Eduardo, This patch is wrong. It is my mistake. Please ignore only this patch because the offset calculation of 'case 0' is different from 'case 2'. Best Regards, Chanwoo Choi On 08/26/2014 10:31 AM, Chanwoo Choi wrote: > This patch remove simply duplicate code when reading triminfo

Re: [PATCHv5 4/4] thermal: exynos: Remove duplicate code when reading triminfo register of Exynos5440

2014-08-27 Thread Chanwoo Choi
Dear Eduardo, This patch is wrong. It is my mistake. Please ignore only this patch because the offset calculation of 'case 0' is different from 'case 2'. Best Regards, Chanwoo Choi On 08/26/2014 10:31 AM, Chanwoo Choi wrote: This patch remove simply duplicate code when reading triminfo

[PATCHv5 4/4] thermal: exynos: Remove duplicate code when reading triminfo register of Exynos5440

2014-08-25 Thread Chanwoo Choi
This patch remove simply duplicate code when reading triminfo register of Exynos5440. Signed-off-by: Chanwoo Choi Acked-by: Kyungmin Park Cc: Zhang Rui Cc: Eduardo Valentin Cc: Amit Daniel Kachhap Reviewed-by: Amit Daniel Kachhap --- drivers/thermal/samsung/exynos_tmu.c | 4 +--- 1 file

[PATCHv5 4/4] thermal: exynos: Remove duplicate code when reading triminfo register of Exynos5440

2014-08-25 Thread Chanwoo Choi
This patch remove simply duplicate code when reading triminfo register of Exynos5440. Signed-off-by: Chanwoo Choi cw00.c...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Zhang Rui rui.zh...@intel.com Cc: Eduardo Valentin edubez...@gmail.com Cc: Amit Daniel Kachhap