Re: [PULL] virtio/vhost: cross endian support

2015-07-07 Thread Michael S. Tsirkin
On Tue, Jul 07, 2015 at 06:36:53PM +0200, Thomas Huth wrote: > On Thu, 2 Jul 2015 11:32:52 +0200 > "Michael S. Tsirkin" wrote: > > > On Thu, Jul 02, 2015 at 11:12:56AM +0200, Greg Kurz wrote: > > > On Thu, 2 Jul 2015 08:01:28 +0200 > > > "Michael S. Tsirkin" wrote: > ... > > > > Yea, well - supp

Re: [PULL] virtio/vhost: cross endian support

2015-07-07 Thread Thomas Huth
On Thu, 2 Jul 2015 11:32:52 +0200 "Michael S. Tsirkin" wrote: > On Thu, Jul 02, 2015 at 11:12:56AM +0200, Greg Kurz wrote: > > On Thu, 2 Jul 2015 08:01:28 +0200 > > "Michael S. Tsirkin" wrote: ... > > > Yea, well - support for legacy BE guests on the new LE hosts is > > > exactly the motivation

Re: [PULL] virtio/vhost: cross endian support

2015-07-03 Thread Linus Torvalds
On Fri, Jul 3, 2015 at 12:59 AM, Michael S. Tsirkin wrote: > > Linus, could you please clarify whether making the > feature depend on the cross-endian guest support > would address your comment, and whether you think > this can be merged as is, and the dependency added > after -rc1? I'll take it.

Re: [PULL] virtio/vhost: cross endian support

2015-07-03 Thread Michael S. Tsirkin
On Thu, Jul 02, 2015 at 08:01:28AM +0200, Michael S. Tsirkin wrote: > On Wed, Jul 01, 2015 at 12:02:50PM -0700, Linus Torvalds wrote: > > On Wed, Jul 1, 2015 at 2:31 AM, Michael S. Tsirkin wrote: > > > virtio/vhost: cross endian support > > > > Ugh. Does this really have to be dynamic? > > > > C

Re: [PULL] virtio/vhost: cross endian support

2015-07-02 Thread Michael S. Tsirkin
On Thu, Jul 02, 2015 at 11:12:56AM +0200, Greg Kurz wrote: > On Thu, 2 Jul 2015 08:01:28 +0200 > "Michael S. Tsirkin" wrote: > > > On Wed, Jul 01, 2015 at 12:02:50PM -0700, Linus Torvalds wrote: > > > On Wed, Jul 1, 2015 at 2:31 AM, Michael S. Tsirkin > > > wrote: > > > > virtio/vhost: cross en

Re: [PULL] virtio/vhost: cross endian support

2015-07-02 Thread Greg Kurz
On Thu, 2 Jul 2015 08:01:28 +0200 "Michael S. Tsirkin" wrote: > On Wed, Jul 01, 2015 at 12:02:50PM -0700, Linus Torvalds wrote: > > On Wed, Jul 1, 2015 at 2:31 AM, Michael S. Tsirkin wrote: > > > virtio/vhost: cross endian support > > > > Ugh. Does this really have to be dynamic? > > > > Can't

Re: [PULL] virtio/vhost: cross endian support

2015-07-01 Thread Michael S. Tsirkin
On Wed, Jul 01, 2015 at 12:03:59PM -0700, Linus Torvalds wrote: > On Wed, Jul 1, 2015 at 12:02 PM, Linus Torvalds > wrote: > > > > Doing a unconditional byte swap is faster and simpler than the crazy > > conditionals. > > Unconditional endianness not only makes for simpler and faster code, > it a

Re: [PULL] virtio/vhost: cross endian support

2015-07-01 Thread Michael S. Tsirkin
On Wed, Jul 01, 2015 at 12:02:50PM -0700, Linus Torvalds wrote: > On Wed, Jul 1, 2015 at 2:31 AM, Michael S. Tsirkin wrote: > > virtio/vhost: cross endian support > > Ugh. Does this really have to be dynamic? > > Can't virtio do the sane thing, and just use a _fixed_ endianness? > > Doing a unc

Re: [PULL] virtio/vhost: cross endian support

2015-07-01 Thread Linus Torvalds
On Wed, Jul 1, 2015 at 12:02 PM, Linus Torvalds wrote: > > Doing a unconditional byte swap is faster and simpler than the crazy > conditionals. Unconditional endianness not only makes for simpler and faster code, it also ends up being easier to debug and add things like type annotations for spars

Re: [PULL] virtio/vhost: cross endian support

2015-07-01 Thread Linus Torvalds
On Wed, Jul 1, 2015 at 2:31 AM, Michael S. Tsirkin wrote: > virtio/vhost: cross endian support Ugh. Does this really have to be dynamic? Can't virtio do the sane thing, and just use a _fixed_ endianness? Doing a unconditional byte swap is faster and simpler than the crazy conditionals. That's t

[PULL] virtio/vhost: cross endian support

2015-07-01 Thread Michael S. Tsirkin
The following changes since commit 8a7b19d8b542b87bccc3eaaf81dcc90a5ca48aea: include/uapi/linux/virtio_balloon.h: include linux/virtio_types.h (2015-06-01 15:46:54 +0200) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus for