Re: [Patch](memory hotplug) Make kmem_cache_node for SLUB on memory online to avoid panic(take 3)

2007-10-18 Thread Yasunori Goto
> On Thu, 18 Oct 2007 12:25:37 +0900 Yasunori Goto <[EMAIL PROTECTED]> wrote: > > > > > This patch fixes panic due to access NULL pointer > > of kmem_cache_node at discard_slab() after memory online. > > > > When memory online is called, kmem_cache_nodes are created for > > all SLUBs for new

Re: [Patch](memory hotplug) Make kmem_cache_node for SLUB on memory online to avoid panic(take 3)

2007-10-18 Thread Christoph Lameter
On Thu, 18 Oct 2007, Andrew Morton wrote: > > Slab brings up a per node structure when the corresponding cpu is brought > > up. That was sufficient as long as we did not have any memoryless nodes. > > Now we may have to fix some things over there as well. > > Is there amy point? Our time

Re: [Patch](memory hotplug) Make kmem_cache_node for SLUB on memory online to avoid panic(take 3)

2007-10-18 Thread Yasunori Goto
> On Wed, 17 Oct 2007 23:25:58 -0700 (PDT) Christoph Lameter <[EMAIL > PROTECTED]> wrote: > > > > So that's slub. Does slab already have this functionality or are you > > > not bothering to maintain slab in this area? > > > > Slab brings up a per node structure when the corresponding cpu is

Re: [Patch](memory hotplug) Make kmem_cache_node for SLUB on memory online to avoid panic(take 3)

2007-10-18 Thread Andrew Morton
On Wed, 17 Oct 2007 23:25:58 -0700 (PDT) Christoph Lameter <[EMAIL PROTECTED]> wrote: > > So that's slub. Does slab already have this functionality or are you > > not bothering to maintain slab in this area? > > Slab brings up a per node structure when the corresponding cpu is brought > up.

Re: [Patch](memory hotplug) Make kmem_cache_node for SLUB on memory online to avoid panic(take 3)

2007-10-18 Thread Christoph Lameter
On Wed, 17 Oct 2007, Andrew Morton wrote: > > +#if defined(CONFIG_NUMA) && defined(CONFIG_MEMORY_HOTPLUG) > > hm. There should be no linkage between memory hotpluggability and > NUMA, surely? NUMA support in the slab allocators requires allocation of per node structures. The per node

Re: [Patch](memory hotplug) Make kmem_cache_node for SLUB on memory online to avoid panic(take 3)

2007-10-18 Thread Christoph Lameter
On Wed, 17 Oct 2007, Andrew Morton wrote: +#if defined(CONFIG_NUMA) defined(CONFIG_MEMORY_HOTPLUG) hm. There should be no linkage between memory hotpluggability and NUMA, surely? NUMA support in the slab allocators requires allocation of per node structures. The per node structures are

Re: [Patch](memory hotplug) Make kmem_cache_node for SLUB on memory online to avoid panic(take 3)

2007-10-18 Thread Andrew Morton
On Wed, 17 Oct 2007 23:25:58 -0700 (PDT) Christoph Lameter [EMAIL PROTECTED] wrote: So that's slub. Does slab already have this functionality or are you not bothering to maintain slab in this area? Slab brings up a per node structure when the corresponding cpu is brought up. That was

Re: [Patch](memory hotplug) Make kmem_cache_node for SLUB on memory online to avoid panic(take 3)

2007-10-18 Thread Yasunori Goto
On Wed, 17 Oct 2007 23:25:58 -0700 (PDT) Christoph Lameter [EMAIL PROTECTED] wrote: So that's slub. Does slab already have this functionality or are you not bothering to maintain slab in this area? Slab brings up a per node structure when the corresponding cpu is brought up.

Re: [Patch](memory hotplug) Make kmem_cache_node for SLUB on memory online to avoid panic(take 3)

2007-10-18 Thread Christoph Lameter
On Thu, 18 Oct 2007, Andrew Morton wrote: Slab brings up a per node structure when the corresponding cpu is brought up. That was sufficient as long as we did not have any memoryless nodes. Now we may have to fix some things over there as well. Is there amy point? Our time would be

Re: [Patch](memory hotplug) Make kmem_cache_node for SLUB on memory online to avoid panic(take 3)

2007-10-18 Thread Yasunori Goto
On Thu, 18 Oct 2007 12:25:37 +0900 Yasunori Goto [EMAIL PROTECTED] wrote: This patch fixes panic due to access NULL pointer of kmem_cache_node at discard_slab() after memory online. When memory online is called, kmem_cache_nodes are created for all SLUBs for new node whose memory

Re: [Patch](memory hotplug) Make kmem_cache_node for SLUB on memory online to avoid panic(take 3)

2007-10-17 Thread Andrew Morton
On Thu, 18 Oct 2007 12:25:37 +0900 Yasunori Goto <[EMAIL PROTECTED]> wrote: > > This patch fixes panic due to access NULL pointer > of kmem_cache_node at discard_slab() after memory online. > > When memory online is called, kmem_cache_nodes are created for > all SLUBs for new node whose memory

[Patch](memory hotplug) Make kmem_cache_node for SLUB on memory online to avoid panic(take 3)

2007-10-17 Thread Yasunori Goto
This patch fixes panic due to access NULL pointer of kmem_cache_node at discard_slab() after memory online. When memory online is called, kmem_cache_nodes are created for all SLUBs for new node whose memory are available. slab_mem_going_online_callback() is called to make kmem_cache_node() in

[Patch](memory hotplug) Make kmem_cache_node for SLUB on memory online to avoid panic(take 3)

2007-10-17 Thread Yasunori Goto
This patch fixes panic due to access NULL pointer of kmem_cache_node at discard_slab() after memory online. When memory online is called, kmem_cache_nodes are created for all SLUBs for new node whose memory are available. slab_mem_going_online_callback() is called to make kmem_cache_node() in

Re: [Patch](memory hotplug) Make kmem_cache_node for SLUB on memory online to avoid panic(take 3)

2007-10-17 Thread Andrew Morton
On Thu, 18 Oct 2007 12:25:37 +0900 Yasunori Goto [EMAIL PROTECTED] wrote: This patch fixes panic due to access NULL pointer of kmem_cache_node at discard_slab() after memory online. When memory online is called, kmem_cache_nodes are created for all SLUBs for new node whose memory are