Re: [Patch] mm/sparse.c: Improve the error handling for sparse_add_one_section()

Hi, Cong-san. > ms->section_mem_map |= SECTION_MARKED_PRESENT; > > ret = sparse_init_one_section(ms, section_nr, memmap, usemap); > > out: > pgdat_resize_unlock(pgdat, ); > - if (ret <= 0) > - __kfree_section_memmap(memmap, nr_pages); > + > return ret;

Re: [Patch] mm/sparse.c: Improve the error handling for sparse_add_one_section()

Hi, Cong-san. ms-section_mem_map |= SECTION_MARKED_PRESENT; ret = sparse_init_one_section(ms, section_nr, memmap, usemap); out: pgdat_resize_unlock(pgdat, flags); - if (ret = 0) - __kfree_section_memmap(memmap, nr_pages); + return ret; }

[Patch] mm/sparse.c: Improve the error handling for sparse_add_one_section()

Improve the error handling for mm/sparse.c::sparse_add_one_section(). And I see no reason to check 'usemap' until holding the 'pgdat_resize_lock'. If someone knows, please let me know. Note! This patch is _not_ tested yet, since it seems that I can't configure sparse memory for i386 box. Sorry

[Patch] mm/sparse.c: Improve the error handling for sparse_add_one_section()

Improve the error handling for mm/sparse.c::sparse_add_one_section(). And I see no reason to check 'usemap' until holding the 'pgdat_resize_lock'. If someone knows, please let me know. Note! This patch is _not_ tested yet, since it seems that I can't configure sparse memory for i386 box. Sorry