Re: [Patch 1/2] Trace code and documentation (resend)

2007-09-24 Thread David Wilder
Christoph Hellwig wrote: On Mon, Sep 24, 2007 at 08:38:34AM -0700, David Wilder wrote: NACK, don't put code into Documentation/. Put it into kernel as it's actually useful kernel code. Are you suggesting moving the example code into kernel? Or complaining about example code in

Re: [Patch 1/2] Trace code and documentation (resend)

2007-09-24 Thread Randy Dunlap
On Mon, 24 Sep 2007 16:41:14 +0100 Christoph Hellwig wrote: > On Mon, Sep 24, 2007 at 08:38:34AM -0700, David Wilder wrote: > > >NACK, don't put code into Documentation/. Put it into kernel as it's > > >actually useful kernel code. > > > > Are you suggesting moving the example code into

Re: [Patch 1/2] Trace code and documentation (resend)

2007-09-24 Thread Christoph Hellwig
On Mon, Sep 24, 2007 at 08:38:34AM -0700, David Wilder wrote: > >NACK, don't put code into Documentation/. Put it into kernel as it's > >actually useful kernel code. > > Are you suggesting moving the example code into kernel? Or complaining > about example code in /Documentation? Both.

Re: [Patch 1/2] Trace code and documentation (resend)

2007-09-24 Thread David Wilder
Christoph Hellwig wrote: On Fri, Sep 21, 2007 at 09:23:28PM -0700, David J. Wilder wrote: My last posting was mangled by my mailer. I hope this one is better. Also corrected Randy's concerns. Please see previous posting for more information: http://lkml.org/lkml/2007/9/19/4 (PATCH 0/2) Note:

Re: [Patch 1/2] Trace code and documentation (resend)

2007-09-24 Thread David Wilder
Christoph Hellwig wrote: On Fri, Sep 21, 2007 at 09:23:28PM -0700, David J. Wilder wrote: My last posting was mangled by my mailer. I hope this one is better. Also corrected Randy's concerns. Please see previous posting for more information: http://lkml.org/lkml/2007/9/19/4 (PATCH 0/2) Note:

Re: [Patch 1/2] Trace code and documentation (resend)

2007-09-24 Thread Christoph Hellwig
On Mon, Sep 24, 2007 at 08:38:34AM -0700, David Wilder wrote: NACK, don't put code into Documentation/. Put it into kernel as it's actually useful kernel code. Are you suggesting moving the example code into kernel? Or complaining about example code in /Documentation? Both. example

Re: [Patch 1/2] Trace code and documentation (resend)

2007-09-24 Thread Randy Dunlap
On Mon, 24 Sep 2007 16:41:14 +0100 Christoph Hellwig wrote: On Mon, Sep 24, 2007 at 08:38:34AM -0700, David Wilder wrote: NACK, don't put code into Documentation/. Put it into kernel as it's actually useful kernel code. Are you suggesting moving the example code into kernel? Or

Re: [Patch 1/2] Trace code and documentation (resend)

2007-09-24 Thread David Wilder
Christoph Hellwig wrote: On Mon, Sep 24, 2007 at 08:38:34AM -0700, David Wilder wrote: NACK, don't put code into Documentation/. Put it into kernel as it's actually useful kernel code. Are you suggesting moving the example code into kernel? Or complaining about example code in

Re: [Patch 1/2] Trace code and documentation (resend)

2007-09-22 Thread Christoph Hellwig
On Fri, Sep 21, 2007 at 09:23:28PM -0700, David J. Wilder wrote: > My last posting was mangled by my mailer. I hope this one is better. > Also corrected Randy's concerns. > > Please see previous posting for more information: > http://lkml.org/lkml/2007/9/19/4 (PATCH 0/2) > > Note: this patch

Re: [Patch 1/2] Trace code and documentation (resend)

2007-09-22 Thread Christoph Hellwig
On Fri, Sep 21, 2007 at 09:23:28PM -0700, David J. Wilder wrote: My last posting was mangled by my mailer. I hope this one is better. Also corrected Randy's concerns. Please see previous posting for more information: http://lkml.org/lkml/2007/9/19/4 (PATCH 0/2) Note: this patch requires

[Patch 1/2] Trace code and documentation (resend)

2007-09-21 Thread David J. Wilder
My last posting was mangled by my mailer. I hope this one is better. Also corrected Randy's concerns. Please see previous posting for more information: http://lkml.org/lkml/2007/9/19/4 (PATCH 0/2) Note: this patch requires "[Patch 2/2] Relay reset consumed" is applied. -

[Patch 1/2] Trace code and documentation (resend)

2007-09-21 Thread David J. Wilder
My last posting was mangled by my mailer. I hope this one is better. Also corrected Randy's concerns. Please see previous posting for more information: http://lkml.org/lkml/2007/9/19/4 (PATCH 0/2) Note: this patch requires [Patch 2/2] Relay reset consumed is applied. -start of