Re: [Patch v2 2/7] Regulator: DA9055 Regulator driver

2012-10-10 Thread Ashish Jangam
On Wed, 2012-10-10 at 12:56 +0900, Mark Brown wrote: > On Tue, Oct 09, 2012 at 04:30:16PM +0530, Ashish Jangam wrote: > > On Tue, 2012-10-09 at 15:37 +0530, Mark Brown wrote: > > > On Mon, Oct 08, 2012 at 07:00:39PM +0530, Ashish Jangam wrote: > > > > > + /* Set the GPIO I/P pin for

Re: [Patch v2 2/7] Regulator: DA9055 Regulator driver

2012-10-10 Thread Ashish Jangam
On Wed, 2012-10-10 at 12:56 +0900, Mark Brown wrote: On Tue, Oct 09, 2012 at 04:30:16PM +0530, Ashish Jangam wrote: On Tue, 2012-10-09 at 15:37 +0530, Mark Brown wrote: On Mon, Oct 08, 2012 at 07:00:39PM +0530, Ashish Jangam wrote: + /* Set the GPIO I/P pin for

Re: [Patch v2 2/7] Regulator: DA9055 Regulator driver

2012-10-09 Thread Mark Brown
On Tue, Oct 09, 2012 at 04:30:16PM +0530, Ashish Jangam wrote: > On Tue, 2012-10-09 at 15:37 +0530, Mark Brown wrote: > > On Mon, Oct 08, 2012 at 07:00:39PM +0530, Ashish Jangam wrote: > > > + /* Set the GPIO I/P pin for controlling the regulator state. */ > > > + ret =

Re: [Patch v2 2/7] Regulator: DA9055 Regulator driver

2012-10-09 Thread Ashish Jangam
On Tue, 2012-10-09 at 15:37 +0530, Mark Brown wrote: > On Mon, Oct 08, 2012 at 07:00:39PM +0530, Ashish Jangam wrote: > > Mostly OK, but there's a few issues including yet more reimplementation > of framework features. > > > +static int da9055_list_voltage(struct regulator_dev *rdev, > > +

Re: [Patch v2 2/7] Regulator: DA9055 Regulator driver

2012-10-09 Thread Mark Brown
On Mon, Oct 08, 2012 at 07:00:39PM +0530, Ashish Jangam wrote: Mostly OK, but there's a few issues including yet more reimplementation of framework features. > +static int da9055_list_voltage(struct regulator_dev *rdev, > + unsigned int selector) > +{ > + struct

Re: [Patch v2 2/7] Regulator: DA9055 Regulator driver

2012-10-09 Thread Mark Brown
On Mon, Oct 08, 2012 at 07:00:39PM +0530, Ashish Jangam wrote: Mostly OK, but there's a few issues including yet more reimplementation of framework features. +static int da9055_list_voltage(struct regulator_dev *rdev, + unsigned int selector) +{ + struct

Re: [Patch v2 2/7] Regulator: DA9055 Regulator driver

2012-10-09 Thread Ashish Jangam
On Tue, 2012-10-09 at 15:37 +0530, Mark Brown wrote: On Mon, Oct 08, 2012 at 07:00:39PM +0530, Ashish Jangam wrote: Mostly OK, but there's a few issues including yet more reimplementation of framework features. +static int da9055_list_voltage(struct regulator_dev *rdev, +

Re: [Patch v2 2/7] Regulator: DA9055 Regulator driver

2012-10-09 Thread Mark Brown
On Tue, Oct 09, 2012 at 04:30:16PM +0530, Ashish Jangam wrote: On Tue, 2012-10-09 at 15:37 +0530, Mark Brown wrote: On Mon, Oct 08, 2012 at 07:00:39PM +0530, Ashish Jangam wrote: + /* Set the GPIO I/P pin for controlling the regulator state. */ + ret =

[Patch v2 2/7] Regulator: DA9055 Regulator driver

2012-10-08 Thread Ashish Jangam
This is the Regulator patch for the DA9055 PMIC and has got dependency on the DA9055 MFD core. This patch support all of the DA9055 regulators. The output voltages are fully programmable through I2C interface only. The platform data with regulation constraints is passed down from the board to the

[Patch v2 2/7] Regulator: DA9055 Regulator driver

2012-10-08 Thread Ashish Jangam
This is the Regulator patch for the DA9055 PMIC and has got dependency on the DA9055 MFD core. This patch support all of the DA9055 regulators. The output voltages are fully programmable through I2C interface only. The platform data with regulation constraints is passed down from the board to the