Re: [Pv-drivers] [vmw_vmci 11/11] Apply the header code to make VMCI build

2012-07-28 Thread Dmitry Torokhov
On Sat, Jul 28, 2012 at 12:55:35PM -0700, Greg KH wrote: > On Fri, Jul 27, 2012 at 01:29:27PM -0700, Dmitry Torokhov wrote: > > On Fri, Jul 27, 2012 at 11:16:39AM -0700, Greg KH wrote: > > > On Fri, Jul 27, 2012 at 10:20:43AM -0700, Andrew Stiegmann wrote: > > > > > The kernel style is to use

Re: [Pv-drivers] [vmw_vmci 11/11] Apply the header code to make VMCI build

2012-07-28 Thread Greg KH
On Fri, Jul 27, 2012 at 01:29:27PM -0700, Dmitry Torokhov wrote: > On Fri, Jul 27, 2012 at 11:16:39AM -0700, Greg KH wrote: > > On Fri, Jul 27, 2012 at 10:20:43AM -0700, Andrew Stiegmann wrote: > > > > The kernel style is to use lower_case for everything. > > > > So this would become: > > > > > >

Re: [Pv-drivers] [vmw_vmci 11/11] Apply the header code to make VMCI build

2012-07-28 Thread Greg KH
On Fri, Jul 27, 2012 at 01:29:27PM -0700, Dmitry Torokhov wrote: On Fri, Jul 27, 2012 at 11:16:39AM -0700, Greg KH wrote: On Fri, Jul 27, 2012 at 10:20:43AM -0700, Andrew Stiegmann wrote: The kernel style is to use lower_case for everything. So this would become:

Re: [Pv-drivers] [vmw_vmci 11/11] Apply the header code to make VMCI build

2012-07-28 Thread Dmitry Torokhov
On Sat, Jul 28, 2012 at 12:55:35PM -0700, Greg KH wrote: On Fri, Jul 27, 2012 at 01:29:27PM -0700, Dmitry Torokhov wrote: On Fri, Jul 27, 2012 at 11:16:39AM -0700, Greg KH wrote: On Fri, Jul 27, 2012 at 10:20:43AM -0700, Andrew Stiegmann wrote: The kernel style is to use lower_case for

Re: [Pv-drivers] [vmw_vmci 11/11] Apply the header code to make VMCI build

2012-07-27 Thread Dmitry Torokhov
On Fri, Jul 27, 2012 at 11:16:39AM -0700, Greg KH wrote: > On Fri, Jul 27, 2012 at 10:20:43AM -0700, Andrew Stiegmann wrote: > > > The kernel style is to use lower_case for everything. > > > So this would become: > > > > > > vmci_device_get() > > > > > > This is obviously a very general

Re: [Pv-drivers] [vmw_vmci 11/11] Apply the header code to make VMCI build

2012-07-27 Thread Dmitry Torokhov
Hi Alan, On Fri, Jul 27, 2012 at 10:53:57AM +0100, Alan Cox wrote: > > +enum { > > + VMCI_SUCCESS_QUEUEPAIR_ATTACH = 5, > > + VMCI_SUCCESS_QUEUEPAIR_CREATE = 4, > > + VMCI_SUCCESS_LAST_DETACH= 3, > > + VMCI_SUCCESS_ACCESS_GRANTED = 2, > > + VMCI_SUCCESS_ENTRY_DEAD =

Re: [Pv-drivers] [vmw_vmci 11/11] Apply the header code to make VMCI build

2012-07-27 Thread Dmitry Torokhov
Hi Alan, On Fri, Jul 27, 2012 at 10:53:57AM +0100, Alan Cox wrote: +enum { + VMCI_SUCCESS_QUEUEPAIR_ATTACH = 5, + VMCI_SUCCESS_QUEUEPAIR_CREATE = 4, + VMCI_SUCCESS_LAST_DETACH= 3, + VMCI_SUCCESS_ACCESS_GRANTED = 2, + VMCI_SUCCESS_ENTRY_DEAD = 1, We've

Re: [Pv-drivers] [vmw_vmci 11/11] Apply the header code to make VMCI build

2012-07-27 Thread Dmitry Torokhov
On Fri, Jul 27, 2012 at 11:16:39AM -0700, Greg KH wrote: On Fri, Jul 27, 2012 at 10:20:43AM -0700, Andrew Stiegmann wrote: The kernel style is to use lower_case for everything. So this would become: vmci_device_get() This is obviously a very general comment and applies