Re: [Q] .readable_reg() not verified during read?

2012-10-29 Thread Mark Brown
On Mon, Oct 29, 2012 at 08:40:55AM +0100, Guennadi Liakhovetski wrote: > On Sun, 28 Oct 2012, Mark Brown wrote: > > No real reason, though to be honest it's not that important - the main > > reason for having the function is to make the debugfs stuff work nicely > > rather than anything else. >

Re: [Q] .readable_reg() not verified during read?

2012-10-29 Thread Guennadi Liakhovetski
On Sun, 28 Oct 2012, Mark Brown wrote: > On Sun, Oct 28, 2012 at 12:36:40AM +0200, Guennadi Liakhovetski wrote: > > > Looking at regmap.c it looks like the .readable_reg() callback is not > > consulted when performing a register read, e.g. in _regmap_raw_read(). Is > > this intentional? If yes

Re: [Q] .readable_reg() not verified during read?

2012-10-29 Thread Guennadi Liakhovetski
On Sun, 28 Oct 2012, Mark Brown wrote: On Sun, Oct 28, 2012 at 12:36:40AM +0200, Guennadi Liakhovetski wrote: Looking at regmap.c it looks like the .readable_reg() callback is not consulted when performing a register read, e.g. in _regmap_raw_read(). Is this intentional? If yes - why?

Re: [Q] .readable_reg() not verified during read?

2012-10-29 Thread Mark Brown
On Mon, Oct 29, 2012 at 08:40:55AM +0100, Guennadi Liakhovetski wrote: On Sun, 28 Oct 2012, Mark Brown wrote: No real reason, though to be honest it's not that important - the main reason for having the function is to make the debugfs stuff work nicely rather than anything else. But what

Re: [Q] .readable_reg() not verified during read?

2012-10-28 Thread Mark Brown
On Sun, Oct 28, 2012 at 12:36:40AM +0200, Guennadi Liakhovetski wrote: > Looking at regmap.c it looks like the .readable_reg() callback is not > consulted when performing a register read, e.g. in _regmap_raw_read(). Is > this intentional? If yes - why? No real reason, though to be honest it's

Re: [Q] .readable_reg() not verified during read?

2012-10-28 Thread Mark Brown
On Sun, Oct 28, 2012 at 12:36:40AM +0200, Guennadi Liakhovetski wrote: Looking at regmap.c it looks like the .readable_reg() callback is not consulted when performing a register read, e.g. in _regmap_raw_read(). Is this intentional? If yes - why? No real reason, though to be honest it's not

[Q] .readable_reg() not verified during read?

2012-10-27 Thread Guennadi Liakhovetski
Hi Mark Looking at regmap.c it looks like the .readable_reg() callback is not consulted when performing a register read, e.g. in _regmap_raw_read(). Is this intentional? If yes - why? Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer

[Q] .readable_reg() not verified during read?

2012-10-27 Thread Guennadi Liakhovetski
Hi Mark Looking at regmap.c it looks like the .readable_reg() callback is not consulted when performing a register read, e.g. in _regmap_raw_read(). Is this intentional? If yes - why? Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer