Re: [REPOST PATCH] sata_promise: use TF interface for polling NODATA commands

2007-06-07 Thread Jeff Garzik
On Thu, Jun 07, 2007 at 01:25:07PM -0400, Jeff Garzik wrote: > On Thu, Jun 07, 2007 at 01:20:13PM -0400, Chuck Ebbert wrote: > > On 06/06/2007 12:05 PM, Jeff Garzik wrote: > > > FYI to all -- > > > > > > As a reminder. the Promise hardware programs registers when it receives > > > a SET FEATURES

Re: [REPOST PATCH] sata_promise: use TF interface for polling NODATA commands

2007-06-07 Thread Jeff Garzik
On Thu, Jun 07, 2007 at 01:20:13PM -0400, Chuck Ebbert wrote: > On 06/06/2007 12:05 PM, Jeff Garzik wrote: > > FYI to all -- > > > > As a reminder. the Promise hardware programs registers when it receives > > a SET FEATURES - XFER MODE. > > > > If data transfer is occurring on OTHER ports at

Re: [REPOST PATCH] sata_promise: use TF interface for polling NODATA commands

2007-06-07 Thread Chuck Ebbert
On 06/06/2007 12:05 PM, Jeff Garzik wrote: > FYI to all -- > > As a reminder. the Promise hardware programs registers when it receives > a SET FEATURES - XFER MODE. > > If data transfer is occurring on OTHER ports at the time this is issued, > then data corruption is guaranteed to occur.

Re: [REPOST PATCH] sata_promise: use TF interface for polling NODATA commands

2007-06-07 Thread Andrew Morton
On Thu, 7 Jun 2007 11:17:17 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: > On Wed, Jun 06, 2007 at 07:21:22PM +0900, Tejun Heo wrote: > > sata_promise uses two different command modes - packet and TF. Packet > > mode is intelligent low-overhead mode while TF is the same old > > taskfile

Re: [REPOST PATCH] sata_promise: use TF interface for polling NODATA commands

2007-06-07 Thread Jeff Garzik
On Wed, Jun 06, 2007 at 07:21:22PM +0900, Tejun Heo wrote: > sata_promise uses two different command modes - packet and TF. Packet > mode is intelligent low-overhead mode while TF is the same old > taskfile interface. As with other advanced interface (ahci/sil24), > ATA_TFLAG_POLLING has no

Re: [REPOST PATCH] sata_promise: use TF interface for polling NODATA commands

2007-06-07 Thread Jeff Garzik
On Wed, Jun 06, 2007 at 07:21:22PM +0900, Tejun Heo wrote: sata_promise uses two different command modes - packet and TF. Packet mode is intelligent low-overhead mode while TF is the same old taskfile interface. As with other advanced interface (ahci/sil24), ATA_TFLAG_POLLING has no effect

Re: [REPOST PATCH] sata_promise: use TF interface for polling NODATA commands

2007-06-07 Thread Andrew Morton
On Thu, 7 Jun 2007 11:17:17 -0400 Jeff Garzik [EMAIL PROTECTED] wrote: On Wed, Jun 06, 2007 at 07:21:22PM +0900, Tejun Heo wrote: sata_promise uses two different command modes - packet and TF. Packet mode is intelligent low-overhead mode while TF is the same old taskfile interface. As

Re: [REPOST PATCH] sata_promise: use TF interface for polling NODATA commands

2007-06-07 Thread Chuck Ebbert
On 06/06/2007 12:05 PM, Jeff Garzik wrote: FYI to all -- As a reminder. the Promise hardware programs registers when it receives a SET FEATURES - XFER MODE. If data transfer is occurring on OTHER ports at the time this is issued, then data corruption is guaranteed to occur. Polling will

Re: [REPOST PATCH] sata_promise: use TF interface for polling NODATA commands

2007-06-07 Thread Jeff Garzik
On Thu, Jun 07, 2007 at 01:20:13PM -0400, Chuck Ebbert wrote: On 06/06/2007 12:05 PM, Jeff Garzik wrote: FYI to all -- As a reminder. the Promise hardware programs registers when it receives a SET FEATURES - XFER MODE. If data transfer is occurring on OTHER ports at the time this

Re: [REPOST PATCH] sata_promise: use TF interface for polling NODATA commands

2007-06-07 Thread Jeff Garzik
On Thu, Jun 07, 2007 at 01:25:07PM -0400, Jeff Garzik wrote: On Thu, Jun 07, 2007 at 01:20:13PM -0400, Chuck Ebbert wrote: On 06/06/2007 12:05 PM, Jeff Garzik wrote: FYI to all -- As a reminder. the Promise hardware programs registers when it receives a SET FEATURES - XFER MODE.

Re: [REPOST PATCH] sata_promise: use TF interface for polling NODATA commands

2007-06-06 Thread Alan Cox
On Wed, 6 Jun 2007 12:05:11 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: > > FYI to all -- > > As a reminder. the Promise hardware programs registers when it receives > a SET FEATURES - XFER MODE. > > If data transfer is occurring on OTHER ports at the time this is issued, > then data

Re: [REPOST PATCH] sata_promise: use TF interface for polling NODATA commands

2007-06-06 Thread Jeff Garzik
FYI to all -- As a reminder. the Promise hardware programs registers when it receives a SET FEATURES - XFER MODE. If data transfer is occurring on OTHER ports at the time this is issued, then data corruption is guaranteed to occur. Polling will not fix this problem -- all ports need to be

Re: [REPOST PATCH] sata_promise: use TF interface for polling NODATA commands

2007-06-06 Thread walt
Tejun Heo wrote: ... Fix pdc_qc_issue_prot() such that ATA/ATAPI NODATA commands are issued using TF interface if ATA_TFLAG_POLLING is set. This patch fixes detection failure introduced by polling SETXFERMODE. Your patch works for me, thanks. - To unsubscribe from this list: send the line

Re: [REPOST PATCH] sata_promise: use TF interface for polling NODATA commands

2007-06-06 Thread Mikael Pettersson
On Wed, 6 Jun 2007 19:21:22 +0900, Tejun Heo wrote: > sata_promise uses two different command modes - packet and TF. Packet > mode is intelligent low-overhead mode while TF is the same old > taskfile interface. As with other advanced interface (ahci/sil24), > ATA_TFLAG_POLLING has no effect in

[REPOST PATCH] sata_promise: use TF interface for polling NODATA commands

2007-06-06 Thread Tejun Heo
sata_promise uses two different command modes - packet and TF. Packet mode is intelligent low-overhead mode while TF is the same old taskfile interface. As with other advanced interface (ahci/sil24), ATA_TFLAG_POLLING has no effect in packet mode. However, PIO commands are issued using TF

[REPOST PATCH] sata_promise: use TF interface for polling NODATA commands

2007-06-06 Thread Tejun Heo
sata_promise uses two different command modes - packet and TF. Packet mode is intelligent low-overhead mode while TF is the same old taskfile interface. As with other advanced interface (ahci/sil24), ATA_TFLAG_POLLING has no effect in packet mode. However, PIO commands are issued using TF

Re: [REPOST PATCH] sata_promise: use TF interface for polling NODATA commands

2007-06-06 Thread Mikael Pettersson
On Wed, 6 Jun 2007 19:21:22 +0900, Tejun Heo wrote: sata_promise uses two different command modes - packet and TF. Packet mode is intelligent low-overhead mode while TF is the same old taskfile interface. As with other advanced interface (ahci/sil24), ATA_TFLAG_POLLING has no effect in

Re: [REPOST PATCH] sata_promise: use TF interface for polling NODATA commands

2007-06-06 Thread walt
Tejun Heo wrote: ... Fix pdc_qc_issue_prot() such that ATA/ATAPI NODATA commands are issued using TF interface if ATA_TFLAG_POLLING is set. This patch fixes detection failure introduced by polling SETXFERMODE. Your patch works for me, thanks. - To unsubscribe from this list: send the line

Re: [REPOST PATCH] sata_promise: use TF interface for polling NODATA commands

2007-06-06 Thread Jeff Garzik
FYI to all -- As a reminder. the Promise hardware programs registers when it receives a SET FEATURES - XFER MODE. If data transfer is occurring on OTHER ports at the time this is issued, then data corruption is guaranteed to occur. Polling will not fix this problem -- all ports need to be

Re: [REPOST PATCH] sata_promise: use TF interface for polling NODATA commands

2007-06-06 Thread Alan Cox
On Wed, 6 Jun 2007 12:05:11 -0400 Jeff Garzik [EMAIL PROTECTED] wrote: FYI to all -- As a reminder. the Promise hardware programs registers when it receives a SET FEATURES - XFER MODE. If data transfer is occurring on OTHER ports at the time this is issued, then data corruption is