Re: [RESEND, PATCH v13 09/12] soc: mediatek: cmdq: define the instruction struct

On 27/08/2019 06:12, Bibby Hsieh wrote: >>> >>> int cmdq_pkt_wfe(struct cmdq_pkt *pkt, u16 event) >>> { >>> - u32 arg_b; >>> + struct cmdq_instruction *inst; >>> >>> if (event >= CMDQ_MAX_EVENT) >>> return -EINVAL; >>> >>> - /* >>> -* WFE arg_b >>> -* bit

Re: [RESEND, PATCH v13 09/12] soc: mediatek: cmdq: define the instruction struct

On Fri, 2019-08-23 at 15:50 +0200, Matthias Brugger wrote: > > On 20/08/2019 10:49, Bibby Hsieh wrote: > > Define an instruction structure for gce driver to append command. > > This structure can make the client's code more readability. > > > > Signed-off-by: Bibby Hsieh > > Reviewed-by: CK Hu

Re: [RESEND, PATCH v13 09/12] soc: mediatek: cmdq: define the instruction struct

On 20/08/2019 10:49, Bibby Hsieh wrote: > Define an instruction structure for gce driver to append command. > This structure can make the client's code more readability. > > Signed-off-by: Bibby Hsieh > Reviewed-by: CK Hu > --- > drivers/soc/mediatek/mtk-cmdq-helper.c | 106

Re: [RESEND, PATCH v13 09/12] soc: mediatek: cmdq: define the instruction struct

Reviewed-by: Houlong Wei On Tue, 2019-08-20 at 16:49 +0800, Bibby Hsieh wrote: > Define an instruction structure for gce driver to append command. > This structure can make the client's code more readability. > > Signed-off-by: Bibby Hsieh > Reviewed-by: CK Hu > --- >

[RESEND, PATCH v13 09/12] soc: mediatek: cmdq: define the instruction struct

Define an instruction structure for gce driver to append command. This structure can make the client's code more readability. Signed-off-by: Bibby Hsieh Reviewed-by: CK Hu --- drivers/soc/mediatek/mtk-cmdq-helper.c | 106 +++ include/linux/mailbox/mtk-cmdq-mailbox.h | 2