Re: [RESEND][PATCH] mtd: refactor call to request_module

2013-08-02 Thread Artem Bityutskiy
On Mon, 2013-07-08 at 06:05 -0700, Kees Cook wrote: > This reduces the size of the stack frame when calling request_module(). > Performing the sprintf before the call is not needed. > > Signed-off-by: Kees Cook Pushed to l2-mtd.git, thanks! -- Best Regards, Artem Bityutskiy -- To unsubscribe

Re: [RESEND][PATCH] mtd: refactor call to request_module

2013-08-02 Thread Artem Bityutskiy
On Mon, 2013-07-08 at 06:05 -0700, Kees Cook wrote: This reduces the size of the stack frame when calling request_module(). Performing the sprintf before the call is not needed. Signed-off-by: Kees Cook keesc...@chromium.org Pushed to l2-mtd.git, thanks! -- Best Regards, Artem Bityutskiy

Re: [RESEND][PATCH] mtd: refactor call to request_module

2013-07-10 Thread James Hogan
On 10/07/13 04:10, Rusty Russell wrote: > Kees Cook writes: >> This reduces the size of the stack frame when calling request_module(). >> Performing the sprintf before the call is not needed. >> >> Signed-off-by: Kees Cook > > Acked-by: Rusty Russell I remember reviewing this before, so feel

Re: [RESEND][PATCH] mtd: refactor call to request_module

2013-07-10 Thread James Hogan
On 10/07/13 04:10, Rusty Russell wrote: Kees Cook keesc...@chromium.org writes: This reduces the size of the stack frame when calling request_module(). Performing the sprintf before the call is not needed. Signed-off-by: Kees Cook keesc...@chromium.org Acked-by: Rusty Russell

Re: [RESEND][PATCH] mtd: refactor call to request_module

2013-07-09 Thread Rusty Russell
Kees Cook writes: > This reduces the size of the stack frame when calling request_module(). > Performing the sprintf before the call is not needed. > > Signed-off-by: Kees Cook Acked-by: Rusty Russell Thanks, Rusty. > --- > drivers/mtd/chips/gen_probe.c |4 +--- > 1 file changed, 1

Re: [RESEND][PATCH] mtd: refactor call to request_module

2013-07-09 Thread Rusty Russell
Kees Cook keesc...@chromium.org writes: This reduces the size of the stack frame when calling request_module(). Performing the sprintf before the call is not needed. Signed-off-by: Kees Cook keesc...@chromium.org Acked-by: Rusty Russell ru...@rustcorp.com.au Thanks, Rusty. ---

[RESEND][PATCH] mtd: refactor call to request_module

2013-07-08 Thread Kees Cook
This reduces the size of the stack frame when calling request_module(). Performing the sprintf before the call is not needed. Signed-off-by: Kees Cook --- drivers/mtd/chips/gen_probe.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/mtd/chips/gen_probe.c

[RESEND][PATCH] mtd: refactor call to request_module

2013-07-08 Thread Kees Cook
This reduces the size of the stack frame when calling request_module(). Performing the sprintf before the call is not needed. Signed-off-by: Kees Cook keesc...@chromium.org --- drivers/mtd/chips/gen_probe.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

Re: [RESEND][PATCH] mtd: refactor call to request_module

2013-05-22 Thread Rusty Russell
Kees Cook writes: > This reduces the size of the stack frame when calling request_module(). > Performing the sprintf before the call is not needed. > > Signed-off-by: Kees Cook I like the patch. If dwmw2 doesn't grab it, Andrew please take. Thanks, Rusty. > --- >

[RESEND][PATCH] mtd: refactor call to request_module

2013-05-22 Thread Kees Cook
This reduces the size of the stack frame when calling request_module(). Performing the sprintf before the call is not needed. Signed-off-by: Kees Cook --- drivers/mtd/chips/gen_probe.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/mtd/chips/gen_probe.c

[RESEND][PATCH] mtd: refactor call to request_module

2013-05-22 Thread Kees Cook
This reduces the size of the stack frame when calling request_module(). Performing the sprintf before the call is not needed. Signed-off-by: Kees Cook keesc...@chromium.org --- drivers/mtd/chips/gen_probe.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

Re: [RESEND][PATCH] mtd: refactor call to request_module

2013-05-22 Thread Rusty Russell
Kees Cook keesc...@chromium.org writes: This reduces the size of the stack frame when calling request_module(). Performing the sprintf before the call is not needed. Signed-off-by: Kees Cook keesc...@chromium.org I like the patch. If dwmw2 doesn't grab it, Andrew please take. Thanks,