Re: [RESEND] [PATCH v2 1/2] arm: devtree: Set system_rev from DT revision

2015-07-06 Thread Rob Herring
On Mon, Jul 6, 2015 at 11:20 AM, Pali Rohár wrote: > On Monday 06 July 2015 17:22:58 Rob Herring wrote: >> On Mon, Jul 6, 2015 at 8:12 AM, Pali Rohár wrote: >> > On Monday 06 July 2015 14:31:27 Tony Lindgren wrote: >> >> * Pali Rohár [150706 05:25]: >> >> > into which file should I put documenta

Re: [RESEND] [PATCH v2 1/2] arm: devtree: Set system_rev from DT revision

2015-07-06 Thread Pali Rohár
On Monday 06 July 2015 18:20:35 Pali Rohár wrote: > > > "/chosen/linux,atags" > > > > This one. ATAGs are a Linux data struct. > > > > Rob > > Ok, and how read that property "/chosen/linux,atags" in function > setup_machine_fdt() from file arch/arm/kernel/devtree.c ? > > of_get_flat_dt_prop() c

Re: [RESEND] [PATCH v2 1/2] arm: devtree: Set system_rev from DT revision

2015-07-06 Thread Pali Rohár
On Monday 06 July 2015 17:22:58 Rob Herring wrote: > On Mon, Jul 6, 2015 at 8:12 AM, Pali Rohár wrote: > > On Monday 06 July 2015 14:31:27 Tony Lindgren wrote: > >> * Pali Rohár [150706 05:25]: > >> > into which file should I put documentation about new DT > >> > properties? > >> > >> If it's Li

Re: [RESEND] [PATCH v2 1/2] arm: devtree: Set system_rev from DT revision

2015-07-06 Thread Tony Lindgren
* Rob Herring [150706 08:23]: > On Mon, Jul 6, 2015 at 7:31 AM, Tony Lindgren wrote: > > * Pali Rohár [150706 05:25]: > >> > >> into which file should I put documentation about new DT properties? > > > > If it's Linux generic like linux,revision, then how about > > Just "revision" at the top le

Re: [RESEND] [PATCH v2 1/2] arm: devtree: Set system_rev from DT revision

2015-07-06 Thread Rob Herring
On Mon, Jul 6, 2015 at 8:12 AM, Pali Rohár wrote: > On Monday 06 July 2015 14:31:27 Tony Lindgren wrote: >> * Pali Rohár [150706 05:25]: >> > into which file should I put documentation about new DT properties? >> >> If it's Linux generic like linux,revision, then how about >> Documentation/device

Re: [RESEND] [PATCH v2 1/2] arm: devtree: Set system_rev from DT revision

2015-07-06 Thread Rob Herring
On Mon, Jul 6, 2015 at 7:31 AM, Tony Lindgren wrote: > * Pali Rohár [150706 05:25]: >> >> into which file should I put documentation about new DT properties? > > If it's Linux generic like linux,revision, then how about Just "revision" at the top level please. I'd prefer a string still, but eith

Re: [RESEND] [PATCH v2 1/2] arm: devtree: Set system_rev from DT revision

2015-07-06 Thread Tony Lindgren
* Pali Rohár [150706 06:14]: > On Monday 06 July 2015 14:31:27 Tony Lindgren wrote: > > * Pali Rohár [150706 05:25]: > > > into which file should I put documentation about new DT properties? > > > > If it's Linux generic like linux,revision, then how about > > Documentation/devicetree/bindings/r

Re: [RESEND] [PATCH v2 1/2] arm: devtree: Set system_rev from DT revision

2015-07-06 Thread Pali Rohár
On Monday 06 July 2015 14:31:27 Tony Lindgren wrote: > * Pali Rohár [150706 05:25]: > > into which file should I put documentation about new DT properties? > > If it's Linux generic like linux,revision, then how about > Documentation/devicetree/bindings/revision.txt? > > For the ATAGs, Documenta

Re: [RESEND] [PATCH v2 1/2] arm: devtree: Set system_rev from DT revision

2015-07-06 Thread Tony Lindgren
* Pali Rohár [150706 05:25]: > > into which file should I put documentation about new DT properties? If it's Linux generic like linux,revision, then how about Documentation/devicetree/bindings/revision.txt? For the ATAGs, Documentation/devicetree/bindings/arm/atag.txt? Regards, Tony -- To unsu

Re: [RESEND] [PATCH v2 1/2] arm: devtree: Set system_rev from DT revision

2015-07-06 Thread Pali Rohár
On Thursday 25 June 2015 07:01:38 Tony Lindgren wrote: > * Pali Rohár [150506 04:45]: > > On Wednesday 06 May 2015 13:04:01 Arnd Bergmann wrote: > > > > It needs to be done in this code, so "system_rev" variable is > > > > set properly... > > > > > > What I mean is which code accesses this variab

Re: [RESEND] [PATCH v2 1/2] arm: devtree: Set system_rev from DT revision

2015-06-25 Thread Russell King - ARM Linux
On Wed, May 06, 2015 at 01:44:17PM +0200, Pali Rohár wrote: > On Wednesday 06 May 2015 13:04:01 Arnd Bergmann wrote: > > What I mean is which code accesses this variable that early? > > > > ATAG code is doing it at same early stage, so I added it to same early > stage... ATAG code does it early

Re: [RESEND] [PATCH v2 1/2] arm: devtree: Set system_rev from DT revision

2015-06-25 Thread Tony Lindgren
* Pali Rohár [150625 00:29]: > On Thursday 25 June 2015 00:22:05 Tony Lindgren wrote: > > * Pali Rohár [150625 00:21]: > > > > > > Ok, but what do you mean to forget any string conversion? > > > > No need for tohexstr() in the uncommpress code if the system_rev > > value is a number coming from

Re: [RESEND] [PATCH v2 1/2] arm: devtree: Set system_rev from DT revision

2015-06-25 Thread Pali Rohár
On Thursday 25 June 2015 00:22:05 Tony Lindgren wrote: > * Pali Rohár [150625 00:21]: > > > > Ok, but what do you mean to forget any string conversion? > > No need for tohexstr() in the uncommpress code if the system_rev > value is a number coming from the dts. > > Regards, > > Tony So /revis

Re: [RESEND] [PATCH v2 1/2] arm: devtree: Set system_rev from DT revision

2015-06-25 Thread Tony Lindgren
* Pali Rohár [150625 00:21]: > > Ok, but what do you mean to forget any string conversion? No need for tohexstr() in the uncommpress code if the system_rev value is a number coming from the dts. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the bod

Re: [RESEND] [PATCH v2 1/2] arm: devtree: Set system_rev from DT revision

2015-06-25 Thread Pali Rohár
On Wednesday 24 June 2015 22:01:38 Tony Lindgren wrote: > * Pali Rohár [150506 04:45]: > > On Wednesday 06 May 2015 13:04:01 Arnd Bergmann wrote: > > > > > > > > It needs to be done in this code, so "system_rev" variable is set > > > > properly... > > > > > > What I mean is which code accesses t

Re: [RESEND] [PATCH v2 1/2] arm: devtree: Set system_rev from DT revision

2015-06-24 Thread Tony Lindgren
* Pali Rohár [150506 04:45]: > On Wednesday 06 May 2015 13:04:01 Arnd Bergmann wrote: > > > > > > It needs to be done in this code, so "system_rev" variable is set > > > properly... > > > > What I mean is which code accesses this variable that early? > > > > ATAG code is doing it at same early

Re: [RESEND] [PATCH v2 1/2] arm: devtree: Set system_rev from DT revision

2015-05-06 Thread Pali Rohár
On Wednesday 06 May 2015 13:04:01 Arnd Bergmann wrote: > On Wednesday 06 May 2015 12:37:52 Pali Rohár wrote: > > On Wednesday 06 May 2015 11:31:15 Arnd Bergmann wrote: > > > On Wednesday 06 May 2015 10:49:01 Pali Rohár wrote: > > > > With this patch "revision" DT string entry is used to set global

Re: [RESEND] [PATCH v2 1/2] arm: devtree: Set system_rev from DT revision

2015-05-06 Thread Arnd Bergmann
On Wednesday 06 May 2015 12:37:52 Pali Rohár wrote: > On Wednesday 06 May 2015 11:31:15 Arnd Bergmann wrote: > > On Wednesday 06 May 2015 10:49:01 Pali Rohár wrote: > > > With this patch "revision" DT string entry is used to set global > > > system_rev > > > variable. DT "revision" is expected to

Re: [RESEND] [PATCH v2 1/2] arm: devtree: Set system_rev from DT revision

2015-05-06 Thread Pali Rohár
On Wednesday 06 May 2015 11:31:15 Arnd Bergmann wrote: > On Wednesday 06 May 2015 10:49:01 Pali Rohár wrote: > > With this patch "revision" DT string entry is used to set global system_rev > > variable. DT "revision" is expected to be string with one hexadecimal > > number. > > So "Revision" line

Re: [RESEND] [PATCH v2 1/2] arm: devtree: Set system_rev from DT revision

2015-05-06 Thread Arnd Bergmann
On Wednesday 06 May 2015 10:49:01 Pali Rohár wrote: > With this patch "revision" DT string entry is used to set global system_rev > variable. DT "revision" is expected to be string with one hexadecimal number. > So "Revision" line in /proc/cpuinfo will be same as "revision" DT value. > > Signed-of

[RESEND] [PATCH v2 1/2] arm: devtree: Set system_rev from DT revision

2015-05-06 Thread Pali Rohár
With this patch "revision" DT string entry is used to set global system_rev variable. DT "revision" is expected to be string with one hexadecimal number. So "Revision" line in /proc/cpuinfo will be same as "revision" DT value. Signed-off-by: Pali Rohár Acked-by: Pavel Machek --- arch/arm/kernel