Re: [RESEND PATCH] spmi: prefix spmi bus device names with "spmi"

2020-10-13 Thread David Collins
On 10/2/20 2:39 PM, Stephen Boyd wrote: > I see things like this on my console: > > [1.684617] spmi spmi-0: PMIC arbiter version v5 (0x5000) > > and 'spmi' is the bus name I'm thinking about. But I think that's > because there isn't a driver attached. Nothing prints for the 0-00 > device

Re: [RESEND PATCH] spmi: prefix spmi bus device names with "spmi"

2020-10-02 Thread Stephen Boyd
Quoting Mark Brown (2020-10-02 11:04:30) > On Fri, Oct 02, 2020 at 10:48:32AM -0700, Stephen Boyd wrote: > > Quoting Mark Brown (2020-10-02 09:03:24) > > > > ...and doing this in the dev_name() should help other diagnostic users > > > (like dev_printk() for example). > > > Don't thinks like

Re: [RESEND PATCH] spmi: prefix spmi bus device names with "spmi"

2020-10-02 Thread Mark Brown
On Fri, Oct 02, 2020 at 10:48:32AM -0700, Stephen Boyd wrote: > Quoting Mark Brown (2020-10-02 09:03:24) > > ...and doing this in the dev_name() should help other diagnostic users > > (like dev_printk() for example). > Don't thinks like dev_printk() prefix the bus name? See >

Re: [RESEND PATCH] spmi: prefix spmi bus device names with "spmi"

2020-10-02 Thread Stephen Boyd
Quoting Mark Brown (2020-10-02 09:03:24) > On Thu, Oct 01, 2020 at 05:45:00PM -0700, David Collins wrote: > > > The SPMI regmap debugfs files are used extensively for testing and debug > > purposes internally at Qualcomm and by our customers. It would be helpful > > if the more verbose naming

Re: [RESEND PATCH] spmi: prefix spmi bus device names with "spmi"

2020-10-02 Thread Mark Brown
On Thu, Oct 01, 2020 at 05:45:00PM -0700, David Collins wrote: > The SPMI regmap debugfs files are used extensively for testing and debug > purposes internally at Qualcomm and by our customers. It would be helpful > if the more verbose naming scheme were accepted upstream to avoid > confusion

Re: [RESEND PATCH] spmi: prefix spmi bus device names with "spmi"

2020-10-01 Thread David Collins
On 10/1/20 11:51 AM, Stephen Boyd wrote: > Quoting Mark Brown (2020-10-01 10:43:26) >> On Wed, Sep 30, 2020 at 05:07:20PM -0700, Stephen Boyd wrote: >>> Quoting David Collins (2020-09-22 15:04:18) >> This helps to disambiguate SPMI device regmaps from I2C ones at /sys/kernel/debug/regmap

Re: [RESEND PATCH] spmi: prefix spmi bus device names with "spmi"

2020-10-01 Thread Stephen Boyd
Quoting Mark Brown (2020-10-01 10:43:26) > On Wed, Sep 30, 2020 at 05:07:20PM -0700, Stephen Boyd wrote: > > Quoting David Collins (2020-09-22 15:04:18) > > > > This helps to disambiguate SPMI device regmaps from I2C ones > > > at /sys/kernel/debug/regmap since I2C devices use a very > > >

Re: [RESEND PATCH] spmi: prefix spmi bus device names with "spmi"

2020-10-01 Thread Mark Brown
On Wed, Sep 30, 2020 at 05:07:20PM -0700, Stephen Boyd wrote: > Quoting David Collins (2020-09-22 15:04:18) > > This helps to disambiguate SPMI device regmaps from I2C ones > > at /sys/kernel/debug/regmap since I2C devices use a very > > similar naming scheme: 0-. > Can regmap debugfs

Re: [RESEND PATCH] spmi: prefix spmi bus device names with "spmi"

2020-09-30 Thread Stephen Boyd
Quoting David Collins (2020-09-22 15:04:18) > Change the format of spmi bus device names from: > - > Example: 0-01 > to this: > spmi- > Example: spmi0-01 > > This helps to disambiguate SPMI device regmaps from I2C ones > at /sys/kernel/debug/regmap since I2C devices use a very > similar

[RESEND PATCH] spmi: prefix spmi bus device names with "spmi"

2020-09-22 Thread David Collins
Change the format of spmi bus device names from: - Example: 0-01 to this: spmi- Example: spmi0-01 This helps to disambiguate SPMI device regmaps from I2C ones at /sys/kernel/debug/regmap since I2C devices use a very similar naming scheme: 0-. Signed-off-by: David Collins ---