Re: [RESEND PATCH 4/4 v3] mm: fix possible incorrect return value of move_pages() syscall

2012-08-01 Thread Michael Kerrisk
On Wed, Aug 1, 2012 at 8:00 PM, Christoph Lameter wrote: > On Wed, 1 Aug 2012, Michael Kerrisk wrote: > >> Is the patch below acceptable? (I've attached the complete page as well.) > > Yes looks good. Thanks for checking it! >> See you in San Diego (?), > > Yup. I will be there too. See you

Re: [RESEND PATCH 4/4 v3] mm: fix possible incorrect return value of move_pages() syscall

2012-08-01 Thread Christoph Lameter
On Wed, 1 Aug 2012, Michael Kerrisk wrote: > Is the patch below acceptable? (I've attached the complete page as well.) Yes looks good. > See you in San Diego (?), Yup. I will be there too. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: [RESEND PATCH 4/4 v3] mm: fix possible incorrect return value of move_pages() syscall

2012-08-01 Thread Christoph Lameter
On Wed, 1 Aug 2012, Michael Kerrisk wrote: Is the patch below acceptable? (I've attached the complete page as well.) Yes looks good. See you in San Diego (?), Yup. I will be there too. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to

Re: [RESEND PATCH 4/4 v3] mm: fix possible incorrect return value of move_pages() syscall

2012-08-01 Thread Michael Kerrisk
On Wed, Aug 1, 2012 at 8:00 PM, Christoph Lameter c...@linux.com wrote: On Wed, 1 Aug 2012, Michael Kerrisk wrote: Is the patch below acceptable? (I've attached the complete page as well.) Yes looks good. Thanks for checking it! See you in San Diego (?), Yup. I will be there too. See

Re: [RESEND PATCH 4/4 v3] mm: fix possible incorrect return value of move_pages() syscall

2012-07-31 Thread Michael Kerrisk
On Mon, Jul 30, 2012 at 9:29 PM, Christoph Lameter wrote: > On Sat, 28 Jul 2012, JoonSoo Kim wrote: > >> 2012/7/28 Christoph Lameter : >> > On Sat, 28 Jul 2012, Joonsoo Kim wrote: >> > >> >> move_pages() syscall may return success in case that >> >> do_move_page_to_node_array return positive

Re: [RESEND PATCH 4/4 v3] mm: fix possible incorrect return value of move_pages() syscall

2012-07-31 Thread Christoph Lameter
On Tue, 31 Jul 2012, JoonSoo Kim wrote: > In man page, there is following statement. > "status is an array of integers that return the status of each page. The > array > only contains valid values if move_pages() did not return an error." > And current implementation of move_pages() syscall

Re: [RESEND PATCH 4/4 v3] mm: fix possible incorrect return value of move_pages() syscall

2012-07-31 Thread Christoph Lameter
On Tue, 31 Jul 2012, JoonSoo Kim wrote: In man page, there is following statement. status is an array of integers that return the status of each page. The array only contains valid values if move_pages() did not return an error. And current implementation of move_pages() syscall doesn't

Re: [RESEND PATCH 4/4 v3] mm: fix possible incorrect return value of move_pages() syscall

2012-07-31 Thread Michael Kerrisk
On Mon, Jul 30, 2012 at 9:29 PM, Christoph Lameter c...@linux.com wrote: On Sat, 28 Jul 2012, JoonSoo Kim wrote: 2012/7/28 Christoph Lameter c...@linux.com: On Sat, 28 Jul 2012, Joonsoo Kim wrote: move_pages() syscall may return success in case that do_move_page_to_node_array return

Re: [RESEND PATCH 4/4 v3] mm: fix possible incorrect return value of move_pages() syscall

2012-07-30 Thread JoonSoo Kim
2012/7/31 Christoph Lameter : > On Sat, 28 Jul 2012, JoonSoo Kim wrote: > >> 2012/7/28 Christoph Lameter : >> > On Sat, 28 Jul 2012, Joonsoo Kim wrote: >> > >> >> move_pages() syscall may return success in case that >> >> do_move_page_to_node_array return positive value which means migration >>

Re: [RESEND PATCH 4/4 v3] mm: fix possible incorrect return value of move_pages() syscall

2012-07-30 Thread Christoph Lameter
On Sat, 28 Jul 2012, JoonSoo Kim wrote: > 2012/7/28 Christoph Lameter : > > On Sat, 28 Jul 2012, Joonsoo Kim wrote: > > > >> move_pages() syscall may return success in case that > >> do_move_page_to_node_array return positive value which means migration > >> failed. > > > > Nope. It only means

Re: [RESEND PATCH 4/4 v3] mm: fix possible incorrect return value of move_pages() syscall

2012-07-30 Thread Christoph Lameter
On Sat, 28 Jul 2012, JoonSoo Kim wrote: 2012/7/28 Christoph Lameter c...@linux.com: On Sat, 28 Jul 2012, Joonsoo Kim wrote: move_pages() syscall may return success in case that do_move_page_to_node_array return positive value which means migration failed. Nope. It only means that

Re: [RESEND PATCH 4/4 v3] mm: fix possible incorrect return value of move_pages() syscall

2012-07-30 Thread JoonSoo Kim
2012/7/31 Christoph Lameter c...@linux.com: On Sat, 28 Jul 2012, JoonSoo Kim wrote: 2012/7/28 Christoph Lameter c...@linux.com: On Sat, 28 Jul 2012, Joonsoo Kim wrote: move_pages() syscall may return success in case that do_move_page_to_node_array return positive value which means

Re: [RESEND PATCH 4/4 v3] mm: fix possible incorrect return value of move_pages() syscall

2012-07-28 Thread JoonSoo Kim
2012/7/28 Christoph Lameter : > On Sat, 28 Jul 2012, Joonsoo Kim wrote: > >> move_pages() syscall may return success in case that >> do_move_page_to_node_array return positive value which means migration >> failed. > > Nope. It only means that the migration for some pages has failed. This may >

Re: [RESEND PATCH 4/4 v3] mm: fix possible incorrect return value of move_pages() syscall

2012-07-28 Thread JoonSoo Kim
2012/7/28 Christoph Lameter c...@linux.com: On Sat, 28 Jul 2012, Joonsoo Kim wrote: move_pages() syscall may return success in case that do_move_page_to_node_array return positive value which means migration failed. Nope. It only means that the migration for some pages has failed. This may

Re: [RESEND PATCH 4/4 v3] mm: fix possible incorrect return value of move_pages() syscall

2012-07-27 Thread Christoph Lameter
On Sat, 28 Jul 2012, Joonsoo Kim wrote: > move_pages() syscall may return success in case that > do_move_page_to_node_array return positive value which means migration failed. Nope. It only means that the migration for some pages has failed. This may still be considered successful for the app if

[RESEND PATCH 4/4 v3] mm: fix possible incorrect return value of move_pages() syscall

2012-07-27 Thread Joonsoo Kim
move_pages() syscall may return success in case that do_move_page_to_node_array return positive value which means migration failed. This patch changes return value of do_move_page_to_node_array for not returning positive value. It can fix the problem. Signed-off-by: Joonsoo Kim Cc: Brice Goglin

[RESEND PATCH 4/4 v3] mm: fix possible incorrect return value of move_pages() syscall

2012-07-27 Thread Joonsoo Kim
move_pages() syscall may return success in case that do_move_page_to_node_array return positive value which means migration failed. This patch changes return value of do_move_page_to_node_array for not returning positive value. It can fix the problem. Signed-off-by: Joonsoo Kim js1...@gmail.com

Re: [RESEND PATCH 4/4 v3] mm: fix possible incorrect return value of move_pages() syscall

2012-07-27 Thread Christoph Lameter
On Sat, 28 Jul 2012, Joonsoo Kim wrote: move_pages() syscall may return success in case that do_move_page_to_node_array return positive value which means migration failed. Nope. It only means that the migration for some pages has failed. This may still be considered successful for the app if