Re: [RESEND PATCH v3 3/5] i2c: i2c-stm32f7: add driver

On 09/13/2017 11:26 PM, Wolfram Sang wrote: > Hi, > > thanks for this driver! > >> +/** >> + * struct stm32f7_i2c_spec - private i2c specification timing >> + * @rate: I2C bus speed (Hz) >> + * @rate_min: 80% of I2C bus speed (Hz) >> + * @rate_max: 120% of I2C bus speed (Hz) > > You would

Re: [RESEND PATCH v3 3/5] i2c: i2c-stm32f7: add driver

On 09/13/2017 11:26 PM, Wolfram Sang wrote: > Hi, > > thanks for this driver! > >> +/** >> + * struct stm32f7_i2c_spec - private i2c specification timing >> + * @rate: I2C bus speed (Hz) >> + * @rate_min: 80% of I2C bus speed (Hz) >> + * @rate_max: 120% of I2C bus speed (Hz) > > You would

Re: [RESEND PATCH v3 3/5] i2c: i2c-stm32f7: add driver

Hi, thanks for this driver! > +/** > + * struct stm32f7_i2c_spec - private i2c specification timing > + * @rate: I2C bus speed (Hz) > + * @rate_min: 80% of I2C bus speed (Hz) > + * @rate_max: 120% of I2C bus speed (Hz) You would generate a clock which is higher than the requested one? This is

Re: [RESEND PATCH v3 3/5] i2c: i2c-stm32f7: add driver

Hi, thanks for this driver! > +/** > + * struct stm32f7_i2c_spec - private i2c specification timing > + * @rate: I2C bus speed (Hz) > + * @rate_min: 80% of I2C bus speed (Hz) > + * @rate_max: 120% of I2C bus speed (Hz) You would generate a clock which is higher than the requested one? This is

[RESEND PATCH v3 3/5] i2c: i2c-stm32f7: add driver

This patch adds initial support for the STM32F7 I2C controller. Signed-off-by: M'boumba Cedric Madianga Signed-off-by: Pierre-Yves MORDRET --- Version history: v3: * Move stm32f7_i2c_match above stm32f7_i2c_driver *

[RESEND PATCH v3 3/5] i2c: i2c-stm32f7: add driver

This patch adds initial support for the STM32F7 I2C controller. Signed-off-by: M'boumba Cedric Madianga Signed-off-by: Pierre-Yves MORDRET --- Version history: v3: * Move stm32f7_i2c_match above stm32f7_i2c_driver * of_device_get_match_data instead of of_match_device