On Tue, Feb 09, 2021 at 03:28:16PM +, Gustavo Pimentel wrote:
> On Mon, Feb 8, 2021 at 22:53:54, Krzysztof Wilczyński
> wrote:
> > [...]
> > > Thanks for your review. I will wait for a couple of days, before sending
> > > a new version of this patch series based on your feedback.
> >
> >
Hi Gustavo,
[...]
> > The code in question would be (exceprt from the patch):
> >
> > [...]
> > +static int dw_xdata_pcie_probe(struct pci_dev *pdev,
> > + const struct pci_device_id *pid)
> > +{
> > + const struct dw_xdata_pcie_data *pdata = (void *)pid->driver_data;
On Mon, Feb 8, 2021 at 22:53:54, Krzysztof Wilczyński
wrote:
> [+cc Bjorn]
>
> Hi Gustavo,
>
> [...]
> > Thanks for your review. I will wait for a couple of days, before sending
> > a new version of this patch series based on your feedback.
>
> Thank you!
>
> There might be one more
[+cc Bjorn]
Hi Gustavo,
[...]
> Thanks for your review. I will wait for a couple of days, before sending
> a new version of this patch series based on your feedback.
Thank you!
There might be one more change, and improvement, to be done as per
Bjorn's feedback, see:
On Sun, Feb 7, 2021 at 1:36:15, Krzysztof Wilczyński
wrote:
> Hi Gustavo,
>
> Thank you for all the work here!
>
> A few suggestions.
>
> [...]
> > +static void dw_xdata_stop(struct dw_xdata *dw)
> > +{
> > + u32 burst = readl(&(__dw_xdara_regs(dw)->burst_cnt));
> > +
> > + if (burst &
Hi Gustavo,
Thank you for all the work here!
A few suggestions.
[...]
> +static void dw_xdata_stop(struct dw_xdata *dw)
> +{
> + u32 burst = readl(&(__dw_xdara_regs(dw)->burst_cnt));
> +
> + if (burst & BIT(31)) {
> + burst &= ~(u32)BIT(31);
> + writel(burst,
On Wed, Feb 03, 2021 at 11:12:46PM +0100, Gustavo Pimentel wrote:
> + /* Sysfs */
> + err = sysfs_create_group(>dev.kobj, _attr_group);
> + if (err)
> + return err;
> +
> + err = sysfs_create_link(kernel_kobj, >dev.kobj,
> +
Add Synopsys DesignWare xData IP driver. This driver enables/disables
the PCI traffic generator module pertain to the Synopsys DesignWare
prototype.
Signed-off-by: Gustavo Pimentel
---
drivers/misc/dw-xdata-pcie.c | 378 +++
1 file changed, 378
8 matches
Mail list logo
