Re: [RESEND v5 PATCH 2/2] mm: vmscan: correct some vmscan counters for THP swapout

2019-05-26 Thread Yang Shi
On 5/27/19 10:58 AM, Huang, Ying wrote: Yang Shi writes: On 5/27/19 10:11 AM, Huang, Ying wrote: Yang Shi writes: Since commit bd4c82c22c36 ("mm, THP, swap: delay splitting THP after swapped out"), THP can be swapped out in a whole. But, nr_reclaimed and some other vm counters still

Re: [RESEND v5 PATCH 2/2] mm: vmscan: correct some vmscan counters for THP swapout

2019-05-26 Thread Yang Shi
On 5/27/19 10:47 AM, Yang Shi wrote: On 5/27/19 10:11 AM, Huang, Ying wrote: Yang Shi writes: Since commit bd4c82c22c36 ("mm, THP, swap: delay splitting THP after swapped out"), THP can be swapped out in a whole.  But, nr_reclaimed and some other vm counters still get inc'ed by one even

Re: [RESEND v5 PATCH 2/2] mm: vmscan: correct some vmscan counters for THP swapout

2019-05-26 Thread Huang, Ying
Yang Shi writes: > On 5/27/19 10:11 AM, Huang, Ying wrote: >> Yang Shi writes: >> >>> Since commit bd4c82c22c36 ("mm, THP, swap: delay splitting THP after >>> swapped out"), THP can be swapped out in a whole. But, nr_reclaimed >>> and some other vm counters still get inc'ed by one even though

Re: [RESEND v5 PATCH 2/2] mm: vmscan: correct some vmscan counters for THP swapout

2019-05-26 Thread Yang Shi
On 5/27/19 10:11 AM, Huang, Ying wrote: Yang Shi writes: Since commit bd4c82c22c36 ("mm, THP, swap: delay splitting THP after swapped out"), THP can be swapped out in a whole. But, nr_reclaimed and some other vm counters still get inc'ed by one even though a whole THP (512 pages) gets

Re: [RESEND v5 PATCH 2/2] mm: vmscan: correct some vmscan counters for THP swapout

2019-05-26 Thread Huang, Ying
Yang Shi writes: > Since commit bd4c82c22c36 ("mm, THP, swap: delay splitting THP after > swapped out"), THP can be swapped out in a whole. But, nr_reclaimed > and some other vm counters still get inc'ed by one even though a whole > THP (512 pages) gets swapped out. > > This doesn't make too

[RESEND v5 PATCH 2/2] mm: vmscan: correct some vmscan counters for THP swapout

2019-05-26 Thread Yang Shi
Since commit bd4c82c22c36 ("mm, THP, swap: delay splitting THP after swapped out"), THP can be swapped out in a whole. But, nr_reclaimed and some other vm counters still get inc'ed by one even though a whole THP (512 pages) gets swapped out. This doesn't make too much sense to memory reclaim.