Re: [RFC/PATCH] of: Mark property::value as const

2017-03-14 Thread Stephen Boyd
Quoting Frank Rowand (2017-03-11 22:27:08) > Hi Stephen, > > On 02/23/17 15:08, Frank Rowand wrote: > > On 02/13/17 18:50, Stephen Boyd wrote: > >> The 'blob' we pass into populate_properties() is marked as const, > >> but we cast that const away when we assign the result of > >>

Re: [RFC/PATCH] of: Mark property::value as const

2017-03-14 Thread Stephen Boyd
Quoting Frank Rowand (2017-03-11 22:27:08) > Hi Stephen, > > On 02/23/17 15:08, Frank Rowand wrote: > > On 02/13/17 18:50, Stephen Boyd wrote: > >> The 'blob' we pass into populate_properties() is marked as const, > >> but we cast that const away when we assign the result of > >>

Re: [RFC/PATCH] of: Mark property::value as const

2017-03-11 Thread Frank Rowand
Hi Stephen, On 02/23/17 15:08, Frank Rowand wrote: > On 02/13/17 18:50, Stephen Boyd wrote: >> The 'blob' we pass into populate_properties() is marked as const, >> but we cast that const away when we assign the result of >> fdt_getprop_by_offset() to pp->value. Let's mark value as const >>

Re: [RFC/PATCH] of: Mark property::value as const

2017-03-11 Thread Frank Rowand
Hi Stephen, On 02/23/17 15:08, Frank Rowand wrote: > On 02/13/17 18:50, Stephen Boyd wrote: >> The 'blob' we pass into populate_properties() is marked as const, >> but we cast that const away when we assign the result of >> fdt_getprop_by_offset() to pp->value. Let's mark value as const >>

Re: [RFC/PATCH] of: Mark property::value as const

2017-02-23 Thread Rob Herring
On Thu, Feb 23, 2017 at 5:08 PM, Frank Rowand wrote: > On 02/13/17 18:50, Stephen Boyd wrote: >> The 'blob' we pass into populate_properties() is marked as const, >> but we cast that const away when we assign the result of >> fdt_getprop_by_offset() to pp->value. Let's

Re: [RFC/PATCH] of: Mark property::value as const

2017-02-23 Thread Rob Herring
On Thu, Feb 23, 2017 at 5:08 PM, Frank Rowand wrote: > On 02/13/17 18:50, Stephen Boyd wrote: >> The 'blob' we pass into populate_properties() is marked as const, >> but we cast that const away when we assign the result of >> fdt_getprop_by_offset() to pp->value. Let's mark value as const >>

Re: [RFC/PATCH] of: Mark property::value as const

2017-02-23 Thread Frank Rowand
On 02/23/17 15:08, Frank Rowand wrote: > On 02/13/17 18:50, Stephen Boyd wrote: >> The 'blob' we pass into populate_properties() is marked as const, >> but we cast that const away when we assign the result of >> fdt_getprop_by_offset() to pp->value. Let's mark value as const >> instead, so that

Re: [RFC/PATCH] of: Mark property::value as const

2017-02-23 Thread Frank Rowand
On 02/23/17 15:08, Frank Rowand wrote: > On 02/13/17 18:50, Stephen Boyd wrote: >> The 'blob' we pass into populate_properties() is marked as const, >> but we cast that const away when we assign the result of >> fdt_getprop_by_offset() to pp->value. Let's mark value as const >> instead, so that

Re: [RFC/PATCH] of: Mark property::value as const

2017-02-23 Thread Frank Rowand
On 02/23/17 14:09, Rob Herring wrote: > On Thu, Feb 23, 2017 at 2:58 PM, Frank Rowand wrote: >> On 02/23/17 11:54, Frank Rowand wrote: >>> On 02/13/17 18:50, Stephen Boyd wrote: The 'blob' we pass into populate_properties() is marked as const, but we cast that

Re: [RFC/PATCH] of: Mark property::value as const

2017-02-23 Thread Frank Rowand
On 02/23/17 14:09, Rob Herring wrote: > On Thu, Feb 23, 2017 at 2:58 PM, Frank Rowand wrote: >> On 02/23/17 11:54, Frank Rowand wrote: >>> On 02/13/17 18:50, Stephen Boyd wrote: The 'blob' we pass into populate_properties() is marked as const, but we cast that const away when we assign

Re: [RFC/PATCH] of: Mark property::value as const

2017-02-23 Thread Frank Rowand
On 02/13/17 18:50, Stephen Boyd wrote: > The 'blob' we pass into populate_properties() is marked as const, > but we cast that const away when we assign the result of > fdt_getprop_by_offset() to pp->value. Let's mark value as const > instead, so that code can't mistakenly write to the value of the

Re: [RFC/PATCH] of: Mark property::value as const

2017-02-23 Thread Frank Rowand
On 02/13/17 18:50, Stephen Boyd wrote: > The 'blob' we pass into populate_properties() is marked as const, > but we cast that const away when we assign the result of > fdt_getprop_by_offset() to pp->value. Let's mark value as const > instead, so that code can't mistakenly write to the value of the

Re: [RFC/PATCH] of: Mark property::value as const

2017-02-23 Thread Rob Herring
On Thu, Feb 23, 2017 at 2:58 PM, Frank Rowand wrote: > On 02/23/17 11:54, Frank Rowand wrote: >> On 02/13/17 18:50, Stephen Boyd wrote: >>> The 'blob' we pass into populate_properties() is marked as const, >>> but we cast that const away when we assign the result of >>>

Re: [RFC/PATCH] of: Mark property::value as const

2017-02-23 Thread Rob Herring
On Thu, Feb 23, 2017 at 2:58 PM, Frank Rowand wrote: > On 02/23/17 11:54, Frank Rowand wrote: >> On 02/13/17 18:50, Stephen Boyd wrote: >>> The 'blob' we pass into populate_properties() is marked as const, >>> but we cast that const away when we assign the result of >>> fdt_getprop_by_offset() to

Re: [RFC/PATCH] of: Mark property::value as const

2017-02-23 Thread Frank Rowand
On 02/23/17 11:54, Frank Rowand wrote: > On 02/13/17 18:50, Stephen Boyd wrote: >> The 'blob' we pass into populate_properties() is marked as const, >> but we cast that const away when we assign the result of >> fdt_getprop_by_offset() to pp->value. Let's mark value as const >> instead, so that

Re: [RFC/PATCH] of: Mark property::value as const

2017-02-23 Thread Frank Rowand
On 02/23/17 11:54, Frank Rowand wrote: > On 02/13/17 18:50, Stephen Boyd wrote: >> The 'blob' we pass into populate_properties() is marked as const, >> but we cast that const away when we assign the result of >> fdt_getprop_by_offset() to pp->value. Let's mark value as const >> instead, so that

Re: [RFC/PATCH] of: Mark property::value as const

2017-02-23 Thread Frank Rowand
On 02/23/17 11:54, Frank Rowand wrote: > On 02/13/17 18:50, Stephen Boyd wrote: >> The 'blob' we pass into populate_properties() is marked as const, >> but we cast that const away when we assign the result of >> fdt_getprop_by_offset() to pp->value. Let's mark value as const >> instead, so that

Re: [RFC/PATCH] of: Mark property::value as const

2017-02-23 Thread Frank Rowand
On 02/23/17 11:54, Frank Rowand wrote: > On 02/13/17 18:50, Stephen Boyd wrote: >> The 'blob' we pass into populate_properties() is marked as const, >> but we cast that const away when we assign the result of >> fdt_getprop_by_offset() to pp->value. Let's mark value as const >> instead, so that

Re: [RFC/PATCH] of: Mark property::value as const

2017-02-23 Thread Frank Rowand
On 02/13/17 18:50, Stephen Boyd wrote: > The 'blob' we pass into populate_properties() is marked as const, > but we cast that const away when we assign the result of > fdt_getprop_by_offset() to pp->value. Let's mark value as const > instead, so that code can't mistakenly write to the value of the

Re: [RFC/PATCH] of: Mark property::value as const

2017-02-23 Thread Frank Rowand
On 02/13/17 18:50, Stephen Boyd wrote: > The 'blob' we pass into populate_properties() is marked as const, > but we cast that const away when we assign the result of > fdt_getprop_by_offset() to pp->value. Let's mark value as const > instead, so that code can't mistakenly write to the value of the

Re: [RFC/PATCH] of: Mark property::value as const

2017-02-23 Thread Rob Herring
On Mon, Feb 13, 2017 at 8:50 PM, Stephen Boyd wrote: > The 'blob' we pass into populate_properties() is marked as const, > but we cast that const away when we assign the result of > fdt_getprop_by_offset() to pp->value. Let's mark value as const > instead, so that code

Re: [RFC/PATCH] of: Mark property::value as const

2017-02-23 Thread Rob Herring
On Mon, Feb 13, 2017 at 8:50 PM, Stephen Boyd wrote: > The 'blob' we pass into populate_properties() is marked as const, > but we cast that const away when we assign the result of > fdt_getprop_by_offset() to pp->value. Let's mark value as const > instead, so that code can't mistakenly write to

[RFC/PATCH] of: Mark property::value as const

2017-02-13 Thread Stephen Boyd
The 'blob' we pass into populate_properties() is marked as const, but we cast that const away when we assign the result of fdt_getprop_by_offset() to pp->value. Let's mark value as const instead, so that code can't mistakenly write to the value of the property that we've so far advertised as

[RFC/PATCH] of: Mark property::value as const

2017-02-13 Thread Stephen Boyd
The 'blob' we pass into populate_properties() is marked as const, but we cast that const away when we assign the result of fdt_getprop_by_offset() to pp->value. Let's mark value as const instead, so that code can't mistakenly write to the value of the property that we've so far advertised as