Re: [RFC/PATCH] perf tools: Fix segfault in cumulative.callchain report

2014-06-19 Thread Arnaldo Carvalho de Melo
Em Mon, Jun 16, 2014 at 10:14:22PM +0900, Namhyung Kim escreveu: > 2014-06-15 (일), 18:34 +0200, Jiri Olsa: > > On Sun, Jun 15, 2014 at 09:46:31PM +0900, Namhyung Kim wrote: > > > 2014-06-15 (일), 10:35 +0200, Jiri Olsa: > > > > not completely sure this is what we want to do, but have no > > > >

Re: [RFC/PATCH] perf tools: Fix segfault in cumulative.callchain report

2014-06-19 Thread Arnaldo Carvalho de Melo
Em Mon, Jun 16, 2014 at 10:14:22PM +0900, Namhyung Kim escreveu: 2014-06-15 (일), 18:34 +0200, Jiri Olsa: On Sun, Jun 15, 2014 at 09:46:31PM +0900, Namhyung Kim wrote: 2014-06-15 (일), 10:35 +0200, Jiri Olsa: not completely sure this is what we want to do, but have no streght to dive

Re: [RFC/PATCH] perf tools: Fix segfault in cumulative.callchain report

2014-06-16 Thread Namhyung Kim
2014-06-15 (일), 18:34 +0200, Jiri Olsa: > On Sun, Jun 15, 2014 at 09:46:31PM +0900, Namhyung Kim wrote: > > Hi Jiri, > > > > 2014-06-15 (일), 10:35 +0200, Jiri Olsa: > > > heya, > > > not completely sure this is what we want to do, but have no > > > streght to dive into annotation code ;-) > > >

Re: [RFC/PATCH] perf tools: Fix segfault in cumulative.callchain report

2014-06-16 Thread Namhyung Kim
2014-06-15 (일), 18:34 +0200, Jiri Olsa: On Sun, Jun 15, 2014 at 09:46:31PM +0900, Namhyung Kim wrote: Hi Jiri, 2014-06-15 (일), 10:35 +0200, Jiri Olsa: heya, not completely sure this is what we want to do, but have no streght to dive into annotation code ;-) Currently,

Re: [RFC/PATCH] perf tools: Fix segfault in cumulative.callchain report

2014-06-15 Thread Jiri Olsa
On Sun, Jun 15, 2014 at 09:46:31PM +0900, Namhyung Kim wrote: > Hi Jiri, > > 2014-06-15 (일), 10:35 +0200, Jiri Olsa: > > heya, > > not completely sure this is what we want to do, but have no > > streght to dive into annotation code ;-) > > Currently, cumulative entries do not accounts annotation

Re: [RFC/PATCH] perf tools: Fix segfault in cumulative.callchain report

2014-06-15 Thread Namhyung Kim
Hi Jiri, 2014-06-15 (일), 10:35 +0200, Jiri Olsa: > heya, > not completely sure this is what we want to do, but have no > streght to dive into annotation code ;-) Currently, cumulative entries do not accounts annotation info so annotation only works for normal entries. I'm not sure we should

[RFC/PATCH] perf tools: Fix segfault in cumulative.callchain report

2014-06-15 Thread Jiri Olsa
heya, not completely sure this is what we want to do, but have no streght to dive into annotation code ;-) thanks, jirka --- When cumulative callchain mode is on, we could get samples with with no actual hits. This breaks the assumption of the annotation code, that each sample has annotation

[RFC/PATCH] perf tools: Fix segfault in cumulative.callchain report

2014-06-15 Thread Jiri Olsa
heya, not completely sure this is what we want to do, but have no streght to dive into annotation code ;-) thanks, jirka --- When cumulative callchain mode is on, we could get samples with with no actual hits. This breaks the assumption of the annotation code, that each sample has annotation

Re: [RFC/PATCH] perf tools: Fix segfault in cumulative.callchain report

2014-06-15 Thread Namhyung Kim
Hi Jiri, 2014-06-15 (일), 10:35 +0200, Jiri Olsa: heya, not completely sure this is what we want to do, but have no streght to dive into annotation code ;-) Currently, cumulative entries do not accounts annotation info so annotation only works for normal entries. I'm not sure we should

Re: [RFC/PATCH] perf tools: Fix segfault in cumulative.callchain report

2014-06-15 Thread Jiri Olsa
On Sun, Jun 15, 2014 at 09:46:31PM +0900, Namhyung Kim wrote: Hi Jiri, 2014-06-15 (일), 10:35 +0200, Jiri Olsa: heya, not completely sure this is what we want to do, but have no streght to dive into annotation code ;-) Currently, cumulative entries do not accounts annotation info so