Re: [RFC/PATCH 15/38] perf tools: Introduce machine__find*_thread_by_time()

2015-10-09 Thread Namhyung Kim
On Thu, Oct 08, 2015 at 02:20:11PM +0200, Jiri Olsa wrote: > On Fri, Oct 02, 2015 at 02:18:56PM +0900, Namhyung Kim wrote: > > SNIP > > > diff --git a/tools/perf/util/thread.c b/tools/perf/util/thread.c > > index 674792e8fa2f..ad7c2a00bff8 100644 > > --- a/tools/perf/util/thread.c > > +++

Re: [RFC/PATCH 15/38] perf tools: Introduce machine__find*_thread_by_time()

2015-10-09 Thread Namhyung Kim
On Thu, Oct 08, 2015 at 02:20:11PM +0200, Jiri Olsa wrote: > On Fri, Oct 02, 2015 at 02:18:56PM +0900, Namhyung Kim wrote: > > SNIP > > > diff --git a/tools/perf/util/thread.c b/tools/perf/util/thread.c > > index 674792e8fa2f..ad7c2a00bff8 100644 > > --- a/tools/perf/util/thread.c > > +++

Re: [RFC/PATCH 15/38] perf tools: Introduce machine__find*_thread_by_time()

2015-10-08 Thread Jiri Olsa
On Fri, Oct 02, 2015 at 02:18:56PM +0900, Namhyung Kim wrote: SNIP > diff --git a/tools/perf/util/thread.c b/tools/perf/util/thread.c > index 674792e8fa2f..ad7c2a00bff8 100644 > --- a/tools/perf/util/thread.c > +++ b/tools/perf/util/thread.c > @@ -160,6 +160,9 @@ int __thread__set_comm(struct

Re: [RFC/PATCH 15/38] perf tools: Introduce machine__find*_thread_by_time()

2015-10-08 Thread Jiri Olsa
On Fri, Oct 02, 2015 at 02:18:56PM +0900, Namhyung Kim wrote: SNIP > diff --git a/tools/perf/util/thread.c b/tools/perf/util/thread.c > index 674792e8fa2f..ad7c2a00bff8 100644 > --- a/tools/perf/util/thread.c > +++ b/tools/perf/util/thread.c > @@ -160,6 +160,9 @@ int __thread__set_comm(struct

[RFC/PATCH 15/38] perf tools: Introduce machine__find*_thread_by_time()

2015-10-01 Thread Namhyung Kim
With data file indexing is enabled, it needs to search thread based on sample time since sample processing is done after other (task, comm and mmap) events are processed. This can be a problem if a session is very long and pid is recycled - in that case it'll only see the last one. So keep

[RFC/PATCH 15/38] perf tools: Introduce machine__find*_thread_by_time()

2015-10-01 Thread Namhyung Kim
With data file indexing is enabled, it needs to search thread based on sample time since sample processing is done after other (task, comm and mmap) events are processed. This can be a problem if a session is very long and pid is recycled - in that case it'll only see the last one. So keep