Re: [UPDATE][RFC/RFT][PATCH 07/10] cpufreq: intel_pstate: HWP boost performance on busy task migrate

2018-05-17 Thread Srinivas Pandruvada
On Thu, 2018-05-17 at 10:23 +0200, Peter Zijlstra wrote: > On Wed, May 16, 2018 at 01:51:11PM -0700, Srinivas Pandruvada wrote: > > @@ -263,6 +264,7 @@ struct cpudata { > >   call_single_data_t csd; > >   bool hwp_boost_active; > >   u64 last_io_update; > > + bool migrate_hint; > >  }; >

Re: [UPDATE][RFC/RFT][PATCH 07/10] cpufreq: intel_pstate: HWP boost performance on busy task migrate

2018-05-17 Thread Srinivas Pandruvada
On Thu, 2018-05-17 at 10:23 +0200, Peter Zijlstra wrote: > On Wed, May 16, 2018 at 01:51:11PM -0700, Srinivas Pandruvada wrote: > > @@ -263,6 +264,7 @@ struct cpudata { > >   call_single_data_t csd; > >   bool hwp_boost_active; > >   u64 last_io_update; > > + bool migrate_hint; > >  }; >

Re: [UPDATE][RFC/RFT][PATCH 07/10] cpufreq: intel_pstate: HWP boost performance on busy task migrate

2018-05-17 Thread Peter Zijlstra
On Wed, May 16, 2018 at 01:51:11PM -0700, Srinivas Pandruvada wrote: > @@ -263,6 +264,7 @@ struct cpudata { > call_single_data_t csd; > bool hwp_boost_active; > u64 last_io_update; > + bool migrate_hint; > }; You want to look at that structure layout...

Re: [UPDATE][RFC/RFT][PATCH 07/10] cpufreq: intel_pstate: HWP boost performance on busy task migrate

2018-05-17 Thread Peter Zijlstra
On Wed, May 16, 2018 at 01:51:11PM -0700, Srinivas Pandruvada wrote: > @@ -263,6 +264,7 @@ struct cpudata { > call_single_data_t csd; > bool hwp_boost_active; > u64 last_io_update; > + bool migrate_hint; > }; You want to look at that structure layout...

Re: [RFC/RFT] [PATCH 07/10] cpufreq: intel_pstate: HWP boost performance on busy task migrate

2018-05-16 Thread Srinivas Pandruvada
On Wed, 2018-05-16 at 11:49 +0200, Rafael J. Wysocki wrote: > On Wed, May 16, 2018 at 6:49 AM, Srinivas Pandruvada > wrote: > > When a busy task migrates to a new CPU boost HWP prformance to max. > > This > > helps workloads on servers with per core P-states,

Re: [RFC/RFT] [PATCH 07/10] cpufreq: intel_pstate: HWP boost performance on busy task migrate

2018-05-16 Thread Srinivas Pandruvada
On Wed, 2018-05-16 at 11:49 +0200, Rafael J. Wysocki wrote: > On Wed, May 16, 2018 at 6:49 AM, Srinivas Pandruvada > wrote: > > When a busy task migrates to a new CPU boost HWP prformance to max. > > This > > helps workloads on servers with per core P-states, which saturates > > all > > CPUs and

[UPDATE][RFC/RFT][PATCH 07/10] cpufreq: intel_pstate: HWP boost performance on busy task migrate

2018-05-16 Thread Srinivas Pandruvada
When a busy task migrates to a new CPU boost HWP prformance to max. This helps workloads on servers with per core P-states, which saturates all CPUs and then they migrate frequently. But changing limits has extra over head of issuing new HWP Request MSR, which takes 1000+ cycles. So this change

[UPDATE][RFC/RFT][PATCH 07/10] cpufreq: intel_pstate: HWP boost performance on busy task migrate

2018-05-16 Thread Srinivas Pandruvada
When a busy task migrates to a new CPU boost HWP prformance to max. This helps workloads on servers with per core P-states, which saturates all CPUs and then they migrate frequently. But changing limits has extra over head of issuing new HWP Request MSR, which takes 1000+ cycles. So this change

Re: [RFC/RFT] [PATCH 07/10] cpufreq: intel_pstate: HWP boost performance on busy task migrate

2018-05-16 Thread Rafael J. Wysocki
On Wed, May 16, 2018 at 6:49 AM, Srinivas Pandruvada wrote: > When a busy task migrates to a new CPU boost HWP prformance to max. This > helps workloads on servers with per core P-states, which saturates all > CPUs and then they migrate frequently. But

Re: [RFC/RFT] [PATCH 07/10] cpufreq: intel_pstate: HWP boost performance on busy task migrate

2018-05-16 Thread Rafael J. Wysocki
On Wed, May 16, 2018 at 6:49 AM, Srinivas Pandruvada wrote: > When a busy task migrates to a new CPU boost HWP prformance to max. This > helps workloads on servers with per core P-states, which saturates all > CPUs and then they migrate frequently. But changing limits has extra over > head of

[RFC/RFT] [PATCH 07/10] cpufreq: intel_pstate: HWP boost performance on busy task migrate

2018-05-15 Thread Srinivas Pandruvada
When a busy task migrates to a new CPU boost HWP prformance to max. This helps workloads on servers with per core P-states, which saturates all CPUs and then they migrate frequently. But changing limits has extra over head of issuing new HWP Request MSR, which takes 1000+ cycles. So this change

[RFC/RFT] [PATCH 07/10] cpufreq: intel_pstate: HWP boost performance on busy task migrate

2018-05-15 Thread Srinivas Pandruvada
When a busy task migrates to a new CPU boost HWP prformance to max. This helps workloads on servers with per core P-states, which saturates all CPUs and then they migrate frequently. But changing limits has extra over head of issuing new HWP Request MSR, which takes 1000+ cycles. So this change