Re: [RFC/RFT] [PATCH v2 4/6] cpufreq: intel_pstate: HWP boost performance on IO wakeup

2018-05-29 Thread Pandruvada, Srinivas
On Tue, 2018-05-29 at 09:44 +0200, Rafael J. Wysocki wrote: > On Thu, May 24, 2018 at 3:47 AM, Srinivas Pandruvada > wrote: [...] > > > > +   cpu->sample.time = time; > > +   io_flag = test_and_clear_bit(SCHED_CPUFREQ_IOWAIT, > > >sched_flags); > > I don't think you need to use bit

Re: [RFC/RFT] [PATCH v2 4/6] cpufreq: intel_pstate: HWP boost performance on IO wakeup

2018-05-29 Thread Pandruvada, Srinivas
On Tue, 2018-05-29 at 09:44 +0200, Rafael J. Wysocki wrote: > On Thu, May 24, 2018 at 3:47 AM, Srinivas Pandruvada > wrote: [...] > > > > +   cpu->sample.time = time; > > +   io_flag = test_and_clear_bit(SCHED_CPUFREQ_IOWAIT, > > >sched_flags); > > I don't think you need to use bit

Re: [RFC/RFT] [PATCH v2 4/6] cpufreq: intel_pstate: HWP boost performance on IO wakeup

2018-05-29 Thread Rafael J. Wysocki
On Thu, May 24, 2018 at 3:47 AM, Srinivas Pandruvada wrote: > This change uses SCHED_CPUFREQ_IOWAIT flag to boost HWP performance. > Since SCHED_CPUFREQ_IOWAIT flag is set frequently, we don't start > boosting steps unless we see two consecutive flags in two ticks. This > avoids boosting due to

Re: [RFC/RFT] [PATCH v2 4/6] cpufreq: intel_pstate: HWP boost performance on IO wakeup

2018-05-29 Thread Rafael J. Wysocki
On Thu, May 24, 2018 at 3:47 AM, Srinivas Pandruvada wrote: > This change uses SCHED_CPUFREQ_IOWAIT flag to boost HWP performance. > Since SCHED_CPUFREQ_IOWAIT flag is set frequently, we don't start > boosting steps unless we see two consecutive flags in two ticks. This > avoids boosting due to

[RFC/RFT] [PATCH v2 4/6] cpufreq: intel_pstate: HWP boost performance on IO wakeup

2018-05-23 Thread Srinivas Pandruvada
This change uses SCHED_CPUFREQ_IOWAIT flag to boost HWP performance. Since SCHED_CPUFREQ_IOWAIT flag is set frequently, we don't start boosting steps unless we see two consecutive flags in two ticks. This avoids boosting due to IO because of regular system activities. To avoid synchronization

[RFC/RFT] [PATCH v2 4/6] cpufreq: intel_pstate: HWP boost performance on IO wakeup

2018-05-23 Thread Srinivas Pandruvada
This change uses SCHED_CPUFREQ_IOWAIT flag to boost HWP performance. Since SCHED_CPUFREQ_IOWAIT flag is set frequently, we don't start boosting steps unless we see two consecutive flags in two ticks. This avoids boosting due to IO because of regular system activities. To avoid synchronization