Re: [RFC/RFT 5/5] phy: exynos5-usbdrd: drop duplicate setting PIPE3 tune signal

2019-07-24 Thread Krzysztof Kozlowski
On Mon, 22 Jul 2019 at 21:00, Anand Moon  wrote:
>
> Drop duplicate configuration setting of PIPE tune signal.

There is no duplicate set. This is either completely wrong or put in
wrong order of entire patchset...

Best regards,
Krzysztof


[RFC/RFT 5/5] phy: exynos5-usbdrd: drop duplicate setting PIPE3 tune signal

2019-07-22 Thread Anand Moon
Drop duplicate configuration setting of PIPE tune signal.

Signed-off-by: Anand Moon 
---
 drivers/phy/samsung/phy-exynos5-usbdrd.c | 6 --
 1 file changed, 6 deletions(-)

diff --git a/drivers/phy/samsung/phy-exynos5-usbdrd.c 
b/drivers/phy/samsung/phy-exynos5-usbdrd.c
index 4f16c4f82ae5..f6d2f359d88a 100644
--- a/drivers/phy/samsung/phy-exynos5-usbdrd.c
+++ b/drivers/phy/samsung/phy-exynos5-usbdrd.c
@@ -410,12 +410,6 @@ static void exynos5_usbdrd_utmi_init(struct 
exynos5_usbdrd_phy *phy_drd)
PHYPARAM0_COMPDISTUNE(0x6));
writel(reg, phy_drd->reg_phy + EXYNOS5_DRD_PHYPARAM0);
 
-   reg = readl(phy_drd->reg_phy + EXYNOS5_DRD_PHYPARAM1);
-   /* Set Tx De-Emphasis level */
-   reg &= ~PHYPARAM1_PCS_TXDEEMPH_MASK;
-   reg |=  PHYPARAM1_PCS_TXDEEMPH;
-   writel(reg, phy_drd->reg_phy + EXYNOS5_DRD_PHYPARAM1);
-
/* UTMI Power Control */
writel(PHYUTMI_OTGDISABLE, phy_drd->reg_phy + EXYNOS5_DRD_PHYUTMI);
 
-- 
2.22.0