Re: [RFC/RFT PATCH 2/4] drm/bridge: dw-hdmi: Add support for custom PHY handling

2017-01-19 Thread Jose Abreu
Hi Neil, On 18-01-2017 11:20, Neil Armstrong wrote: > > It's the idea we discussed with Laurent. > Keeping the Synopsys PHY code inside the dw-hdmi driver would be simpler. > > But don't you think adding a proper "ops" structure apart from the plat_data > should be necessary ? > > Neil > An

Re: [RFC/RFT PATCH 2/4] drm/bridge: dw-hdmi: Add support for custom PHY handling

2017-01-19 Thread Jose Abreu
Hi Neil, On 18-01-2017 11:20, Neil Armstrong wrote: > > It's the idea we discussed with Laurent. > Keeping the Synopsys PHY code inside the dw-hdmi driver would be simpler. > > But don't you think adding a proper "ops" structure apart from the plat_data > should be necessary ? > > Neil > An

Re: [RFC/RFT PATCH 2/4] drm/bridge: dw-hdmi: Add support for custom PHY handling

2017-01-18 Thread Jose Abreu
Hi Neil, On 17-01-2017 12:31, Neil Armstrong wrote: > @@ -1434,9 +1434,18 @@ static int dw_hdmi_setup(struct dw_hdmi *hdmi, struct > drm_display_mode *mode) > hdmi_av_composer(hdmi, mode); > > /* HDMI Initializateion Step B.2 */ > - ret = dw_hdmi_phy_init(hdmi); > - if

Re: [RFC/RFT PATCH 2/4] drm/bridge: dw-hdmi: Add support for custom PHY handling

2017-01-18 Thread Jose Abreu
Hi Neil, On 17-01-2017 12:31, Neil Armstrong wrote: > @@ -1434,9 +1434,18 @@ static int dw_hdmi_setup(struct dw_hdmi *hdmi, struct > drm_display_mode *mode) > hdmi_av_composer(hdmi, mode); > > /* HDMI Initializateion Step B.2 */ > - ret = dw_hdmi_phy_init(hdmi); > - if

Re: [RFC/RFT PATCH 2/4] drm/bridge: dw-hdmi: Add support for custom PHY handling

2017-01-18 Thread Neil Armstrong
Hi Jose, On 01/18/2017 11:40 AM, Jose Abreu wrote: > Hi Neil, > > > On 17-01-2017 12:31, Neil Armstrong wrote: >> @@ -1434,9 +1434,18 @@ static int dw_hdmi_setup(struct dw_hdmi *hdmi, struct >> drm_display_mode *mode) >> hdmi_av_composer(hdmi, mode); >> >> /* HDMI Initializateion

Re: [RFC/RFT PATCH 2/4] drm/bridge: dw-hdmi: Add support for custom PHY handling

2017-01-18 Thread Neil Armstrong
Hi Jose, On 01/18/2017 11:40 AM, Jose Abreu wrote: > Hi Neil, > > > On 17-01-2017 12:31, Neil Armstrong wrote: >> @@ -1434,9 +1434,18 @@ static int dw_hdmi_setup(struct dw_hdmi *hdmi, struct >> drm_display_mode *mode) >> hdmi_av_composer(hdmi, mode); >> >> /* HDMI Initializateion

Re: [RFC/RFT PATCH 2/4] drm/bridge: dw-hdmi: Add support for custom PHY handling

2017-01-17 Thread Laurent Pinchart
Hi Neil, Thank you for the patch. On Tuesday 17 Jan 2017 13:31:32 Neil Armstrong wrote: > The Synopsys DesignWare HDMI TX Controller support various Transceivers > (PHY) attached to the controller, but also allows fully custom PHYs to be > connected. > > Add PHY init, disable functions in

Re: [RFC/RFT PATCH 2/4] drm/bridge: dw-hdmi: Add support for custom PHY handling

2017-01-17 Thread Laurent Pinchart
Hi Neil, Thank you for the patch. On Tuesday 17 Jan 2017 13:31:32 Neil Armstrong wrote: > The Synopsys DesignWare HDMI TX Controller support various Transceivers > (PHY) attached to the controller, but also allows fully custom PHYs to be > connected. > > Add PHY init, disable functions in

[RFC/RFT PATCH 2/4] drm/bridge: dw-hdmi: Add support for custom PHY handling

2017-01-17 Thread Neil Armstrong
The Synopsys DesignWare HDMI TX Controller support various Transceivers (PHY) attached to the controller, but also allows fully custom PHYs to be connected. Add PHY init, disable functions in plat_data to handle fully custom PHY init. Some custom PHYs also handles the HPD and RxSense separately

[RFC/RFT PATCH 2/4] drm/bridge: dw-hdmi: Add support for custom PHY handling

2017-01-17 Thread Neil Armstrong
The Synopsys DesignWare HDMI TX Controller support various Transceivers (PHY) attached to the controller, but also allows fully custom PHYs to be connected. Add PHY init, disable functions in plat_data to handle fully custom PHY init. Some custom PHYs also handles the HPD and RxSense separately